iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Published Dashboard without charts don't show up for non admin users (#20638)

This commit is contained in:
Diego Medina 2022-07-27 15:40:59 -03:00 committed by GitHub
parent ab415fddd9
commit 8b354b4b69
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset/dashboards/filters.py
View File

@ -111,7 +111,7 @@ class DashboardAccessFilter(BaseFilter): # pylint: disable=too-few-public-metho
datasource_perm_query = (
db.session.query(Dashboard.id)
.join(Dashboard.slices)
.join(Dashboard.slices, isouter=True)
.filter(
and_(
Dashboard.published.is_(True),

2
superset/sql_parse.py
View File

@ -494,7 +494,7 @@ class InsertRLSState(str, Enum):
def has_table_query(token_list: TokenList) -> bool:
"""
Return if a stament has a query reading from a table.
Return if a statement has a query reading from a table.
>>> has_table_query(sqlparse.parse("COUNT(*)")[0])
False