From 8db419fe99ce3e3c940d6ba41ddae2528fd67995 Mon Sep 17 00:00:00 2001 From: Daniel Vaz Gaspar Date: Tue, 6 Aug 2019 06:52:43 +0100 Subject: [PATCH] [database] Fix, Removes the limit for the page size (#7987) Old FAB API had no limits by default, this will keep this behaviour but only for this endpoint --- superset/assets/src/components/TableSelector.jsx | 3 ++- superset/views/database/api.py | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/superset/assets/src/components/TableSelector.jsx b/superset/assets/src/components/TableSelector.jsx index d380241b7..9ead6dd7f 100644 --- a/superset/assets/src/components/TableSelector.jsx +++ b/superset/assets/src/components/TableSelector.jsx @@ -218,7 +218,8 @@ export default class TableSelector extends React.PureComponent { '/api/v1/database/?q=' + '(keys:!(none),' + 'filters:!((col:expose_in_sqllab,opr:eq,value:!t)),' + - 'order_columns:database_name,order_direction:asc)' + 'order_columns:database_name,order_direction:asc,' + + 'page:0,page_size:-1)' } onChange={this.onDatabaseChange} onAsyncError={() => this.props.handleError(t('Error while fetching database list'))} diff --git a/superset/views/database/api.py b/superset/views/database/api.py index dea17ba56..2bb8ea5f3 100644 --- a/superset/views/database/api.py +++ b/superset/views/database/api.py @@ -50,6 +50,8 @@ class DatabaseRestApi(DatabaseMixin, ModelRestApi): "allows_subquery", "backend", ] + # Removes the local limit for the page size + max_page_size = -1 appbuilder.add_api(DatabaseRestApi)