build(node): Bumping to Node 20 (#29988)

2024-08-21 16:48:21 -06:00 · 2024-08-21 16:48:21 -06:00 · 8e2f81816f
parent 1ca5947a7d
commit 8e2f81816f
18 changed files with 20 additions and 20 deletions
--- a/.github/workflows/embedded-sdk-release.yml
+++ b/.github/workflows/embedded-sdk-release.yml
@ -31,7 +31,7 @@ jobs:
      - uses: actions/checkout@v4
      - uses: actions/setup-node@v4
        with:
-          node-version: "18"
+          node-version: "20"
          registry-url: 'https://registry.npmjs.org'
      - run: npm ci
      - run: npm run ci:release
--- a/.github/workflows/embedded-sdk-test.yml
+++ b/.github/workflows/embedded-sdk-test.yml
@ -21,7 +21,7 @@ jobs:
      - uses: actions/checkout@v4
      - uses: actions/setup-node@v4
        with:
-          node-version: "18"
+          node-version: "20"
          registry-url: 'https://registry.npmjs.org'
      - run: npm ci
      - run: npm test
--- a/.github/workflows/github-action-validator.yml
+++ b/.github/workflows/github-action-validator.yml
@ -19,7 +19,7 @@ jobs:
      - name: Set up Node.js
        uses: actions/setup-node@v4
        with:
-          node-version: '18'
+          node-version: '20'

      - name: Install Dependencies
        run: npm install -g @action-validator/core @action-validator/cli --save-dev
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@ -29,7 +29,7 @@ jobs:

    strategy:
      matrix:
-        node-version: [18]
+        node-version: [20]

    steps:
      - uses: actions/checkout@v4
--- a/.github/workflows/superset-applitool-cypress.yml
+++ b/.github/workflows/superset-applitool-cypress.yml
@ -26,7 +26,7 @@ jobs:
      fail-fast: false
      matrix:
        browser: ["chrome"]
-        node: [18]
+        node: [20]
    env:
      SUPERSET_ENV: development
      SUPERSET_CONFIG: tests.integration_tests.superset_test_config
--- a/.github/workflows/superset-applitools-storybook.yml
+++ b/.github/workflows/superset-applitools-storybook.yml
@ -30,7 +30,7 @@ jobs:
    runs-on: ubuntu-22.04
    strategy:
      matrix:
-        node: [18]
+        node: [20]
    steps:
      - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
        uses: actions/checkout@v4
--- a/.github/workflows/superset-e2e.yml
+++ b/.github/workflows/superset-e2e.yml
@ -107,7 +107,7 @@ jobs:
        if: steps.check.outputs.python || steps.check.outputs.frontend
        uses: actions/setup-node@v4
        with:
-          node-version: "18"
+          node-version: "20"
      - name: Install npm dependencies
        if: steps.check.outputs.python || steps.check.outputs.frontend
        uses: ./.github/actions/cached-dependencies
--- a/.github/workflows/superset-frontend.yml
+++ b/.github/workflows/superset-frontend.yml
@ -33,7 +33,7 @@ jobs:
        if: steps.check.outputs.frontend
        uses: actions/setup-node@v4
        with:
-          node-version: "18"
+          node-version: "20"
      - name: Install dependencies
        if: steps.check.outputs.frontend
        uses: ./.github/actions/cached-dependencies
--- a/.github/workflows/tech-debt.yml
+++ b/.github/workflows/tech-debt.yml
@ -32,7 +32,7 @@ jobs:
      - name: Set up Node.js
        uses: actions/setup-node@v4
        with:
-          node-version: '18'
+          node-version: '20'

      - name: Install Dependencies
        run: npm install
--- a/2
+++ b/2
@ -22,7 +22,7 @@ ARG PY_VER=3.10-slim-bookworm

 # if BUILDPLATFORM is null, set it to 'amd64' (or leave as is otherwise).
 ARG BUILDPLATFORM=${BUILDPLATFORM:-amd64}
-FROM --platform=${BUILDPLATFORM} node:18-bullseye-slim AS superset-node
+FROM --platform=${BUILDPLATFORM} node:20-bullseye-slim AS superset-node

 ARG NPM_BUILD_CMD="build"

--- a/docker-compose.yml
+++ b/docker-compose.yml
@ -147,7 +147,7 @@ services:
      disable: true

  superset-node:
-    image: node:18
+    image: node:20
    environment:
      # set this to false if you have perf issues running the npm i; npm run dev in-docker
      # if you do so, you have to run this manually on the host, which should perform better!
--- a/docs/.nvmrc
+++ b/docs/.nvmrc
@ -1 +1 @@
-v20.12.2
+v20.16.0
--- a/docs/docs/contributing/development.mdx
+++ b/docs/docs/contributing/development.mdx
@ -268,7 +268,7 @@ Frontend assets (TypeScript, JavaScript, CSS, and images) must be compiled in or

 First, be sure you are using the following versions of Node.js and npm:

- `Node.js`: Version 18
+- `Node.js`: Version 20
 - `npm`: Version 10

 We recommend using [nvm](https://github.com/nvm-sh/nvm) to manage your node environment:
--- a/superset-frontend/.nvmrc
+++ b/superset-frontend/.nvmrc
@ -1 +1 @@
-v18.20.1
+v20.16.0
--- a/superset-frontend/package-lock.json
+++ b/superset-frontend/package-lock.json
@ -292,8 +292,8 @@
        "xdm": "^3.4.0"
      },
      "engines": {
-        "node": "^18.19.1",
-        "npm": "^10.2.4"
+        "node": "^20.16.0",
+        "npm": "^10.8.1"
      }
    },
    "node_modules/@aashutoshrathi/word-wrap": {
--- a/superset-frontend/package.json
+++ b/superset-frontend/package.json
@ -358,8 +358,8 @@
    "xdm": "^3.4.0"
  },
  "engines": {
-    "node": "^18.19.1",
-    "npm": "^10.2.4"
+    "node": "^20.16.0",
+    "npm": "^10.8.1"
  },
  "overrides": {
    "d3-color": "^3.1.0",
--- a/superset-websocket/.nvmrc
+++ b/superset-websocket/.nvmrc
@ -1 +1 @@
-v18.20.1
+v20.16.0
--- a/superset-websocket/utils/client-ws-app/.nvmrc
+++ b/superset-websocket/utils/client-ws-app/.nvmrc
@ -1 +1 @@
-v18.20.1
+v20.16.0