From 906a629b338b5f086ed9e1d094b0f4dcb2ac132f Mon Sep 17 00:00:00 2001 From: Kamil Gabryjelski Date: Mon, 14 Sep 2020 19:31:16 +0200 Subject: [PATCH] Re-enable rule no-unused-state (#10871) --- superset-frontend/.eslintrc.js | 2 -- .../src/SqlLab/components/QuerySearch.jsx | 2 -- .../src/SqlLab/components/QueryTable.jsx | 17 +---------------- .../src/SqlLab/components/SaveQuery.jsx | 4 ++-- .../src/addSlice/AddSliceContainer.tsx | 1 - .../src/dashboard/components/CssEditor.jsx | 1 - .../src/explore/components/SaveModal.jsx | 2 -- .../components/controls/ColorSchemeControl.jsx | 4 ---- .../components/controls/DatasourceControl.jsx | 1 - 9 files changed, 3 insertions(+), 31 deletions(-) diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js index 0410c52fc..15dba0aea 100644 --- a/superset-frontend/.eslintrc.js +++ b/superset-frontend/.eslintrc.js @@ -130,7 +130,6 @@ module.exports = { 'react/no-string-refs': 0, 'react/no-unescaped-entities': 0, 'react/no-unused-prop-types': 0, - 'react/no-unused-state': 0, // disabled temporarily 'react/prop-types': 0, 'react/require-default-props': 0, 'react/sort-comp': 0, // disabled temporarily @@ -252,7 +251,6 @@ module.exports = { 'react/no-string-refs': 0, 'react/no-unescaped-entities': 0, 'react/no-unused-prop-types': 0, - 'react/no-unused-state': 0, // disabled temporarily 'react/prop-types': 0, 'react/require-default-props': 0, 'react/sort-comp': 0, // disabled temporarily diff --git a/superset-frontend/src/SqlLab/components/QuerySearch.jsx b/superset-frontend/src/SqlLab/components/QuerySearch.jsx index cb517af03..d794222bf 100644 --- a/superset-frontend/src/SqlLab/components/QuerySearch.jsx +++ b/superset-frontend/src/SqlLab/components/QuerySearch.jsx @@ -43,8 +43,6 @@ class QuerySearch extends React.PureComponent { constructor(props) { super(props); this.state = { - userLoading: false, - userOptions: [], databaseId: null, userId: null, searchText: null, diff --git a/superset-frontend/src/SqlLab/components/QueryTable.jsx b/superset-frontend/src/SqlLab/components/QueryTable.jsx index e92940d4f..2a23acd4f 100644 --- a/superset-frontend/src/SqlLab/components/QueryTable.jsx +++ b/superset-frontend/src/SqlLab/components/QueryTable.jsx @@ -48,26 +48,11 @@ const defaultProps = { }; class QueryTable extends React.PureComponent { - constructor(props) { - super(props); - const uri = window.location.toString(); - const cleanUri = uri.substring(0, uri.indexOf('#')); - this.state = { - cleanUri, - showVisualizeModal: false, - activeQuery: null, - }; - } openQuery(id) { const url = `/superset/sqllab?queryId=${id}`; window.open(url); } - hideVisualizeModal() { - this.setState({ showVisualizeModal: false }); - } - showVisualizeModal(query) { - this.setState({ activeQuery: query, showVisualizeModal: true }); - } + restoreSql(query) { this.props.actions.queryEditorSetSql({ id: query.sqlEditorId }, query.sql); } diff --git a/superset-frontend/src/SqlLab/components/SaveQuery.jsx b/superset-frontend/src/SqlLab/components/SaveQuery.jsx index ccb075d9c..e7ed40883 100644 --- a/superset-frontend/src/SqlLab/components/SaveQuery.jsx +++ b/superset-frontend/src/SqlLab/components/SaveQuery.jsx @@ -82,8 +82,8 @@ class SaveQuery extends React.PureComponent { close() { if (this.saveModal) this.saveModal.close(); } - toggleSave(e) { - this.setState({ target: e.target, showSave: !this.state.showSave }); + toggleSave() { + this.setState({ showSave: !this.state.showSave }); } renderModalBody() { const isSaved = !!this.props.query.remoteId; diff --git a/superset-frontend/src/addSlice/AddSliceContainer.tsx b/superset-frontend/src/addSlice/AddSliceContainer.tsx index 0180839f8..f42b9778e 100644 --- a/superset-frontend/src/addSlice/AddSliceContainer.tsx +++ b/superset-frontend/src/addSlice/AddSliceContainer.tsx @@ -75,7 +75,6 @@ export default class AddSliceContainer extends React.PureComponent< this.setState({ datasourceValue: option.value, datasourceId: option.value.split('__')[0], - datasourceType: option.value.split('__')[1], }); } diff --git a/superset-frontend/src/dashboard/components/CssEditor.jsx b/superset-frontend/src/dashboard/components/CssEditor.jsx index 4048cd897..a412f6dfd 100644 --- a/superset-frontend/src/dashboard/components/CssEditor.jsx +++ b/superset-frontend/src/dashboard/components/CssEditor.jsx @@ -44,7 +44,6 @@ class CssEditor extends React.PureComponent { super(props); this.state = { css: props.initialCss, - cssTemplateOptions: [], }; this.changeCss = this.changeCss.bind(this); this.changeCssTemplate = this.changeCssTemplate.bind(this); diff --git a/superset-frontend/src/explore/components/SaveModal.jsx b/superset-frontend/src/explore/components/SaveModal.jsx index 4e36e04b8..d20d3e9c0 100644 --- a/superset-frontend/src/explore/components/SaveModal.jsx +++ b/superset-frontend/src/explore/components/SaveModal.jsx @@ -49,10 +49,8 @@ class SaveModal extends React.Component { this.state = { saveToDashboardId: null, newSliceName: props.sliceName, - dashboards: [], alert: null, action: props.can_overwrite ? 'overwrite' : 'saveas', - vizType: props.form_data.viz_type, }; this.onDashboardSelectChange = this.onDashboardSelectChange.bind(this); this.onSliceNameChange = this.onSliceNameChange.bind(this); diff --git a/superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx b/superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx index 60f91acca..4b9d6e4f4 100644 --- a/superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx +++ b/superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx @@ -50,9 +50,6 @@ const defaultProps = { export default class ColorSchemeControl extends React.PureComponent { constructor(props) { super(props); - this.state = { - scheme: this.props.value, - }; this.onChange = this.onChange.bind(this); this.renderOption = this.renderOption.bind(this); } @@ -60,7 +57,6 @@ export default class ColorSchemeControl extends React.PureComponent { onChange(option) { const optionValue = option ? option.value : null; this.props.onChange(optionValue); - this.setState({ scheme: optionValue }); } renderOption(key) { diff --git a/superset-frontend/src/explore/components/controls/DatasourceControl.jsx b/superset-frontend/src/explore/components/controls/DatasourceControl.jsx index e12d83799..69c5e718a 100644 --- a/superset-frontend/src/explore/components/controls/DatasourceControl.jsx +++ b/superset-frontend/src/explore/components/controls/DatasourceControl.jsx @@ -60,7 +60,6 @@ class DatasourceControl extends React.PureComponent { this.state = { showEditDatasourceModal: false, showChangeDatasourceModal: false, - menuExpanded: false, }; this.onDatasourceSave = this.onDatasourceSave.bind(this); this.toggleChangeDatasourceModal = this.toggleChangeDatasourceModal.bind(