From 925938b4d1595815ffe479659ad4b8802061c6b7 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Fri, 24 Jan 2025 11:34:52 -0800 Subject: [PATCH] feat: run prettier before eslint in pre-commit hooks (#31984) --- .pre-commit-config.yaml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index bb34ee405..a40c26f21 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -52,14 +52,6 @@ repos: - id: trailing-whitespace exclude: ^.*\.(snap) args: ["--markdown-linebreak-ext=md"] - - repo: local - hooks: - - id: eslint - name: eslint - entry: bash -c 'cd superset-frontend && npm run eslint -- $(echo "$@" | sed "s|superset-frontend/||g")' - language: system - pass_filenames: true - files: \.(js|jsx|ts|tsx)$ - repo: https://github.com/pre-commit/mirrors-prettier rev: v4.0.0-alpha.8 # Use the sha or tag you want to point at hooks: @@ -68,6 +60,14 @@ repos: - prettier@3.3.3 args: ["--ignore-path=./superset-frontend/.prettierignore"] files: "superset-frontend" + - repo: local + hooks: + - id: eslint + name: eslint + entry: bash -c 'cd superset-frontend && npm run eslint -- $(echo "$@" | sed "s|superset-frontend/||g")' + language: system + pass_filenames: true + files: \.(js|jsx|ts|tsx)$ # blacklist unsafe functions like make_url (see #19526) - repo: https://github.com/skorokithakis/blacklist-pre-commit-hook rev: e2f070289d8eddcaec0b580d3bde29437e7c8221