From 9841c78967e64e6d4cec12c8db6fea8539dd32d8 Mon Sep 17 00:00:00 2001 From: Junlin Chen Date: Tue, 10 Aug 2021 17:23:14 -1000 Subject: [PATCH] chore: switch back tag name to popular from highly-used (#16174) * chore: switch back tag name to popular from highly-used * new package lock * new package lock with npm 7 * fix lint * remove package changes Co-authored-by: Beto Dealmeida --- .../javascripts/explore/components/VizTypeControl_spec.jsx | 2 +- .../components/controls/VizTypeControl/VizTypeGallery.tsx | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/superset-frontend/spec/javascripts/explore/components/VizTypeControl_spec.jsx b/superset-frontend/spec/javascripts/explore/components/VizTypeControl_spec.jsx index 02cbdac19..c027fd0c3 100644 --- a/superset-frontend/spec/javascripts/explore/components/VizTypeControl_spec.jsx +++ b/superset-frontend/spec/javascripts/explore/components/VizTypeControl_spec.jsx @@ -50,7 +50,7 @@ describe('VizTypeControl', () => { new ChartMetadata({ name: 'vis1', thumbnail: '', - tags: ['Highly-used'], + tags: ['Popular'], }), ) .registerValue( diff --git a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx index bbbbeab91..7f2933428 100644 --- a/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx +++ b/superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx @@ -121,11 +121,7 @@ const OTHER_CATEGORY = t('Other'); const ALL_CHARTS = t('All charts'); -const RECOMMENDED_TAGS = [ - t('Highly-used'), - t('ECharts'), - t('Advanced-Analytics'), -]; +const RECOMMENDED_TAGS = [t('Popular'), t('ECharts'), t('Advanced-Analytics')]; export const VIZ_TYPE_CONTROL_TEST_ID = 'viz-type-control';