+ {t('Rows')}
+
+ {t(
+ 'Set header rows and the number of rows to read or skip.',
+ )}
+
+
+ }
+ key="4"
+ >
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ )}
diff --git a/superset-frontend/src/features/home/Menu.test.tsx b/superset-frontend/src/features/home/Menu.test.tsx
index 28ef85aad..01e3ea2a9 100644
--- a/superset-frontend/src/features/home/Menu.test.tsx
+++ b/superset-frontend/src/features/home/Menu.test.tsx
@@ -43,19 +43,19 @@ const dropdownItems = [
{
label: 'Upload a CSV',
name: 'Upload a CSV',
- url: '/csvtodatabaseview/form',
+ url: '#',
perm: true,
},
{
label: 'Upload a Columnar File',
name: 'Upload a Columnar file',
- url: '/columnartodatabaseview/form',
+ url: '#',
perm: true,
},
{
label: 'Upload Excel',
name: 'Upload Excel',
- url: '/exceltodatabaseview/form',
+ url: '#',
perm: true,
},
],
diff --git a/superset-frontend/src/features/home/RightMenu.test.tsx b/superset-frontend/src/features/home/RightMenu.test.tsx
index 307064594..1cce6064a 100644
--- a/superset-frontend/src/features/home/RightMenu.test.tsx
+++ b/superset-frontend/src/features/home/RightMenu.test.tsx
@@ -54,13 +54,13 @@ const dropdownItems = [
{
label: 'Upload CSV to database',
name: 'Upload a CSV',
- url: '/csvtodatabaseview/form',
+ url: '#',
perm: true,
},
{
label: 'Upload columnar file to database',
name: 'Upload a Columnar file',
- url: '/columnartodatabaseview/form',
+ url: '#',
perm: true,
},
],
@@ -309,12 +309,10 @@ test('If there is a DB with allow_file_upload set as True the option should be e
userEvent.hover(dropdown);
const dataMenu = await screen.findByText(dropdownItems[0].label);
userEvent.hover(dataMenu);
+ expect(await screen.findByText('Upload CSV to database')).toBeInTheDocument();
expect(
- (await screen.findByText('Upload CSV to database')).closest('a'),
- ).toHaveAttribute('href', '#');
- expect(
- (await screen.findByText('Upload Excel to database')).closest('a'),
- ).toHaveAttribute('href', '#');
+ await screen.findByText('Upload Excel to database'),
+ ).toBeInTheDocument();
});
test('If there is NOT a DB with allow_file_upload set as True the option should be disabled', async () => {
diff --git a/superset-frontend/src/features/home/RightMenu.tsx b/superset-frontend/src/features/home/RightMenu.tsx
index ff4a6a809..d88269cf5 100644
--- a/superset-frontend/src/features/home/RightMenu.tsx
+++ b/superset-frontend/src/features/home/RightMenu.tsx
@@ -45,6 +45,7 @@ import {
} from 'src/types/bootstrapTypes';
import { RootState } from 'src/dashboard/types';
import DatabaseModal from 'src/features/databases/DatabaseModal';
+import UploadDataModal from 'src/features/databases/UploadDataModel';
import { uploadUserPerms } from 'src/views/CRUD/utils';
import TelemetryPixel from 'src/components/TelemetryPixel';
import LanguagePicker from './LanguagePicker';
@@ -143,6 +144,11 @@ const RightMenu = ({
HAS_GSHEETS_INSTALLED,
} = useSelector