iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ESLint: Re-enable rule default-props-match-prop-types (#10868) 

* Re-enable rule default-props-match-prop-types

* Restore default props and remove isRequired

* Remove unused props
This commit is contained in:
Kamil Gabryjelski 2020-09-22 22:17:41 +02:00 committed by GitHub
parent a9eab33d64
commit 9f01a7fdf8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
21 changed files with 13 additions and 60 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/.eslintrc.js
View File

@ -117,7 +117,6 @@ module.exports = {
'padded-blocks': 0,
'prefer-arrow-callback': 0,
'prefer-destructuring': ['error', { object: true, array: false }],
'react/default-props-match-prop-types': 0, // disabled temporarily
'react/destructuring-assignment': 0, // re-enable up for discussion
'react/forbid-prop-types': 0,
'react/jsx-filename-extension': [1, { extensions: ['.jsx', '.tsx'] }],
@ -228,7 +227,6 @@ module.exports = {
'prefer-arrow-callback': 0,
'prefer-object-spread': 1,
'prefer-destructuring': ['error', { object: true, array: false }],
'react/default-props-match-prop-types': 0, // disabled temporarily
'react/destructuring-assignment': 0, // re-enable up for discussion
'react/forbid-prop-types': 0,
'react/jsx-filename-extension': [1, { extensions: ['.jsx', '.tsx'] }],

3
superset-frontend/spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx
View File

@ -62,9 +62,6 @@ describe('DashboardBuilder', () => {
dashboardLayout,
deleteTopLevelTabs() {},
editMode: false,
showBuilderPane() {},
setColorSchemeAndUnsavedChanges() {},
colorScheme: undefined,
handleComponentDrop() {},
setDirectPathToChild: sinon.spy(),
};

3
superset-frontend/src/CRUD/Field.jsx
View File

@ -39,10 +39,9 @@ const propTypes = {
compact: PropTypes.bool,
};
const defaultProps = {
controlProps: {},
onChange: () => {},
compact: false,
desc: null,
description: null,
};
export default class Field extends React.PureComponent {

5
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton.jsx
View File

@ -37,10 +37,6 @@ const propTypes = {
templateParams: PropTypes.string,
};
const defaultProps = {
vizRequest: {},
};
class ExploreCtasResultsButton extends React.PureComponent {
constructor(props) {
super(props);
@ -113,7 +109,6 @@ class ExploreCtasResultsButton extends React.PureComponent {
}
}
ExploreCtasResultsButton.propTypes = propTypes;
ExploreCtasResultsButton.defaultProps = defaultProps;
function mapStateToProps({ sqlLab, common }) {
return {

2
superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
View File

@ -25,7 +25,7 @@ import TableSelector from '../../components/TableSelector';
const propTypes = {
queryEditor: PropTypes.object.isRequired,
height: PropTypes.number.isRequired,
height: PropTypes.number,
tables: PropTypes.array,
actions: PropTypes.object,
database: PropTypes.object,

2
superset-frontend/src/SqlLab/components/TemplateParamsEditor.jsx
View File

@ -33,8 +33,6 @@ const propTypes = {
};
const defaultProps = {
label: null,
description: null,
onChange: () => {},
code: '{}',
};

5
superset-frontend/src/components/Hotkeys.jsx
View File

@ -33,10 +33,6 @@ const propTypes = {
placement: PropTypes.string,
};
const defaultProps = {
hotkeys: [],
};
export default class Hotkeys extends React.PureComponent {
componentDidMount() {
this.props.hotkeys.forEach(keyConfig => {
@ -86,4 +82,3 @@ export default class Hotkeys extends React.PureComponent {
}
Hotkeys.propTypes = propTypes;
Hotkeys.defaultProps = defaultProps;

6
superset-frontend/src/components/Select/OnPasteSelect.jsx
View File

@ -81,12 +81,12 @@ export default class OnPasteSelect extends React.Component {
}
OnPasteSelect.propTypes = {
separator: PropTypes.array.isRequired,
separator: PropTypes.array,
selectWrap: PropTypes.elementType,
selectRef: PropTypes.func,
onChange: PropTypes.func.isRequired,
valueKey: PropTypes.string.isRequired,
labelKey: PropTypes.string.isRequired,
valueKey: PropTypes.string,
labelKey: PropTypes.string,
options: PropTypes.array,
isMulti: PropTypes.bool,
value: PropTypes.any,

4
superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
View File

@ -24,13 +24,13 @@ import { getCategoricalSchemeRegistry, t } from '@superset-ui/core';
import ColorSchemeControl from 'src/explore/components/controls/ColorSchemeControl';
const propTypes = {
onChange: PropTypes.func.isRequired,
onChange: PropTypes.func,
colorScheme: PropTypes.string,
};
const defaultProps = {
colorScheme: undefined,
onChange: () => {},
colorScheme: undefined,
};
class ColorSchemeControlWrapper extends React.PureComponent {

17
superset-frontend/src/dashboard/components/DashboardBuilder.jsx
View File

@ -54,9 +54,6 @@ const propTypes = {
dashboardLayout: PropTypes.object.isRequired,
deleteTopLevelTabs: PropTypes.func.isRequired,
editMode: PropTypes.bool.isRequired,
showBuilderPane: PropTypes.func.isRequired,
colorScheme: PropTypes.string,
setColorSchemeAndUnsavedChanges: PropTypes.func.isRequired,
handleComponentDrop: PropTypes.func.isRequired,
directPathToChild: PropTypes.arrayOf(PropTypes.string),
setDirectPathToChild: PropTypes.func.isRequired,
@ -64,9 +61,7 @@ const propTypes = {
};
const defaultProps = {
showBuilderPane: false,
directPathToChild: [],
colorScheme: undefined,
};
class DashboardBuilder extends React.Component {
@ -155,14 +150,7 @@ class DashboardBuilder extends React.Component {
}
render() {
const {
handleComponentDrop,
dashboardLayout,
editMode,
showBuilderPane,
setColorSchemeAndUnsavedChanges,
colorScheme,
} = this.props;
const { handleComponentDrop, dashboardLayout, editMode } = this.props;
const { tabIndex } = this.state;
const dashboardRoot = dashboardLayout[DASHBOARD_ROOT_ID];
const rootChildId = dashboardRoot.children[0];
@ -272,9 +260,6 @@ class DashboardBuilder extends React.Component {
{editMode && (
<BuilderComponentPane
topOffset={HEADER_HEIGHT + (topLevelTabs ? TABS_HEIGHT : 0)}
showBuilderPane={showBuilderPane}
setColorSchemeAndUnsavedChanges={setColorSchemeAndUnsavedChanges}
colorScheme={colorScheme}
/>
)}
</div>

2
superset-frontend/src/dashboard/components/PropertiesModal.jsx
View File

@ -35,7 +35,7 @@ import '../stylesheets/buttons.less';
const propTypes = {
dashboardId: PropTypes.number.isRequired,
show: PropTypes.bool.isRequired,
show: PropTypes.bool,
onHide: PropTypes.func,
colorScheme: PropTypes.object,
setColorSchemeAndUnsavedChanges: PropTypes.func,

2
superset-frontend/src/dashboard/components/SliceAdder.jsx
View File

@ -39,7 +39,7 @@ const propTypes = {
lastUpdated: PropTypes.number.isRequired,
errorMessage: PropTypes.string,
userId: PropTypes.string.isRequired,
selectedSliceIds: PropTypes.arrayOf(PropTypes.number).isRequired,
selectedSliceIds: PropTypes.arrayOf(PropTypes.number),
editMode: PropTypes.bool,
height: PropTypes.number,
};

1
superset-frontend/src/dashboard/components/SliceHeader.jsx
View File

@ -53,7 +53,6 @@ const propTypes = {
const defaultProps = {
innerRef: null,
forceRefresh: () => ({}),
removeSlice: () => ({}),
updateSliceName: () => ({}),
toggleExpandSlice: () => ({}),
exploreChart: () => ({}),

5
superset-frontend/src/dashboard/components/gridComponents/Row.jsx
View File

@ -56,10 +56,6 @@ const propTypes = {
updateComponents: PropTypes.func.isRequired,
};
const defaultProps = {
rowHeight: null,
};
class Row extends React.PureComponent {
constructor(props) {
super(props);
@ -192,6 +188,5 @@ class Row extends React.PureComponent {
}
Row.propTypes = propTypes;
Row.defaultProps = defaultProps;
export default Row;

1
superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx
View File

@ -69,7 +69,6 @@ const propTypes = {
};
const defaultProps = {
children: null,
renderTabContent: true,
renderHoverMenu: true,
availableColumnCount: 0,

1
superset-frontend/src/dashboard/components/menu/WithPopoverMenu.jsx
View File

@ -35,7 +35,6 @@ const defaultProps = {
children: null,
disableClick: false,
onChangeFocus: null,
onPressDelete() {},
menuItems: [],
isFocused: false,
shouldFocus: (event, container) =>

4
superset-frontend/src/dashboard/containers/DashboardBuilder.jsx
View File

@ -21,7 +21,6 @@ import { connect } from 'react-redux';
import DashboardBuilder from '../components/DashboardBuilder';
import {
setColorSchemeAndUnsavedChanges,
showBuilderPane,
setDirectPathToChild,
setMountedTab,
@ -35,9 +34,7 @@ function mapStateToProps({ dashboardLayout: undoableLayout, dashboardState }) {
return {
dashboardLayout: undoableLayout.present,
editMode: dashboardState.editMode,
showBuilderPane: dashboardState.showBuilderPane,
directPathToChild: dashboardState.directPathToChild,
colorScheme: dashboardState.colorScheme,
};
}
@ -47,7 +44,6 @@ function mapDispatchToProps(dispatch) {
deleteTopLevelTabs,
handleComponentDrop,
showBuilderPane,
setColorSchemeAndUnsavedChanges,
setDirectPathToChild,
setMountedTab,
},

1
superset-frontend/src/dashboard/containers/DashboardComponent.jsx
View File

@ -53,7 +53,6 @@ const propTypes = {
const defaultProps = {
directPathToChild: [],
directPathLastUpdated: 0,
isComponentVisible: true,
};
function mapStateToProps(

1
superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
View File

@ -37,7 +37,6 @@ const propTypes = {
const defaultProps = {
onStop: () => {},
onSave: () => {},
disabled: false,
};
// Prolly need to move this to a global context

4
superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx
View File

@ -35,8 +35,8 @@ const propTypes = {
choices: PropTypes.oneOfType([
PropTypes.arrayOf(PropTypes.array),
PropTypes.func,
]).isRequired,
schemes: PropTypes.oneOfType([PropTypes.object, PropTypes.func]).isRequired,
]),
schemes: PropTypes.oneOfType([PropTypes.object, PropTypes.func]),
isLinear: PropTypes.bool,
};

2
superset-frontend/src/explore/components/controls/ViewportControl.jsx
View File

@ -37,7 +37,7 @@ export const DEFAULT_VIEWPORT = {
const PARAMS = ['longitude', 'latitude', 'zoom', 'bearing', 'pitch'];
const propTypes = {
onChange: PropTypes.func.isRequired,
onChange: PropTypes.func,
value: PropTypes.shape({
longitude: PropTypes.number,
latitude: PropTypes.number,