From a1f8429b4eb7d8e42f7bb48149455baed72a55c4 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Sun, 18 Oct 2020 21:37:41 -0700 Subject: [PATCH] chore: make config ENABLE_REACT_CRUD_VIEWS = True by default (#11259) React CRUD views have been maturing for a while and are ready for prime time! --- UPDATING.md | 3 +++ superset/config.py | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/UPDATING.md b/UPDATING.md index f752884dc..3bfd9c0cc 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -23,6 +23,9 @@ assists people when migrating to a new version. ## Next +* NOTICE: config flag ENABLE_REACT_CRUD_VIEWS has been set to `True` by default, set to `False` if + you prefer to vintage look and feel :) + * [11244](https://github.com/apache/incubator-superset/pull/11244): The `REDUCE_DASHBOARD_BOOTSTRAP_PAYLOAD` feature flag has been removed after being set to True for multiple months. * [11098](https://github.com/apache/incubator-superset/pull/11098): includes a database migration that adds a `uuid` column to most models, and updates `Dashboard.position_json` to include chart UUIDs. Depending on number of objects, the migration may take up to 5 minutes, requiring planning for downtime. diff --git a/superset/config.py b/superset/config.py index f80ccd7d8..f64e2847e 100644 --- a/superset/config.py +++ b/superset/config.py @@ -843,7 +843,7 @@ DOCUMENTATION_ICON = None # Recommended size: 16x16 # Enables the replacement react views for all the FAB views (list, edit, show) with # designs introduced in SIP-34: https://github.com/apache/incubator-superset/issues/8976 # This is a work in progress so not all features available in FAB have been implemented -ENABLE_REACT_CRUD_VIEWS = False +ENABLE_REACT_CRUD_VIEWS = True # What is the Last N days relative in the time selector to: # 'today' means it is midnight (00:00:00) in the local timezone @@ -956,7 +956,7 @@ if CONFIG_PATH_ENV_VAR in os.environ: elif importlib.util.find_spec("superset_config") and not is_test(): try: import superset_config # pylint: disable=import-error - from superset_config import * # type: ignore # pylint: disable=import-error,wildcard-import,unused-wildcard-import + from superset_config import * # pylint: disable=import-error,wildcard-import,unused-wildcard-import print(f"Loaded your LOCAL configuration at [{superset_config.__file__}]") except Exception: