iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(gsheets): add column names on file upload (#24963)

This commit is contained in:
Beto Dealmeida 2023-08-11 12:51:21 -07:00 committed by GitHub
parent b54b4e5e9b
commit a3d72e0ec7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
superset/db_engine_specs/gsheets.py
View File

@ -410,10 +410,12 @@ class GSheetsEngineSpec(ShillelaghEngineSpec):
spreadsheet_url = payload["spreadsheetUrl"]
# insert data
data = df.fillna("").values.tolist()
data.insert(0, df.columns.values.tolist())
body = {
"range": range_,
"majorDimension": "ROWS",
"values": df.fillna("").values.tolist(),
"values": data,
}
url = (
"https://sheets.googleapis.com/v4/spreadsheets/"

6
tests/unit_tests/db_engine_specs/test_gsheets.py
View File

@ -333,7 +333,7 @@ def test_upload_new(mocker: MockFixture) -> None:
database = mocker.MagicMock()
database.get_extra.return_value = {}
df = pd.DataFrame([1, "foo", 3.0])
df = pd.DataFrame({"col": [1, "foo", 3.0]})
table = Table("sample_data")
GSheetsEngineSpec.df_to_sql(database, table, df, {})
@ -367,7 +367,7 @@ def test_upload_existing(mocker: MockFixture) -> None:
"engine_params": {"catalog": {"sample_data": "https://docs.example.org"}}
}
df = pd.DataFrame([1, "foo", 3.0])
df = pd.DataFrame({"col": [1, "foo", 3.0]})
table = Table("sample_data")
with pytest.raises(SupersetException) as excinfo:
@ -392,7 +392,7 @@ def test_upload_existing(mocker: MockFixture) -> None:
json={
"range": "sheet0",
"majorDimension": "ROWS",
"values": [[1], ["foo"], [3.0]],
"values": [["col"], [1], ["foo"], [3.0]],
},
params={"valueInputOption": "USER_ENTERED"},
),