Removing references to basestring

panoramix/forms.py

@@ -4,6 +4,7 @@ from wtforms import (
 from wtforms import validators
 from copy import copy
 from panoramix import app
+from six import string_types
 config = app.config
 
 
@@ -240,7 +241,7 @@ class FormFactory(object):
                 QueryForm, 'flt_eq_' + str(i),
                 TextField("Super", default=''))
         for ff in viz.form_fields:
-            if isinstance(ff, basestring):
+            if isinstance(ff, string_types):
                 ff = [ff]
             for s in ff:
                 if s:

panoramix/models.py

@@ -22,6 +22,8 @@ import sqlparse
 import requests
 import textwrap
 
+from six import string_types
+
 from panoramix import app, db, get_session, utils
 from panoramix.viz import viz_types
 from sqlalchemy.ext.declarative import declared_attr
@@ -766,7 +768,7 @@ class Datasource(Model, AuditMixinNullable, Queryable):
         if granularity != "all":
             granularity = utils.parse_human_timedelta(
                 granularity).total_seconds() * 1000
-        if not isinstance(granularity, basestring):
+        if not isinstance(granularity, string_types):
             granularity = {"type": "duration", "duration": granularity}
 
         qry = dict(

panoramix/viz.py

@@ -14,6 +14,8 @@ import pandas as pd
 from panoramix import app, utils
 from panoramix.forms import FormFactory
 
+from six import string_types
+
 config = app.config
 
 
@@ -468,7 +470,7 @@ class NVD3TimeSeriesViz(NVD3Viz):
             if df[name].dtype.kind not in "biufc":
                 continue
             df['timestamp'] = pd.to_datetime(df.index, utc=False)
-            if isinstance(name, basestring):
+            if isinstance(name, string_types):
                 series_title = name
             else:
                 name = ["{}".format(s) for s in name]
@@ -622,7 +624,7 @@ class DistributionBarViz(DistributionPieViz):
             if df[name].dtype.kind not in "biufc":
                 continue
             df['timestamp'] = pd.to_datetime(df.index, utc=False)
-            if isinstance(name, basestring):
+            if isinstance(name, string_types):
                 series_title = name
             elif len(self.metrics) > 1:
                 series_title = ", ".join(name)

requirements.txt

@@ -1,5 +1,7 @@
 alembic>=0.7.7, <0.8.0
-flask>=0.10.1, <1.0.0
+coverage
+coveralls
+flask==0.10.1
 flask-appbuilder>=1.4.5, <2.0.0
 flask-login==0.2.11
 flask-migrate>=1.5.1, <2.0.0
@@ -7,10 +9,14 @@ flask-script>=2.0.5, <3.0.0
 flask-testing>=0.4.2, <0.5.0
 gunicorn>=19.3.0, <20.0.0
 markdown>=2.6.2, <3.0.0
-numpy>=1.10, <2
-pandas==0.16.2, <0.17
+nose
+numpy>=1.9
+pandas==0.16.2
 parsedatetime>=1.5, <2.0.0
 pydruid>=0.2.2, <0.3
 python-dateutil>=2.4.2, <3.0.0
 requests>=2.7.0, <3.0.0
 sqlparse>=0.1.16, <0.2.0
+pyhive
+pymysql
+six

setup.py

@@ -26,7 +26,7 @@ setup(
         'flask-testing>=0.4.2, <0.5.0',
         'gunicorn>=19.3.0, <20.0.0',
         'markdown>=2.6.2, <3.0.0',
-        'numpy>=1.10, <2',
+        'numpy>=1.9, <2',
         'pandas==0.16.2, <0.17',
         'parsedatetime>=1.5, <2.0.0',
         'pydruid>=0.2.2, <0.3',