chore(ci): consolidate Node version reference in CI to associated `.nvmrc` (#32192)

Signed-off-by: hainenber <dotronghai96@gmail.com>
This commit is contained in:
Đỗ Trọng Hải 2025-02-11 02:52:36 +07:00 committed by GitHub
parent 1c3ec21e0f
commit a78968c68e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
11 changed files with 14 additions and 23 deletions

View File

@ -31,7 +31,7 @@ jobs:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- uses: actions/setup-node@v4 - uses: actions/setup-node@v4
with: with:
node-version: "20" node-version-file: './superset-embedded-sdk/.nvmrc'
registry-url: 'https://registry.npmjs.org' registry-url: 'https://registry.npmjs.org'
- run: npm ci - run: npm ci
- run: npm run ci:release - run: npm run ci:release

View File

@ -21,7 +21,7 @@ jobs:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- uses: actions/setup-node@v4 - uses: actions/setup-node@v4
with: with:
node-version: "20" node-version-file: './superset-embedded-sdk/.nvmrc'
registry-url: 'https://registry.npmjs.org' registry-url: 'https://registry.npmjs.org'
- run: npm ci - run: npm ci
- run: npm test - run: npm test

View File

@ -24,13 +24,7 @@ jobs:
needs: config needs: config
if: needs.config.outputs.has-secrets if: needs.config.outputs.has-secrets
name: Bump version and publish package(s) name: Bump version and publish package(s)
runs-on: ubuntu-24.04 runs-on: ubuntu-24.04
strategy:
matrix:
node-version: [20]
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
with: with:
@ -46,11 +40,11 @@ jobs:
git fetch --prune --unshallow git fetch --prune --unshallow
git tag -d `git tag | grep -E '^trigger-'` git tag -d `git tag | grep -E '^trigger-'`
- name: Use Node.js ${{ matrix.node-version }} - name: Install Node.js
if: env.HAS_TAGS if: env.HAS_TAGS
uses: actions/setup-node@v4 uses: actions/setup-node@v4
with: with:
node-version: ${{ matrix.node-version }} node-version-file: './superset-frontend/.nvmrc'
- name: Cache npm - name: Cache npm
if: env.HAS_TAGS if: env.HAS_TAGS

View File

@ -26,7 +26,6 @@ jobs:
fail-fast: false fail-fast: false
matrix: matrix:
browser: ["chrome"] browser: ["chrome"]
node: [20]
env: env:
SUPERSET_ENV: development SUPERSET_ENV: development
SUPERSET_CONFIG: tests.integration_tests.superset_test_config SUPERSET_CONFIG: tests.integration_tests.superset_test_config
@ -66,7 +65,7 @@ jobs:
- name: Setup Node.js - name: Setup Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v4
with: with:
node-version: ${{ matrix.node }} node-version-file: './superset-frontend/.nvmrc'
- name: Install npm dependencies - name: Install npm dependencies
uses: ./.github/actions/cached-dependencies uses: ./.github/actions/cached-dependencies
with: with:

View File

@ -28,9 +28,6 @@ jobs:
needs: config needs: config
if: needs.config.outputs.has-secrets if: needs.config.outputs.has-secrets
runs-on: ubuntu-24.04 runs-on: ubuntu-24.04
strategy:
matrix:
node: [20]
steps: steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )" - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v4 uses: actions/checkout@v4
@ -41,7 +38,7 @@ jobs:
- name: Set up Node.js - name: Set up Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v4
with: with:
node-version: ${{ matrix.node }} node-version-file: './superset-frontend/.nvmrc'
- name: Install eyes-storybook dependencies - name: Install eyes-storybook dependencies
uses: ./.github/actions/cached-dependencies uses: ./.github/actions/cached-dependencies
with: with:

View File

@ -35,10 +35,10 @@ jobs:
with: with:
persist-credentials: false persist-credentials: false
submodules: recursive submodules: recursive
- name: Set up Node.js 20 - name: Set up Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v4
with: with:
node-version: '20' node-version-file: './docs/.nvmrc'
- name: Setup Python - name: Setup Python
uses: ./.github/actions/setup-backend/ uses: ./.github/actions/setup-backend/
- uses: actions/setup-java@v4 - uses: actions/setup-java@v4

View File

@ -60,10 +60,10 @@ jobs:
with: with:
persist-credentials: false persist-credentials: false
submodules: recursive submodules: recursive
- name: Set up Node.js 20 - name: Set up Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v4
with: with:
node-version: '20' node-version-file: './docs/.nvmrc'
- name: yarn install - name: yarn install
run: | run: |
yarn install --check-cache yarn install --check-cache

View File

@ -109,7 +109,7 @@ jobs:
if: steps.check.outputs.python || steps.check.outputs.frontend if: steps.check.outputs.python || steps.check.outputs.frontend
uses: actions/setup-node@v4 uses: actions/setup-node@v4
with: with:
node-version: "20" node-version-file: './superset-frontend/.nvmrc'
- name: Install npm dependencies - name: Install npm dependencies
if: steps.check.outputs.python || steps.check.outputs.frontend if: steps.check.outputs.python || steps.check.outputs.frontend
uses: ./.github/actions/cached-dependencies uses: ./.github/actions/cached-dependencies

View File

@ -33,7 +33,7 @@ jobs:
if: steps.check.outputs.frontend if: steps.check.outputs.frontend
uses: actions/setup-node@v4 uses: actions/setup-node@v4
with: with:
node-version: '18' node-version-file: './superset-frontend/.nvmrc'
- name: Install dependencies - name: Install dependencies
if: steps.check.outputs.frontend if: steps.check.outputs.frontend
uses: ./.github/actions/cached-dependencies uses: ./.github/actions/cached-dependencies

View File

@ -32,7 +32,7 @@ jobs:
- name: Set up Node.js - name: Set up Node.js
uses: actions/setup-node@v4 uses: actions/setup-node@v4
with: with:
node-version: '20' node-version-file: './superset-frontend/.nvmrc'
- name: Install Dependencies - name: Install Dependencies
run: npm install run: npm install

View File

@ -0,0 +1 @@
v20.16.0