iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(tags): move tags from navbar to settings (#24518) 

Co-authored-by: Daniel Vaz Gaspar <danielvazgaspar@gmail.com>
This commit is contained in:
Hugh A. Miles II 2023-06-28 02:53:49 -04:00 committed by GitHub
parent 750113441c
commit a846e8a58d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
superset/charts/commands/warm_up_cache.py
View File

@ -30,7 +30,6 @@ from superset.views.utils import get_dashboard_extra_filters, get_form_data, get
class ChartWarmUpCacheCommand(BaseCommand): class ChartWarmUpCacheCommand(BaseCommand):
# pylint: disable=too-many-arguments
def __init__( def __init__(
self, self,
chart_or_id: Union[int, Slice], chart_or_id: Union[int, Slice],

4
superset/databases/api.py
View File

@ -383,9 +383,7 @@ class DatabaseRestApi(BaseSupersetModelRestApi):
# Return SSH Tunnel and hide passwords if any # Return SSH Tunnel and hide passwords if any
if item.get("ssh_tunnel"): if item.get("ssh_tunnel"):
item["ssh_tunnel"] = mask_password_info( item["ssh_tunnel"] = mask_password_info(new_model.ssh_tunnel)
new_model.ssh_tunnel # pylint: disable=no-member
)
return self.response(201, id=new_model.id, result=item) return self.response(201, id=new_model.id, result=item)
except DatabaseInvalidError as ex: except DatabaseInvalidError as ex:

1
superset/datasets/commands/warm_up_cache.py
View File

@ -28,7 +28,6 @@ from superset.models.slice import Slice
class DatasetWarmUpCacheCommand(BaseCommand): class DatasetWarmUpCacheCommand(BaseCommand):
# pylint: disable=too-many-arguments
def __init__( def __init__(
self, self,
db_name: str, db_name: str,

11
superset/initialization/__init__.py
View File

@ -156,7 +156,7 @@ class SupersetAppInitializer: # pylint: disable=too-many-public-methods
from superset.sqllab.api import SqlLabRestApi from superset.sqllab.api import SqlLabRestApi
from superset.tags.api import TagRestApi from superset.tags.api import TagRestApi
from superset.views.alerts import AlertView, ReportView from superset.views.alerts import AlertView, ReportView
from superset.views.all_entities import TaggedObjectsModelView, TaggedObjectView from superset.views.all_entities import TaggedObjectView
from superset.views.annotations import AnnotationLayerView from superset.views.annotations import AnnotationLayerView
from superset.views.api import Api from superset.views.api import Api
from superset.views.chart.views import SliceAsync, SliceModelView from superset.views.chart.views import SliceAsync, SliceModelView
@ -366,20 +366,13 @@ class SupersetAppInitializer: # pylint: disable=too-many-public-methods
category="SQL Lab", category="SQL Lab",
category_label=__("SQL Lab"), category_label=__("SQL Lab"),
) )
appbuilder.add_view(
TaggedObjectsModelView,
"All Entities",
label=__("All Entities"),
icon="",
category_icon="",
menu_cond=lambda: feature_flag_manager.is_feature_enabled("TAGGING_SYSTEM"),
)
appbuilder.add_view( appbuilder.add_view(
TagModelView, TagModelView,
"Tags", "Tags",
label=__("Tags"), label=__("Tags"),
icon="", icon="",
category_icon="", category_icon="",
category="Manage",
menu_cond=lambda: feature_flag_manager.is_feature_enabled("TAGGING_SYSTEM"), menu_cond=lambda: feature_flag_manager.is_feature_enabled("TAGGING_SYSTEM"),
) )
appbuilder.add_api(LogRestApi) appbuilder.add_api(LogRestApi)