From ac0dd3fa32a2076f00f0fe6d4f276db27aaa2f46 Mon Sep 17 00:00:00 2001
From: auxten <auxten@users.noreply.github.com>
Date: Wed, 25 Nov 2020 19:05:30 +0800
Subject: [PATCH] fix: attachment filename error in sqllab with i18n (#11762)

* Fix attachment filename error in sqllab

* Fix line too long lint

* Fix black lint
---
 superset/views/core.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index e5730e5f9..a898faf9c 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2474,9 +2474,11 @@ class Superset(BaseSupersetView):  # pylint: disable=too-many-public-methods
             # TODO(bkyryliuk): add compression=gzip for big files.
             csv = df.to_csv(index=False, **config["CSV_EXPORT"])
         response = Response(csv, mimetype="text/csv")
-        response.headers[
-            "Content-Disposition"
-        ] = f"attachment; filename={query.name}.csv"
+        quoted_csv_name = parse.quote(query.name)
+        response.headers["Content-Disposition"] = (
+            f'attachment; filename="{quoted_csv_name}.csv"; '
+            f"filename*=UTF-8''{quoted_csv_name}.csv"
+        )
         event_info = {
             "event_type": "data_export",
             "client_id": client_id,