iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: questioning a few lines that force an ORDER clause (#11153) 

* draft: questioning a few lines that force an ORDER clause

* sorting by main metric DESC by default
This commit is contained in:
Maxime Beauchemin 2020-10-12 14:53:37 -07:00 committed by GitHub
parent dcdf15f4d7
commit ae87b0c767
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/src/views/CRUD/data/database/DatabaseList.tsx
View File

@ -180,7 +180,7 @@ function DatabaseList({ addDangerToast, addSuccessToast }: DatabaseListProps) {
Header: (
<TooltipWrapper
label="allow-dml-header"
tooltip={t('Allow Data Danipulation Language')}
tooltip={t('Allow Data Manipulation Language')}
placement="top"
>
<span>{t('DML')}</span>

3
superset/connectors/sqla/models.py
View File

@ -1082,9 +1082,6 @@ class SqlaTable( # pylint: disable=too-many-public-methods,too-many-instance-at
qry = qry.where(and_(*where_clause_and))
qry = qry.having(and_(*having_clause_and))
if not orderby and ((is_sip_38 and metrics) or (not is_sip_38 and not columns)):
orderby = [(main_metric_expr, not order_desc)]
# To ensure correct handling of the ORDER BY labeling we need to reference the
# metric instance if defined in the SELECT clause.
metrics_exprs_by_label = {

4
superset/viz.py
View File

@ -724,6 +724,10 @@ class TableViz(BaseViz):
if sort_by_label not in d["metrics"]:
d["metrics"].append(sort_by)
d["orderby"] = [(sort_by, not fd.get("order_desc", True))]
elif d["metrics"]:
# Legacy behavior of sorting by first metric by default
first_metric = d["metrics"][0]
d["orderby"] = [(first_metric, not fd.get("order_desc", True))]
return d
def get_data(self, df: pd.DataFrame) -> VizData: