From aef325a41687804b3e9ee6731e99821062604c43 Mon Sep 17 00:00:00 2001 From: Jack <41238731+fisjac@users.noreply.github.com> Date: Thu, 11 Apr 2024 12:50:06 -0500 Subject: [PATCH] feat(alert report tabs): adding feature flag (#27773) --- RESOURCES/FEATURE_FLAGS.md | 1 + .../packages/superset-ui-core/src/utils/featureFlags.ts | 1 + superset/config.py | 1 + 3 files changed, 3 insertions(+) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index 119988653..daeda89f1 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -27,6 +27,7 @@ These features are considered **unfinished** and should only be used on developm [//]: # "PLEASE KEEP THE LIST SORTED ALPHABETICALLY" +- ALERT_REPORT_TABS - ENABLE_ADVANCED_DATA_TYPES - PRESTO_EXPAND_DATA - SHARE_QUERIES_VIA_KV_STORE diff --git a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts index d12edc516..b3af431d5 100644 --- a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts +++ b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts @@ -24,6 +24,7 @@ export enum FeatureFlag { // PLEASE KEEP THE LIST SORTED ALPHABETICALLY AlertsAttachReports = 'ALERTS_ATTACH_REPORTS', AlertReports = 'ALERT_REPORTS', + AlertReportTabs = 'ALERT_REPORT_TABS', AllowFullCsvExport = 'ALLOW_FULL_CSV_EXPORT', AvoidColorsCollision = 'AVOID_COLORS_COLLISION', ChartPluginsExperimental = 'CHART_PLUGINS_EXPERIMENTAL', diff --git a/superset/config.py b/superset/config.py index 1b06f96db..4b9969bbf 100644 --- a/superset/config.py +++ b/superset/config.py @@ -435,6 +435,7 @@ DEFAULT_FEATURE_FLAGS: dict[str, bool] = { "EMBEDDED_SUPERSET": False, # Enables Alerts and reports new implementation "ALERT_REPORTS": False, + "ALERT_REPORT_TABS": False, "DASHBOARD_RBAC": False, "ENABLE_ADVANCED_DATA_TYPES": False, # Enabling ALERTS_ATTACH_REPORTS, the system sends email and slack message