From b0d25a154aff161029ef47105540c19c6b23cbb7 Mon Sep 17 00:00:00 2001 From: Riccardo Magliocchetti Date: Mon, 18 Sep 2017 18:44:19 +0200 Subject: [PATCH] Miscvizcleanups (#3476) * viz: remove unused countries import * viz: simplify code in BaseViz.query_obj --- superset/viz.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/superset/viz.py b/superset/viz.py index 7226d2e86..08c852dca 100644 --- a/superset/viz.py +++ b/superset/viz.py @@ -167,13 +167,11 @@ class BaseViz(object): extras = { 'where': form_data.get("where", ''), 'having': form_data.get("having", ''), - 'having_druid': form_data.get('having_filters') \ - if 'having_filters' in form_data else [], + 'having_druid': form_data.get('having_filters', []), 'time_grain_sqla': form_data.get("time_grain_sqla", ''), 'druid_time_origin': form_data.get("druid_time_origin", ''), } - filters = form_data['filters'] if 'filters' in form_data \ - else [] + filters = form_data.get('filters', []) for col, vals in self.get_extra_filters().items(): if not (col and vals) or col.startswith('__'): continue @@ -1315,7 +1313,6 @@ class CountryMapViz(BaseViz): return qry def get_data(self, df): - from superset.data import countries fd = self.form_data cols = [fd.get('entity')] metric = fd.get('metric')