chore(🦾): bump python pre-commit 3.7.1 -> 4.0.1 (#31050)

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>

.pre-commit-config.yaml

@@ -16,11 +16,11 @@
 #
 repos:
   - repo: https://github.com/MarcoGorelli/auto-walrus
-    rev: v0.2.2
+    rev: 0.3.4
     hooks:
       - id: auto-walrus
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.3.0
+    rev: v1.13.0
     hooks:
       - id: mypy
         args: [--check-untyped-defs]
@@ -39,11 +39,11 @@ repos:
             types-Markdown,
           ]
   - repo: https://github.com/peterdemin/pip-compile-multi
-    rev: v2.6.2
+    rev: v2.6.4
     hooks:
       - id: pip-compile-multi-verify
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v5.0.0
     hooks:
       - id: check-docstring-first
       - id: check-added-large-files
@@ -56,7 +56,7 @@ repos:
         exclude: ^.*\.(snap)
         args: ["--markdown-linebreak-ext=md"]
   - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: v3.1.0 # Use the sha or tag you want to point at
+    rev: v4.0.0-alpha.8 # Use the sha or tag you want to point at
     hooks:
       - id: prettier
         additional_dependencies:
@@ -70,7 +70,7 @@ repos:
       - id: blacklist
         args: ["--blacklisted-names=make_url", "--ignore=tests/"]
   - repo: https://github.com/norwoodj/helm-docs
-    rev: v1.11.0
+    rev: v1.14.2
     hooks:
       - id: helm-docs
         files: helm

requirements/development.txt

@@ -141,7 +141,7 @@ pluggy==1.4.0
     # via
     #   pytest
     #   tox
-pre-commit==3.7.1
+pre-commit==4.0.1
     # via apache-superset
 progress==1.6
     # via apache-superset

superset/connectors/sqla/models.py

@@ -921,7 +921,7 @@ class TableColumn(AuditMixinNullable, ImportExportMixin, CertificationMixin, Mod
 
     @property
     def database(self) -> Database:
-        return self.table.database if self.table else self._database
+        return self.table.database if self.table else self._database  # type: ignore
 
     @property
     def db_engine_spec(self) -> builtins.type[BaseEngineSpec]:

superset/extensions/__init__.py

@@ -85,7 +85,7 @@ class UIManifestProcessor:
         return {
             "js_manifest": lambda bundle: get_files(bundle, "js"),
             "css_manifest": lambda bundle: get_files(bundle, "css"),
-            "assets_prefix": (
+            "assets_prefix": (  # type: ignore
                 self.app.config["STATIC_ASSETS_PREFIX"] if self.app else ""
             ),
         }

superset/jinja_context.py

@@ -352,8 +352,7 @@ class ExtraCache:
 
         for flt in form_data.get("adhoc_filters", []):
             val: Union[Any, list[Any]] = flt.get("comparator")
-            op: str = flt["operator"].upper() if flt.get("operator") else None
-            # fltOpName: str = flt.get("filterOptionName")
+            op: str = flt["operator"].upper() if flt.get("operator") else None  # type: ignore
             if (
                 flt.get("expressionType") == "SIMPLE"
                 and flt.get("clause") == "WHERE"

superset/models/core.py

@@ -1055,7 +1055,7 @@ class Database(Model, AuditMixinNullable, ImportExportMixin):  # pylint: disable
         )
 
     def get_perm(self) -> str:
-        return self.perm  # type: ignore
+        return self.perm
 
     def has_table(self, table: Table) -> bool:
         with self.get_sqla_engine(catalog=table.catalog, schema=table.schema) as engine:

superset/security/manager.py

@@ -477,7 +477,7 @@ class SupersetSecurityManager(  # pylint: disable=too-many-public-methods
         return (
             self.can_access_all_datasources()
             or self.can_access_all_databases()
-            or self.can_access("database_access", database.perm)  # type: ignore
+            or self.can_access("database_access", database.perm)
         )
 
     def can_access_catalog(self, database: "Database", catalog: str) -> bool:

superset/tasks/async_queries.py

@@ -174,7 +174,7 @@ def load_explore_json_into_cache(  # pylint: disable=too-many-locals
                 errors = ex.errors
             else:
                 error = ex.message if hasattr(ex, "message") else str(ex)
-                errors = [error]
+                errors = [error]  # type: ignore
 
             async_query_manager.update_job(
                 job_metadata, async_query_manager.STATUS_ERROR, errors=errors

superset/utils/core.py

@@ -919,14 +919,13 @@ def merge_extra_form_data(form_data: dict[str, Any]) -> None:
         "adhoc_filters", []
     )
     adhoc_filters.extend(
-        {"isExtra": True, **adhoc_filter}  # type: ignore
-        for adhoc_filter in append_adhoc_filters
+        {"isExtra": True, **adhoc_filter} for adhoc_filter in append_adhoc_filters
     )
     if append_filters:
         for key, value in form_data.items():
             if re.match("adhoc_filter.*", key):
                 value.extend(
-                    simple_filter_to_adhoc({"isExtra": True, **fltr})  # type: ignore
+                    simple_filter_to_adhoc({"isExtra": True, **fltr})
                     for fltr in append_filters
                     if fltr
                 )

superset/viz.py

@@ -2458,7 +2458,7 @@ class RoseViz(NVD3TimeSeriesViz):
                 result[timestamp].append(
                     {
                         "key": key,
-                        "value": value,
+                        "value": value,  # type: ignore
                         "name": ", ".join(key) if isinstance(key, list) else key,
                         "time": val["x"],
                     }

tests/integration_tests/conftest.py

@@ -69,7 +69,7 @@ def login_as(test_client: FlaskClient[Any]):
 
 @pytest.fixture
 def login_as_admin(login_as: Callable[..., None]):
-    yield login_as("admin")
+    yield login_as("admin")  # type: ignore
 
 
 @pytest.fixture