iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ace-editor): use monospace fonts by default (#23747)

This commit is contained in:
Ville Brofeldt 2023-04-20 14:45:43 +03:00 committed by GitHub
parent f80e738196
commit b2b8c3e05b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx
View File

@ -65,9 +65,6 @@ const StyledAceEditor = styled(AceEditor)`
// double class is better than !important
border: 1px solid ${theme.colors.grayscale.light2};
font-feature-settings: 'liga' off, 'calt' off;
// Fira Code causes problem with Ace under Firefox
font-family: 'Menlo', 'Consolas', 'Courier New', 'Ubuntu Mono',
'source-code-pro', 'Lucida Console', monospace;
&.ace_autocomplete {
// Use !important because Ace Editor applies extra CSS at the last second

3
superset-frontend/src/components/AsyncAceEditor/index.tsx
View File

@ -84,6 +84,7 @@ export type AsyncAceEditorOptions = {
defaultMode?: AceEditorMode;
defaultTheme?: AceEditorTheme;
defaultTabSize?: number;
fontFamily?: string;
placeholder?: React.ComponentType<
PlaceholderProps & Partial<IAceEditorProps>
> | null;
@ -98,6 +99,7 @@ export default function AsyncAceEditor(
defaultMode,
defaultTheme,
defaultTabSize = 2,
fontFamily = 'Menlo, Consolas, Courier New, Ubuntu Mono, source-code-pro, Lucida Console, monospace',
placeholder,
}: AsyncAceEditorOptions = {},
) {
@ -153,6 +155,7 @@ export default function AsyncAceEditor(
theme={theme}
tabSize={tabSize}
defaultValue={defaultValue}
setOptions={{ fontFamily }}
{...props}
/>
);