iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(native-filters): show default text on filter scoping tree (#15351)

This commit is contained in:
Ville Brofeldt 2021-06-24 11:01:24 +03:00 committed by GitHub
parent f0b64190b5
commit b3cdff4995
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/spec/fixtures/mockDashboardLayout.js vendored
View File

@ -129,7 +129,7 @@ export const dashboardLayoutWithTabs = {
children: ['ROW_ID2'],
parents: ['ROOT_ID', 'TABS_ID'],
meta: {
text: 'tab2',
text: '',
defaultText: 'tab2',
},
},

1
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/utils.ts
View File

@ -50,6 +50,7 @@ export const buildTree = (
node.meta.sliceNameOverride ||
node.meta.sliceName ||
node.meta.text ||
node.meta.defaultText ||
node.id.toString(),
initiallyExcludedCharts.includes(node.meta?.chartId),
t(

2
superset-frontend/src/dashboard/types.ts
View File

@ -105,7 +105,9 @@ export type LayoutItem = {
id: string;
meta: {
chartId: number;
defaultText?: string;
height: number;
placeholder?: string;
sliceName?: string;
sliceNameOverride?: string;
text?: string;