[lint] turn no-undef back on, set browser, cypress, and mocha env's (#5879)

* [lint] turn no-undef back on, set browser, cypress, and mocha env's, and fix issues

* [lint] fix undefined var in TimeTable.jsx

superset/assets/.eslintrc

@@ -6,8 +6,8 @@
       "experimentalObjectRestSpread": true
     }
   },
-  "globals": {
-    "document": true,
+  "env": {
+    "browser": true
   },
   "rules": {
     "prefer-template": 0,
@@ -26,7 +26,6 @@
     "no-mixed-operators": 0,
     "no-continue": 0,
     "no-bitwise": 0,
-    "no-undef": 0,
     "no-multi-assign": 0,
     "react/no-array-index-key": 0,
     "no-restricted-properties": 0,

superset/assets/cypress/.eslintrc

@@ -0,0 +1,8 @@
+{
+  "plugins": [
+    "cypress"
+  ],
+  "env": {
+    "cypress/globals": true
+  }
+}

superset/assets/cypress/integration/dashboard/dashboard_tests.js

@@ -1,5 +1,5 @@
-describe('Load dashboard', function () {
-  it('Load birth names dashboard', function () {
+describe('Load dashboard', () => {
+  it('Load birth names dashboard', () => {
     cy.server();
     cy.login();
 

superset/assets/cypress/integration/explore/control_tests.js

@@ -2,8 +2,8 @@
 // Tests for setting controls in the UI
 // ***********************************************
 
-describe('Groupby', function () {
-  it('Set groupby', function () {
+describe('Groupby', () => {
+  it('Set groupby', () => {
     cy.server();
     cy.login();
 
@@ -21,8 +21,8 @@ describe('Groupby', function () {
   });
 });
 
-describe('SimpleAdhocMetric', function () {
-  it('Clear metric and set simple adhoc metric', function () {
+describe('SimpleAdhocMetric', () => {
+  it('Clear metric and set simple adhoc metric', () => {
     cy.server();
     cy.login();
 
@@ -36,7 +36,9 @@ describe('SimpleAdhocMetric', function () {
       cy.get('.select-clear').click();
       cy.get('.Select-control').click({ force: true });
       cy.get('input').type('sum_girls', { force: true });
-      cy.get('.VirtualizedSelectFocusedOption').trigger('mousedown').click();
+      cy.get('.VirtualizedSelectFocusedOption')
+        .trigger('mousedown')
+        .click();
     });
 
     cy.get('#metrics-edit-popover').within(() => {
@@ -44,7 +46,9 @@ describe('SimpleAdhocMetric', function () {
         cy.get('span').click();
         cy.get('input').type(metricName);
       });
-      cy.get('button').contains('Save').click();
+      cy.get('button')
+        .contains('Save')
+        .click();
     });
 
     cy.get('button.query').click();
@@ -56,4 +60,3 @@ describe('SimpleAdhocMetric', function () {
     });
   });
 });
-

superset/assets/cypress/integration/explore/visualizations/big_number.js

@@ -2,10 +2,10 @@ import { FORM_DATA_DEFAULTS, NUM_METRIC } from './shared.helper';
 
 // Big Number Total
 
-describe('Big Number Total', function () {
+describe('Big Number Total', () => {
   const BIG_NUMBER_DEFAULTS = { ...FORM_DATA_DEFAULTS, viz_type: 'big_number_total' };
 
-  it('Test big number chart with adhoc metric', function () {
+  it('Test big number chart with adhoc metric', () => {
     cy.server();
     cy.login();
 
@@ -16,20 +16,22 @@ describe('Big Number Total', function () {
     cy.verifySliceSuccess({ waitAlias: '@getJson', querySubstring: NUM_METRIC.label });
   });
 
-  it('Test big number chart with simple filter', function () {
+  it('Test big number chart with simple filter', () => {
     cy.server();
     cy.login();
 
-    const filters = [{
-      expressionType: 'SIMPLE',
-      subject: 'name',
-      operator: 'in',
-      comparator: ['Aaron', 'Amy', 'Andrea'],
-      clause: 'WHERE',
-      sqlExpression: null,
-      fromFormData: true,
-      filterOptionName: 'filter_4y6teao56zs_ebjsvwy48c',
-    }];
+    const filters = [
+      {
+        expressionType: 'SIMPLE',
+        subject: 'name',
+        operator: 'in',
+        comparator: ['Aaron', 'Amy', 'Andrea'],
+        clause: 'WHERE',
+        sqlExpression: null,
+        fromFormData: true,
+        filterOptionName: 'filter_4y6teao56zs_ebjsvwy48c',
+      },
+    ];
 
     const formData = { ...BIG_NUMBER_DEFAULTS, metric: 'count', adhoc_filters: filters };
 
@@ -38,7 +40,7 @@ describe('Big Number Total', function () {
     cy.verifySliceSuccess({ waitAlias: '@getJson' });
   });
 
-  it('Test big number chart ignores groupby', function () {
+  it('Test big number chart ignores groupby', () => {
     cy.server();
     cy.login();
 

superset/assets/cypress/integration/explore/visualizations/line.js

@@ -1,9 +1,9 @@
 import { FORM_DATA_DEFAULTS, NUM_METRIC } from './shared.helper';
 
-describe('Line', function () {
+describe('Line', () => {
   const LINE_CHART_DEFAULTS = { ...FORM_DATA_DEFAULTS, viz_type: 'line' };
 
-  it('Test line chart with adhoc metric', function () {
+  it('Test line chart with adhoc metric', () => {
     cy.server();
     cy.login();
 
@@ -14,7 +14,7 @@ describe('Line', function () {
     cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
   });
 
-  it('Test line chart with groupby', function () {
+  it('Test line chart with groupby', () => {
     cy.server();
     cy.login();
 
@@ -28,21 +28,23 @@ describe('Line', function () {
     cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
   });
 
-  it('Test line chart with simple filter', function () {
+  it('Test line chart with simple filter', () => {
     cy.server();
     cy.login();
 
     const metrics = ['count'];
-    const filters = [{
-      expressionType: 'SIMPLE',
-      subject: 'name',
-      operator: 'in',
-      comparator: ['Aaron', 'Amy', 'Andrea'],
-      clause: 'WHERE',
-      sqlExpression: null,
-      fromFormData: true,
-      filterOptionName: 'filter_4y6teao56zs_ebjsvwy48c',
-    }];
+    const filters = [
+      {
+        expressionType: 'SIMPLE',
+        subject: 'name',
+        operator: 'in',
+        comparator: ['Aaron', 'Amy', 'Andrea'],
+        clause: 'WHERE',
+        sqlExpression: null,
+        fromFormData: true,
+        filterOptionName: 'filter_4y6teao56zs_ebjsvwy48c',
+      },
+    ];
 
     const formData = { ...LINE_CHART_DEFAULTS, metrics, adhoc_filters: filters };
 
@@ -51,7 +53,7 @@ describe('Line', function () {
     cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
   });
 
-  it('Test line chart with series limit sort asc', function () {
+  it('Test line chart with series limit sort asc', () => {
     cy.server();
     cy.login();
 
@@ -68,7 +70,7 @@ describe('Line', function () {
     cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
   });
 
-  it('Test line chart with series limit sort desc', function () {
+  it('Test line chart with series limit sort desc', () => {
     cy.server();
     cy.login();
 
@@ -86,7 +88,7 @@ describe('Line', function () {
     cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
   });
 
-  it('Test line chart with rolling avg', function () {
+  it('Test line chart with rolling avg', () => {
     cy.server();
     cy.login();
 
@@ -99,39 +101,54 @@ describe('Line', function () {
     cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
   });
 
-  it('Test line chart with time shift 1 year', function () {
+  it('Test line chart with time shift 1 year', () => {
     cy.server();
     cy.login();
 
     const metrics = [NUM_METRIC];
 
-    const formData = { ...LINE_CHART_DEFAULTS, metrics, time_compare: ['1+year'], comparison_type: 'values' };
+    const formData = {
+      ...LINE_CHART_DEFAULTS,
+      metrics,
+      time_compare: ['1+year'],
+      comparison_type: 'values',
+    };
 
     cy.route('POST', '/superset/explore_json/**').as('getJson');
     cy.visitChartByParams(JSON.stringify(formData));
     cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
   });
 
-  it('Test line chart with time shift yoy', function () {
+  it('Test line chart with time shift yoy', () => {
     cy.server();
     cy.login();
 
     const metrics = [NUM_METRIC];
 
-    const formData = { ...LINE_CHART_DEFAULTS, metrics, time_compare: ['1+year'], comparison_type: 'ratio' };
+    const formData = {
+      ...LINE_CHART_DEFAULTS,
+      metrics,
+      time_compare: ['1+year'],
+      comparison_type: 'ratio',
+    };
 
     cy.route('POST', '/superset/explore_json/**').as('getJson');
     cy.visitChartByParams(JSON.stringify(formData));
     cy.verifySliceSuccess({ waitAlias: '@getJson', chartSelector: 'svg' });
   });
 
-  it('Test line chart with time shift percentage change', function () {
+  it('Test line chart with time shift percentage change', () => {
     cy.server();
     cy.login();
 
     const metrics = [NUM_METRIC];
 
-    const formData = { ...LINE_CHART_DEFAULTS, metrics, time_compare: ['1+year'], comparison_type: 'percentage' };
+    const formData = {
+      ...LINE_CHART_DEFAULTS,
+      metrics,
+      time_compare: ['1+year'],
+      comparison_type: 'percentage',
+    };
 
     cy.route('POST', '/superset/explore_json/**').as('getJson');
     cy.visitChartByParams(JSON.stringify(formData));

superset/assets/package.json

@@ -150,6 +150,7 @@
     "eslint": "^4.19.0",
     "eslint-config-airbnb": "^15.0.1",
     "eslint-config-prettier": "^2.9.0",
+    "eslint-plugin-cypress": "^2.0.1",
     "eslint-plugin-import": "^2.2.0",
     "eslint-plugin-jsx-a11y": "^5.1.1",
     "eslint-plugin-prettier": "^2.6.0",

superset/assets/spec/.eslintrc

@@ -1,4 +1,7 @@
 {
+  "env": {
+    "mocha": true
+  },
   "rules": {
     "import/no-extraneous-dependencies": ["error", {"devDependencies": true}]
   }

superset/assets/spec/helpers/shim.js

@@ -1,4 +1,4 @@
-/* eslint no-undef: 0, no-native-reassign: 0 */
+/* eslint no-native-reassign: 0 */
 import 'babel-polyfill';
 import chai from 'chai';
 import jsdom from 'jsdom';
@@ -55,4 +55,3 @@ global.window.XMLHttpRequest = global.XMLHttpRequest;
 global.window.location = { href: 'about:blank' };
 global.window.performance = { now: () => new Date().getTime() };
 global.$ = require('jquery')(global.window);
-

superset/assets/spec/javascripts/CRUD/CollectionTable_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it, beforeEach } from 'mocha';
 import { shallow } from 'enzyme';
 
 import CollectionTable from '../../../src/CRUD/CollectionTable';

superset/assets/spec/javascripts/addSlice/AddSliceContainer_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it, beforeEach } from 'mocha';
 import { shallow } from 'enzyme';
 import { Button } from 'react-bootstrap';
 import Select from 'react-virtualized-select';

superset/assets/spec/javascripts/chart/Chart_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/components/AlteredSliceTag_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import { Table, Thead, Td, Th, Tr } from 'reactable';

superset/assets/spec/javascripts/components/AsyncSelect_spec.jsx

@@ -1,7 +1,6 @@
 import React from 'react';
 import Select from 'react-select';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/components/CachedLabel_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 import { Label } from 'react-bootstrap';
 

superset/assets/spec/javascripts/components/Checkbox_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import sinon from 'sinon';
 import { shallow } from 'enzyme';
 

superset/assets/spec/javascripts/components/ColumnOption_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 
 import ColumnOption from '../../../src/components/ColumnOption';

superset/assets/spec/javascripts/components/ColumnTypeLabel_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 
 import ColumnTypeLabel from '../../../src/components/ColumnTypeLabel';

superset/assets/spec/javascripts/components/CopyToClipboard_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 
 import CopyToClipboard from '../../../src/components/CopyToClipboard';
 

superset/assets/spec/javascripts/components/FilterableTable/FilterableTable_spec.jsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import { mount } from 'enzyme';
 import FilterableTable from '../../../../src/components/FilterableTable/FilterableTable';

superset/assets/spec/javascripts/components/MetricOption_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 
 import MetricOption from '../../../src/components/MetricOption';

superset/assets/spec/javascripts/components/ModalTrigger_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 
 import ModalTrigger from '../../../src/components/ModalTrigger';
 

superset/assets/spec/javascripts/components/OnPasteSelect_spec.jsx

@@ -3,7 +3,6 @@ import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import VirtualizedSelect from 'react-virtualized-select';
 import Select, { Creatable } from 'react-select';
 

superset/assets/spec/javascripts/components/OptionDescription_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import InfoTooltipWithTrigger from '../../../src/components/InfoTooltipWithTrigger';

superset/assets/spec/javascripts/components/PopoverSection_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 
 import PopoverSection from '../../../src/components/PopoverSection';

superset/assets/spec/javascripts/components/URLShortLinkButton_spec.jsx

@@ -1,7 +1,6 @@
 import React from 'react';
 import configureStore from 'redux-mock-store';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 
 import { OverlayTrigger } from 'react-bootstrap';

superset/assets/spec/javascripts/components/URLShortLinkModal_spec.jsx

@@ -1,7 +1,6 @@
 import React from 'react';
 import configureStore from 'redux-mock-store';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 
 import URLShortLinkModal from '../../../src/components/URLShortLinkModal';

superset/assets/spec/javascripts/components/VirtualizedRendererWrap_spec.jsx

@@ -3,7 +3,6 @@ import React from 'react';
 import sinon from 'sinon';
 import PropTypes from 'prop-types';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 
 import VirtualizedRendererWrap from '../../../src/components/VirtualizedRendererWrap';

superset/assets/spec/javascripts/dashboard/.eslintrc

@@ -17,7 +17,6 @@
     "no-mixed-operators": 0,
     "no-continue": 2,
     "no-bitwise": 2,
-    "no-undef": 2,
     "no-multi-assign": 2,
     "no-restricted-properties": 2,
     "no-prototype-builtins": 2,

superset/assets/spec/javascripts/dashboard/actions/dashboardLayout_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/CodeModal_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import CodeModal from '../../../../src/dashboard/components/CodeModal';

superset/assets/spec/javascripts/dashboard/components/CssEditor_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import CssEditor from '../../../../src/dashboard/components/CssEditor';

superset/assets/spec/javascripts/dashboard/components/DashboardBuilder_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { shallow, mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import ParentSize from '@vx/responsive/build/components/ParentSize';

superset/assets/spec/javascripts/dashboard/components/DashboardGrid_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/Dashboard_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/HeaderActionsDropdown_spec.jsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import { shallow } from 'enzyme';
 import { DropdownButton, MenuItem } from 'react-bootstrap';

superset/assets/spec/javascripts/dashboard/components/Header_spec.jsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import { shallow } from 'enzyme';
 import Header from '../../../../src/dashboard/components/Header';

superset/assets/spec/javascripts/dashboard/components/MissingChart_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import Loading from '../../../../src/components/Loading';

superset/assets/spec/javascripts/dashboard/components/RefreshIntervalModal_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import RefreshIntervalModal from '../../../../src/dashboard/components/RefreshIntervalModal';

superset/assets/spec/javascripts/dashboard/components/SliceAdder_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it, beforeEach, afterEach } from 'mocha';
 import sinon from 'sinon';
 import { expect } from 'chai';
 

superset/assets/spec/javascripts/dashboard/components/dnd/DragDroppable_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow, mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/ChartHolder_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Chart_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Column_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Divider_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Header_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Markdown_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 import AceEditor from 'react-ace';

superset/assets/spec/javascripts/dashboard/components/gridComponents/Row_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Tab_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 

superset/assets/spec/javascripts/dashboard/components/gridComponents/Tabs_spec.jsx

@@ -1,7 +1,6 @@
 import { Provider } from 'react-redux';
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 import { Tabs as BootstrapTabs, Tab as BootstrapTab } from 'react-bootstrap';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/DraggableNewComponent_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { mount } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DragDroppable from '../../../../../../src/dashboard/components/dnd/DragDroppable';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/NewColumn_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DraggableNewComponent from '../../../../../../src/dashboard/components/gridComponents/new/DraggableNewComponent';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/NewDivider_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DraggableNewComponent from '../../../../../../src/dashboard/components/gridComponents/new/DraggableNewComponent';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/NewHeader_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DraggableNewComponent from '../../../../../../src/dashboard/components/gridComponents/new/DraggableNewComponent';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/NewRow_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DraggableNewComponent from '../../../../../../src/dashboard/components/gridComponents/new/DraggableNewComponent';

superset/assets/spec/javascripts/dashboard/components/gridComponents/new/NewTabs_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import DraggableNewComponent from '../../../../../../src/dashboard/components/gridComponents/new/DraggableNewComponent';

superset/assets/spec/javascripts/dashboard/components/menu/HoverMenu_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import HoverMenu from '../../../../../src/dashboard/components/menu/HoverMenu';

superset/assets/spec/javascripts/dashboard/components/menu/WithPopoverMenu_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import WithPopoverMenu from '../../../../../src/dashboard/components/menu/WithPopoverMenu';

superset/assets/spec/javascripts/dashboard/components/resizable/ResizableContainer_spec.jsx

@@ -1,7 +1,6 @@
 import React from 'react';
 import Resizable from 're-resizable';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import ResizableContainer from '../../../../../src/dashboard/components/resizable/ResizableContainer';

superset/assets/spec/javascripts/dashboard/components/resizable/ResizableHandle_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { shallow } from 'enzyme';
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import ResizableHandle from '../../../../../src/dashboard/components/resizable/ResizableHandle';

superset/assets/spec/javascripts/dashboard/reducers/dashboardLayout_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import layoutReducer from '../../../../src/dashboard/reducers/dashboardLayout';

superset/assets/spec/javascripts/dashboard/reducers/dashboardState_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import {

superset/assets/spec/javascripts/dashboard/reducers/sliceEntities_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import {

superset/assets/spec/javascripts/dashboard/util/componentIsResizable_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import componentIsResizable from '../../../../src/dashboard/util/componentIsResizable';

superset/assets/spec/javascripts/dashboard/util/dnd-reorder_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import reorderItem from '../../../../src/dashboard/util/dnd-reorder';

superset/assets/spec/javascripts/dashboard/util/dropOverflowsParent_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import dropOverflowsParent from '../../../../src/dashboard/util/dropOverflowsParent';

superset/assets/spec/javascripts/dashboard/util/findFirstParentContainer_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import findFirstParentContainerId from '../../../../src/dashboard/util/findFirstParentContainer';

superset/assets/spec/javascripts/dashboard/util/findParentId_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import findParentId from '../../../../src/dashboard/util/findParentId';

superset/assets/spec/javascripts/dashboard/util/getChartIdsFromLayout_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import getChartIdsFromLayout from '../../../../src/dashboard/util/getChartIdsFromLayout';

superset/assets/spec/javascripts/dashboard/util/getDashboardUrl_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import getDashboardUrl from '../../../../src/dashboard/util/getDashboardUrl';

superset/assets/spec/javascripts/dashboard/util/getDetailedComponentWidth_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import getDetailedComponentWidth from '../../../../src/dashboard/util/getDetailedComponentWidth';

superset/assets/spec/javascripts/dashboard/util/getDropPosition_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import getDropPosition, {

superset/assets/spec/javascripts/dashboard/util/getFormDataWithExtraFilters_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import getFormDataWithExtraFilters from '../../../../src/dashboard/util/charts/getFormDataWithExtraFilters';

superset/assets/spec/javascripts/dashboard/util/isValidChild_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import isValidChild from '../../../../src/dashboard/util/isValidChild';

superset/assets/spec/javascripts/dashboard/util/newComponentFactory_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import newComponentFactory from '../../../../src/dashboard/util/newComponentFactory';

superset/assets/spec/javascripts/dashboard/util/newEntitiesFromDrop_spec.js

@@ -1,4 +1,3 @@
-import { describe, it } from 'mocha';
 import { expect } from 'chai';
 
 import newEntitiesFromDrop from '../../../../src/dashboard/util/newEntitiesFromDrop';

superset/assets/spec/javascripts/datasource/DatasourceEditor_spec.jsx

@@ -1,7 +1,6 @@
 import React from 'react';
 import { Tabs } from 'react-bootstrap';
 import { expect } from 'chai';
-import { describe, it, beforeEach } from 'mocha';
 import { shallow } from 'enzyme';
 import configureStore from 'redux-mock-store';
 import $ from 'jquery';

superset/assets/spec/javascripts/datasource/DatasourceModal_spec.jsx

@@ -1,7 +1,6 @@
 import React from 'react';
 import { Modal } from 'react-bootstrap';
 import { expect } from 'chai';
-import { describe, it, beforeEach } from 'mocha';
 import configureStore from 'redux-mock-store';
 import { shallow } from 'enzyme';
 import $ from 'jquery';

superset/assets/spec/javascripts/explore/AdhocFilter_spec.js

@@ -1,5 +1,4 @@
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 
 import AdhocFilter, { EXPRESSION_TYPES, CLAUSES } from '../../../src/explore/AdhocFilter';
 

superset/assets/spec/javascripts/explore/AdhocMetric_spec.js

@@ -1,5 +1,4 @@
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 
 import AdhocMetric, { EXPRESSION_TYPES } from '../../../src/explore/AdhocMetric';
 import { AGGREGATES } from '../../../src/explore/constants';

superset/assets/spec/javascripts/explore/chartActions_spec.js

@@ -1,4 +1,3 @@
-import { it, describe } from 'mocha';
 import { expect } from 'chai';
 import sinon from 'sinon';
 import $ from 'jquery';

superset/assets/spec/javascripts/explore/components/AdhocFilterControl_spec.jsx

@@ -2,7 +2,6 @@
 import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 
 import AdhocFilter, { EXPRESSION_TYPES, CLAUSES } from '../../../../src/explore/AdhocFilter';

superset/assets/spec/javascripts/explore/components/AdhocFilterEditPopoverSimpleTabContent_spec.jsx

@@ -2,7 +2,6 @@
 import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 import { FormGroup } from 'react-bootstrap';
 

superset/assets/spec/javascripts/explore/components/AdhocFilterEditPopoverSqlTabContent_spec.jsx

@@ -2,7 +2,6 @@
 import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 import { FormGroup } from 'react-bootstrap';
 

superset/assets/spec/javascripts/explore/components/AdhocFilterEditPopover_spec.jsx

@@ -2,7 +2,6 @@
 import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 import { Button, Popover, Tab, Tabs } from 'react-bootstrap';
 

superset/assets/spec/javascripts/explore/components/AdhocFilterOption_spec.jsx

@@ -2,7 +2,6 @@
 import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 import { Label, OverlayTrigger } from 'react-bootstrap';
 

superset/assets/spec/javascripts/explore/components/AdhocMetricEditPopoverTitle_spec.jsx

@@ -2,7 +2,6 @@
 import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 import { OverlayTrigger } from 'react-bootstrap';
 

superset/assets/spec/javascripts/explore/components/AdhocMetricEditPopover_spec.jsx

@@ -2,7 +2,6 @@
 import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 import { Button, FormGroup, Popover } from 'react-bootstrap';
 

superset/assets/spec/javascripts/explore/components/AdhocMetricOption_spec.jsx

@@ -2,7 +2,6 @@
 import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 import { Label, OverlayTrigger } from 'react-bootstrap';
 

superset/assets/spec/javascripts/explore/components/AdhocMetricStaticOption_spec.jsx

@@ -1,7 +1,6 @@
 /* eslint-disable no-unused-expressions */
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 
 import AdhocMetricStaticOption from '../../../../src/explore/components/AdhocMetricStaticOption';

superset/assets/spec/javascripts/explore/components/AggregateOption_spec.jsx

@@ -1,7 +1,6 @@
 /* eslint-disable no-unused-expressions */
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 
 import AggregateOption from '../../../../src/explore/components/AggregateOption';

superset/assets/spec/javascripts/explore/components/BoundsControl_spec.jsx

@@ -3,7 +3,6 @@ import React from 'react';
 import { FormControl } from 'react-bootstrap';
 import sinon from 'sinon';
 import { expect } from 'chai';
-import { describe, it, beforeEach } from 'mocha';
 import { mount } from 'enzyme';
 
 import BoundsControl from '../../../../src/explore/components/controls/BoundsControl';

superset/assets/spec/javascripts/explore/components/CheckboxControl_spec.jsx

@@ -2,7 +2,6 @@
 import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
-import { describe, it, beforeEach } from 'mocha';
 import { shallow } from 'enzyme';
 
 import CheckboxControl from '../../../../src/explore/components/controls/CheckboxControl';

superset/assets/spec/javascripts/explore/components/ColorPickerControl_spec.jsx

@@ -1,7 +1,6 @@
 /* eslint-disable no-unused-expressions */
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it, beforeEach } from 'mocha';
 import { shallow } from 'enzyme';
 import { OverlayTrigger } from 'react-bootstrap';
 import { SketchPicker } from 'react-color';

superset/assets/spec/javascripts/explore/components/ColorScheme_spec.jsx

@@ -1,7 +1,6 @@
 /* eslint-disable no-unused-expressions */
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it, beforeEach } from 'mocha';
 import { mount } from 'enzyme';
 import { Creatable } from 'react-select';
 

superset/assets/spec/javascripts/explore/components/ControlPanelSection_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 import { Panel } from 'react-bootstrap';
 

superset/assets/spec/javascripts/explore/components/ControlPanelsContainer_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it, beforeEach } from 'mocha';
 import { shallow } from 'enzyme';
 import { getFormDataFromControls, defaultControls }
   from '../../../../src/explore/store';

superset/assets/spec/javascripts/explore/components/ControlRow_spec.jsx

@@ -1,6 +1,5 @@
 import React from 'react';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 import ControlSetRow from '../../../../src/explore/components/ControlRow';
 

superset/assets/spec/javascripts/explore/components/DatasourceControl_spec.jsx

@@ -2,7 +2,6 @@ import React from 'react';
 import sinon from 'sinon';
 import configureStore from 'redux-mock-store';
 import { expect } from 'chai';
-import { describe, it } from 'mocha';
 import { shallow } from 'enzyme';
 import DatasourceModal from '../../../../src/datasource/DatasourceModal';
 import DatasourceControl from '../../../../src/explore/components/controls/DatasourceControl';

superset/assets/spec/javascripts/explore/components/DateFilterControl_spec.jsx

@@ -2,7 +2,6 @@
 import React from 'react';
 import sinon from 'sinon';
 import { expect } from 'chai';
-import { describe, it, beforeEach } from 'mocha';
 import { shallow } from 'enzyme';
 import { Button, Label } from 'react-bootstrap';