From b99d38dfefc0a7feed7b633aa9d8964fee6f363a Mon Sep 17 00:00:00 2001 From: Daniel Vaz Gaspar Date: Mon, 13 Mar 2023 18:03:02 +0000 Subject: [PATCH] fix: dashboard DAO small code improvement (#23348) --- superset/dashboards/dao.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/superset/dashboards/dao.py b/superset/dashboards/dao.py index 3f0666266..d66703c91 100644 --- a/superset/dashboards/dao.py +++ b/superset/dashboards/dao.py @@ -39,8 +39,8 @@ class DashboardDAO(BaseDAO): model_cls = Dashboard base_filter = DashboardAccessFilter - @staticmethod - def get_by_id_or_slug(id_or_slug: Union[int, str]) -> Dashboard: + @classmethod + def get_by_id_or_slug(cls, id_or_slug: Union[int, str]) -> Dashboard: query = ( db.session.query(Dashboard) .filter(id_or_slug_filter(id_or_slug)) @@ -50,7 +50,7 @@ class DashboardDAO(BaseDAO): .outerjoin(Dashboard.roles) ) # Apply dashboard base filters - query = DashboardAccessFilter("id", SQLAInterface(Dashboard, db.session)).apply( + query = cls.base_filter("id", SQLAInterface(Dashboard, db.session)).apply( query, None ) dashboard = query.one_or_none()