From bd0b9f25e46818028ca5d4a12143aed3f117d1ee Mon Sep 17 00:00:00 2001
From: Adam Dobrawy <ad-m@users.noreply.github.com>
Date: Thu, 10 Feb 2022 14:21:48 +0100
Subject: [PATCH] refactor: migrate SliderControl to TypeScript & added story
 (#18120)

* refactor: migrate SliderControl to TypeScript & added story

* fix: Set default onChange in SliderControl
---
 .../controls/SliderControl.stories.tsx        | 45 +++++++++++++++++++
 .../{SliderControl.jsx => SliderControl.tsx}  | 22 ++++-----
 2 files changed, 53 insertions(+), 14 deletions(-)
 create mode 100644 superset-frontend/src/explore/components/controls/SliderControl.stories.tsx
 rename superset-frontend/src/explore/components/controls/{SliderControl.jsx => SliderControl.tsx} (70%)

diff --git a/superset-frontend/src/explore/components/controls/SliderControl.stories.tsx b/superset-frontend/src/explore/components/controls/SliderControl.stories.tsx
new file mode 100644
index 000000000..ed70a0c41
--- /dev/null
+++ b/superset-frontend/src/explore/components/controls/SliderControl.stories.tsx
@@ -0,0 +1,45 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import SliderControl from './SliderControl';
+
+export default {
+  title: 'SliderControl',
+  component: SliderControl,
+};
+
+const options = {
+  value: {
+    value: 25,
+  },
+  default: {
+    default: 50,
+  },
+};
+
+export const SliderControlGallery = () => (
+  <>
+    {Object.keys(options).map(name => (
+      <>
+        <h4>{name}</h4>
+        <SliderControl {...options[name]} />
+      </>
+    ))}
+  </>
+);
diff --git a/superset-frontend/src/explore/components/controls/SliderControl.jsx b/superset-frontend/src/explore/components/controls/SliderControl.tsx
similarity index 70%
rename from superset-frontend/src/explore/components/controls/SliderControl.jsx
rename to superset-frontend/src/explore/components/controls/SliderControl.tsx
index 3823c91ce..5907e26ba 100644
--- a/superset-frontend/src/explore/components/controls/SliderControl.jsx
+++ b/superset-frontend/src/explore/components/controls/SliderControl.tsx
@@ -17,27 +17,21 @@
  * under the License.
  */
 import React from 'react';
-import PropTypes from 'prop-types';
 import Slider from 'src/components/Slider';
 import ControlHeader from 'src/explore/components/ControlHeader';
 
-const propTypes = {
-  onChange: PropTypes.func,
-  value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+type SliderControlProps = {
+  onChange: (value: number) => void;
+  value: number;
+  default?: number;
 };
 
-const defaultProps = {
-  onChange: () => {},
-};
-
-export default function SliderControl(props) {
+export default function SliderControl(props: SliderControlProps) {
+  const { onChange = () => {}, default: defaultValue, ...rest } = props;
   return (
     <>
-      <ControlHeader {...props} />
-      <Slider {...props} defaultValue={props.default} />
+      <ControlHeader />
+      <Slider {...rest} onChange={onChange} defaultValue={defaultValue} />
     </>
   );
 }
-
-SliderControl.propTypes = propTypes;
-SliderControl.defaultProps = defaultProps;