iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: corrects spelling of USE_ANALAGOUS_COLORS to be USE_ANALOGOUS_COLORS (#31774)

This commit is contained in:
Evan Rusackas 2025-01-10 18:44:32 -07:00 committed by GitHub
parent 5e0de04eab
commit bebcd3dcdd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
UPDATING.md
View File

@ -23,7 +23,7 @@ This file documents any backwards-incompatible changes in Superset and
assists people when migrating to a new version.
## Next
- [31774](https://github.com/apache/superset/pull/31774): Fixes the spelling of the `USE-ANALAGOUS-COLORS` feature flag. Please update any scripts/configuration item to use the new/corrected `USE-ANALOGOUS-COLORS` flag spelling.
- [31582](https://github.com/apache/superset/pull/31582) Removed the legacy Area, Bar, Event Flow, Heatmap, Histogram, Line, Sankey, and Sankey Loop charts. They were all automatically migrated to their ECharts counterparts with the exception of the Event Flow and Sankey Loop charts which were removed as they were not actively maintained and not widely used. If you were using the Event Flow or Sankey Loop charts, you will need to find an alternative solution.
- [31198](https://github.com/apache/superset/pull/31198) Disallows by default the use of the following ClickHouse functions: "version", "currentDatabase", "hostName".
- [29798](https://github.com/apache/superset/pull/29798) Since 3.1.0, the intial schedule for an alert or report was mistakenly offset by the specified timezone's relation to UTC. The initial schedule should now begin at the correct time.

4
superset-frontend/packages/superset-ui-core/src/color/CategoricalColorScale.ts
View File

@ -65,7 +65,7 @@ class CategoricalColorScale extends ExtensibleFunction {
);
// holds original color scheme colors
this.originColors = colors;
// holds the extended color range (includes analagous colors)
// holds the extended color range (includes analogous colors)
this.colors = colors;
// holds the values of this specific slice (label+color)
this.chartLabelsColorMap = new Map();
@ -139,7 +139,7 @@ class CategoricalColorScale extends ExtensibleFunction {
// a forced color will always be used independently of the usage count
if (!forcedColor && !isExistingLabel) {
if (isFeatureEnabled(FeatureFlag.UseAnalagousColors)) {
if (isFeatureEnabled(FeatureFlag.UseAnalogousColors)) {
this.incrementColorRange();
}
if (

2
superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
View File

@ -58,7 +58,7 @@ export enum FeatureFlag {
SshTunneling = 'SSH_TUNNELING',
TaggingSystem = 'TAGGING_SYSTEM',
Thumbnails = 'THUMBNAILS',
UseAnalagousColors = 'USE_ANALAGOUS_COLORS',
UseAnalogousColors = 'USE_ANALOGOUS_COLORS',
ForceSqlLabRunAsync = 'SQLLAB_FORCE_RUN_ASYNC',
SlackEnableAvatars = 'SLACK_ENABLE_AVATARS',
EnableDashboardScreenshotEndpoints = 'ENABLE_DASHBOARD_SCREENSHOT_ENDPOINTS',

2
superset-frontend/packages/superset-ui-core/test/color/CategoricalColorScale.test.ts
View File

@ -165,7 +165,7 @@ describe('CategoricalColorScale', () => {
});
it('get analogous colors when number of items exceed available colors', () => {
window.featureFlags = {
[FeatureFlag.UseAnalagousColors]: true,
[FeatureFlag.UseAnalogousColors]: true,
};
const scale = new CategoricalColorScale(['blue', 'red', 'green']);
scale.getColor('pig');

6
superset-frontend/packages/superset-ui-core/test/color/LabelsColorMapSingleton.test.ts
View File

@ -212,7 +212,7 @@ describe('LabelsColorMap', () => {
it('should use recycle colors', () => {
window.featureFlags = {
[FeatureFlag.UseAnalagousColors]: false,
[FeatureFlag.UseAnalogousColors]: false,
};
labelsColorMap.addSlice('a', 'red', 1);
labelsColorMap.addSlice('b', 'blue', 2);
@ -224,9 +224,9 @@ describe('LabelsColorMap', () => {
expect(getAnalogousColorsSpy).not.toHaveBeenCalled();
});
it('should use analagous colors', () => {
it('should use analogous colors', () => {
window.featureFlags = {
[FeatureFlag.UseAnalagousColors]: true,
[FeatureFlag.UseAnalogousColors]: true,
};
labelsColorMap.addSlice('a', 'red', 1);

2
superset/config.py
View File

@ -513,7 +513,7 @@ DEFAULT_FEATURE_FLAGS: dict[str, bool] = {
# This could cause the server to run out of memory or compute.
"ALLOW_FULL_CSV_EXPORT": False,
"ALLOW_ADHOC_SUBQUERY": False,
"USE_ANALAGOUS_COLORS": False,
"USE_ANALOGOUS_COLORS": False,
# Apply RLS rules to SQL Lab queries. This requires parsing and manipulating the
# query, and might break queries and/or allow users to bypass RLS. Use with care!
"RLS_IN_SQLLAB": False,