diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/CascadeFilterControl.test.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/CascadeFilterControl.test.tsx new file mode 100644 index 000000000..2cfdb3a1e --- /dev/null +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/CascadeFilterControl.test.tsx @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import { render, screen } from 'spec/helpers/testing-library'; +import { mockStore } from 'spec/fixtures/mockStore'; +import { Provider } from 'react-redux'; +import { nativeFiltersInfo } from 'spec/javascripts/dashboard/fixtures/mockNativeFilters'; +import CascadeFilterControl, { CascadeFilterControlProps } from '.'; + +const mockedProps = { + filter: { + ...nativeFiltersInfo.filters.DefaultsID, + cascadeChildren: [ + { + ...nativeFiltersInfo.filters.DefaultsID, + name: 'test child filter 1', + cascadeChildren: [], + }, + { + ...nativeFiltersInfo.filters.DefaultsID, + name: 'test child filter 2', + cascadeChildren: [ + { + ...nativeFiltersInfo.filters.DefaultsID, + name: 'test child of a child filter', + cascadeChildren: [], + }, + ], + }, + ], + }, + onFilterSelectionChange: jest.fn(), +}; + +const setup = (props: CascadeFilterControlProps) => ( + + + +); + +test('should render', () => { + const { container } = render(setup(mockedProps)); + expect(container).toBeInTheDocument(); +}); + +test('should render the filter name', () => { + render(setup(mockedProps)); + expect(screen.getByText('test')).toBeInTheDocument(); +}); + +test('should render the children filter names', () => { + render(setup(mockedProps)); + expect(screen.getByText('test child filter 1')).toBeInTheDocument(); + expect(screen.getByText('test child filter 2')).toBeInTheDocument(); +}); + +test('should render the child of a child filter name', () => { + render(setup(mockedProps)); + expect(screen.getByText('test child of a child filter')).toBeInTheDocument(); +}); diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx similarity index 86% rename from superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl.tsx rename to superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx index 3b5ce92b6..1ac1fb3a5 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx @@ -19,11 +19,11 @@ import React from 'react'; import { styled, DataMask } from '@superset-ui/core'; import Icon from 'src/components/Icon'; -import FilterControl from '../FilterControls/FilterControl'; -import { Filter } from '../../types'; -import { CascadeFilter } from './types'; +import FilterControl from 'src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl'; +import { CascadeFilter } from 'src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/types'; +import { Filter } from 'src/dashboard/components/nativeFilters/types'; -interface CascadeFilterControlProps { +export interface CascadeFilterControlProps { filter: CascadeFilter; directPathToChild?: string[]; onFilterSelectionChange: (filter: Filter, dataMask: DataMask) => void; diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx similarity index 94% rename from superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover.tsx rename to superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx index dfd0a67ef..76be1409f 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx @@ -24,10 +24,10 @@ import { Pill } from 'src/dashboard/components/FiltersBadge/Styles'; import { useSelector } from 'react-redux'; import { getInitialMask } from 'src/dataMask/reducer'; import { MaskWithId } from 'src/dataMask/types'; -import FilterControl from '../FilterControls/FilterControl'; -import CascadeFilterControl from './CascadeFilterControl'; -import { CascadeFilter } from './types'; -import { Filter } from '../../types'; +import FilterControl from 'src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl'; +import CascadeFilterControl from 'src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl'; +import { CascadeFilter } from 'src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/types'; +import { Filter } from 'src/dashboard/components/nativeFilters/types'; interface CascadePopoverProps { filter: CascadeFilter;