iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[explore] 'Save as' -> 'Save' as it can be used to overwrite (#2875) 

* [explore] 'Save as' -> 'Save' as it can be used to overwrite

* Fix tests
This commit is contained in:
Maxime Beauchemin 2017-05-31 14:31:13 -07:00 committed by GitHub
parent 90e4d6469d
commit c5f2eafc90
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx
View File

@ -56,7 +56,7 @@ export default function QueryAndSaveBtns(
disabled={saveButtonDisabled}
onClick={onSave}
>
<i className="fa fa-plus-circle" /> Save as
<i className="fa fa-plus-circle" /> Save
</Button>
</ButtonGroup>
{errorMessage &&

2
superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx
View File

@ -32,7 +32,7 @@ describe('QueryAndSaveButtons', () => {
it('renders buttons with correct text', () => {
expect(wrapper.find(Button).contains(' Query')).to.eql(true);
expect(wrapper.find(Button).contains(' Save as')).to.eql(true);
expect(wrapper.find(Button).contains(' Save')).to.eql(true);
});
it('calls onQuery when query button is clicked', () => {