iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: prevent CI double runs on push + pull_request (#26766)

This commit is contained in:
Maxime Beauchemin 2024-01-23 20:30:53 -08:00 committed by GitHub
parent 7da56a0744
commit c6772b6c78
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
17 changed files with 132 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/check_db_migration_confict.yml vendored
View File

@ -3,6 +3,12 @@ on:
push:
paths:
- "superset/migrations/**"
branches:
- 'master'
pull_request:
paths:
- "superset/migrations/**"
types: [synchronize, opened, reopened, ready_for_review]
jobs:
check_db_migration_conflict:

7
.github/workflows/docker.yml vendored
View File

@ -33,6 +33,13 @@ jobs:
matrix:
target: ["dev", "lean", "lean310", "websocket", "dockerize"]
platform: ["linux/amd64", "linux/arm64"]
exclude:
# disabling because slow! no python wheels for arm/py39 and
# QEMU is slow!
- target: "dev"
platform: "linux/arm64"
- target: "lean"
platform: "linux/arm64"
fail-fast: false
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"

5
.github/workflows/license-check.yml vendored
View File

@ -2,9 +2,10 @@ name: License Check
on:
push:
branches-ignore:
- "dependabot/**"
branches:
- 'master'
pull_request:
types: [synchronize, opened, reopened, ready_for_review]
jobs:
config:

54
.github/workflows/no-op.yml vendored Normal file
View File

@ -0,0 +1,54 @@
# no-op.yml
#
# Purpose:
# This workflow provides a workaround for the "required status checks" feature in GitHub Actions
# when using path-specific conditions in other workflows. Required checks might remain in a "Pending"
# state if the conditions are not met, thus blocking pull requests from being merged.
# This no-op (no operation) workflow provides dummy success statuses for these required jobs when
# the real jobs do not run due to path-specific conditions.
#
# How it works:
# - It defines jobs with the same names as the required jobs in the main workflows.
# - These jobs simply execute a command (`exit 0`) to succeed immediately.
# - When a pull request is created or updated, both this no-op workflow and the main workflows are triggered.
# - If the main workflows' jobs don't run (due to path conditions), these no-op jobs provide successful statuses.
# - If the main workflows' jobs do run and fail, their failure statuses take precedence,
# ensuring that pull requests are not merged with failing checks.
#
# Usage:
# - Ensure that the job names in this workflow match exactly the names of the corresponding jobs in the main workflows.
# - This workflow should be kept as-is, without path-specific conditions.
name: No Operation Checks
on: pull_request
jobs:
frontend-build:
runs-on: ubuntu-latest
steps:
- name: No-op for frontend-build
run: |
echo "This is a no-op step for frontend-build to ensure a successful status."
exit 0
pre-commit:
strategy:
matrix:
python-version: ["3.9"]
runs-on: ubuntu-latest
steps:
- name: No-op for pre-commit
run: |
echo "This is a no-op step for pre-commit to ensure a successful status."
exit 0
python-lint:
strategy:
matrix:
python-version: ["3.9"]
runs-on: ubuntu-latest
steps:
- name: No-op for python-lint
run: |
echo "This is a no-op step for python-lint to ensure a successful status."
exit 0

10
.github/workflows/prefer-typescript.yml vendored
View File

@ -2,10 +2,14 @@ name: Prefer TypeScript
on:
push:
branches-ignore:
- "dependabot/**"
branches:
- 'master'
paths:
- "superset-frontend/src/**"
pull_request:
types: [synchronize, opened, reopened, ready_for_review]
paths:
- "superset-frontend/src/**"
jobs:
prefer_typescript:
if: github.ref == 'ref/heads/master' && github.event_name == 'pull_request'

4
.github/workflows/superset-cli.yml vendored
View File

@ -2,8 +2,8 @@ name: Superset CLI tests
on:
push:
branches-ignore:
- "dependabot/npm_and_yarn/**"
branches:
- 'master'
pull_request:
types: [synchronize, opened, reopened, ready_for_review]

3
.github/workflows/superset-docs.yml vendored
View File

@ -4,9 +4,12 @@ on:
push:
paths:
- "docs/**"
branches:
- 'master'
pull_request:
paths:
- "docs/**"
types: [synchronize, opened, reopened, ready_for_review]
jobs:
config:

6
.github/workflows/superset-e2e.yml vendored
View File

@ -2,10 +2,8 @@ name: E2E
on:
push:
branches-ignore:
- "dependabot/**/docs/**"
paths-ignore:
- "docs/**"
branches:
- 'master'
pull_request:
types: [synchronize, opened, reopened, ready_for_review]

9
.github/workflows/superset-frontend.yml vendored
View File

@ -2,11 +2,14 @@ name: Frontend
on:
push:
branches-ignore:
- "dependabot/**/docs/**"
- "dependabot/**/cypress-base/**"
branches:
- "master"
paths:
- "superset-frontend/**"
pull_request:
types: [synchronize, opened, reopened, ready_for_review]
paths:
- "superset-frontend/**"
jobs:
frontend-build:

2
.github/workflows/superset-helm-lint.yml vendored
View File

@ -3,6 +3,8 @@ name: Lint and Test Charts
on:
pull_request:
types: [opened, edited, reopened, synchronize]
paths:
- "helm/**"
jobs:
lint-test:

4
.github/workflows/superset-python-integrationtest.yml vendored
View File

@ -3,8 +3,8 @@ name: Python-Integration
on:
push:
branches-ignore:
- "dependabot/npm_and_yarn/**"
branches:
- 'master'
pull_request:
types: [synchronize, opened, reopened, ready_for_review]

8
.github/workflows/superset-python-misc.yml vendored
View File

@ -3,10 +3,14 @@ name: Python Misc
on:
push:
branches-ignore:
- "dependabot/npm_and_yarn/**"
branches:
- 'master'
paths:
- "superset/**"
pull_request:
types: [synchronize, opened, reopened, ready_for_review]
paths:
- "superset/**"
jobs:
python-lint:

8
.github/workflows/superset-python-presto-hive.yml vendored
View File

@ -3,10 +3,14 @@ name: Python Presto/Hive
on:
push:
branches-ignore:
- "dependabot/npm_and_yarn/**"
branches:
- 'master'
paths:
- "superset/**"
pull_request:
types: [synchronize, opened, reopened, ready_for_review]
paths:
- "superset/**"
jobs:
test-postgres-presto:

8
.github/workflows/superset-python-unittest.yml vendored
View File

@ -3,10 +3,14 @@ name: Python-Unit
on:
push:
branches-ignore:
- "dependabot/npm_and_yarn/**"
branches:
- 'master'
paths:
- "superset/**"
pull_request:
types: [synchronize, opened, reopened, ready_for_review]
paths:
- "superset/**"
jobs:
unit-tests:

4
.github/workflows/superset-translations.yml vendored
View File

@ -2,8 +2,8 @@ name: Translations
on:
push:
branches-ignore:
- "dependabot/npm_and_yarn/**"
branches:
- 'master'
pull_request:
types: [synchronize, opened, reopened, ready_for_review]

3
.github/workflows/superset-websocket.yml vendored
View File

@ -1,11 +1,14 @@
name: WebSocket server
on:
push:
branches:
- 'master'
paths:
- "superset-websocket/**"
pull_request:
paths:
- "superset-websocket/**"
types: [synchronize, opened, reopened, ready_for_review]
jobs:
app-checks:

22
scripts/docker_build_push.sh
View File

@ -70,27 +70,31 @@ fi
BUILD_ARG="3.9-slim-bookworm"
# Replace '/' with '-' in BUILD_PLATFORM
SAFE_BUILD_PLATFORM=$(echo "${BUILD_PLATFORM}" | sed 's/\//-/g')
MAIN_UNIQUE_TAG="${REPO_NAME}:${SHA}-${TARGET}-${SAFE_BUILD_PLATFORM}-${BUILD_ARG}"
case "${TARGET}" in
"dev")
DOCKER_TAGS="-t ${REPO_NAME}:${SHA}-dev -t ${REPO_NAME}:${REFSPEC}-dev -t ${DEV_TAG}"
DOCKER_TAGS="-t ${MAIN_UNIQUE_TAG} -t ${REPO_NAME}:${SHA}-dev -t ${REPO_NAME}:${REFSPEC}-dev -t ${DEV_TAG}"
BUILD_TARGET="dev"
;;
"lean")
DOCKER_TAGS="-t ${REPO_NAME}:${SHA} -t ${REPO_NAME}:${REFSPEC} -t ${REPO_NAME}:${LATEST_TAG}"
DOCKER_TAGS="-t ${MAIN_UNIQUE_TAG} -t ${REPO_NAME}:${SHA} -t ${REPO_NAME}:${REFSPEC} -t ${REPO_NAME}:${LATEST_TAG}"
BUILD_TARGET="lean"
;;
"lean310")
DOCKER_TAGS="-t ${REPO_NAME}:${SHA}-py310 -t ${REPO_NAME}:${REFSPEC}-py310 -t ${REPO_NAME}:${LATEST_TAG}-py310"
DOCKER_TAGS="-t ${MAIN_UNIQUE_TAG} -t ${REPO_NAME}:${SHA}-py310 -t ${REPO_NAME}:${REFSPEC}-py310 -t ${REPO_NAME}:${LATEST_TAG}-py310"
BUILD_TARGET="lean"
BUILD_ARG="3.10-slim-bookworm"
;;
"websocket")
DOCKER_TAGS="-t ${REPO_NAME}:${SHA}-websocket -t ${REPO_NAME}:${REFSPEC}-websocket -t ${REPO_NAME}:${LATEST_TAG}-websocket"
DOCKER_TAGS="-t ${MAIN_UNIQUE_TAG} -t ${REPO_NAME}:${SHA}-websocket -t ${REPO_NAME}:${REFSPEC}-websocket -t ${REPO_NAME}:${LATEST_TAG}-websocket"
BUILD_TARGET=""
DOCKER_CONTEXT="superset-websocket"
;;
"dockerize")
DOCKER_TAGS="-t ${REPO_NAME}:dockerize"
DOCKER_TAGS="-t ${MAIN_UNIQUE_TAG} -t ${REPO_NAME}:dockerize"
BUILD_TARGET=""
DOCKER_CONTEXT="-f dockerize.Dockerfile ."
;;
@ -102,6 +106,7 @@ esac
cat<<EOF
Rolling with tags:
- $MAIN_UNIQUE_TAG
- ${REPO_NAME}:${SHA}
- ${REPO_NAME}:${REFSPEC}
- ${REPO_NAME}:${LATEST_TAG}
@ -125,11 +130,14 @@ if [[ -n "${BUILD_TARGET}" ]]; then
TARGET_ARGUMENT="--target ${BUILD_TARGET}"
fi
CACHE_REF="${REPO_NAME}-cache:${TARGET}-${BUILD_ARG}"
CACHE_REF=$(echo "${CACHE_REF}" | tr -d '.')
docker buildx build \
${TARGET_ARGUMENT} \
${DOCKER_ARGS} \
--cache-from=type=registry,ref=apache/superset:${TARGET} \
--cache-to=type=registry,mode=max,ref=apache/superset:${TARGET} \
--cache-from=type=registry,ref=${CACHE_REF} \
--cache-to=type=registry,mode=max,ref=${CACHE_REF} \
${DOCKER_TAGS} \
--platform ${BUILD_PLATFORM} \
--label "sha=${SHA}" \