From c8a5dec84d2692b64ddef8cc694181139701b1fa Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Tue, 6 Oct 2020 12:55:13 -0700 Subject: [PATCH] style(dashboard): minor improvements to chart context menu (#11170) Bumping "Explore/edit chart" as the first option. Getting rid of the old "edit chart properties" deprecated CRUD link --- .../src/dashboard/components/SliceHeaderControls.jsx | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx b/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx index 728954099..a6da5106d 100644 --- a/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx +++ b/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx @@ -158,9 +158,9 @@ class SliceHeaderControls extends React.PureComponent { )} - {this.props.sliceCanEdit && ( - - {t('Edit chart metadata')} + {this.props.supersetCanExplore && ( + + {t('Explore chart')} )} @@ -168,12 +168,6 @@ class SliceHeaderControls extends React.PureComponent { {t('Export CSV')} )} - {this.props.supersetCanExplore && ( - - {t('Explore chart')} - - )} - {resizeLabel}