iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(security): can_access with None crashes on builtin roles (#10039)

This commit is contained in:
Daniel Vaz Gaspar 2020-06-11 16:02:08 +01:00 committed by GitHub
parent 8744dadca8
commit c9ee598ac9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
superset/security/manager.py
View File

@ -254,11 +254,11 @@ class SupersetSecurityManager(SecurityManager):
:param datasource: The Superset datasource
:returns: Whether the user can access the datasource's schema
"""
schema_perm = datasource.schema_perm or ""
return (
self.all_datasource_access()
or self.database_access(datasource.database)
or self.can_access("schema_access", datasource.schema_perm)
or self.can_access("schema_access", schema_perm)
)
def datasource_access(self, datasource: "BaseDatasource") -> bool:
@ -268,9 +268,9 @@ class SupersetSecurityManager(SecurityManager):
:param datasource: The Superset datasource
:returns: Whether the use can access the Superset datasource
"""
perm = datasource.perm or ""
return self.schema_access(datasource) or self.can_access(
"datasource_access", datasource.perm
"datasource_access", perm
)
def get_datasource_access_error_msg(self, datasource: "BaseDatasource") -> str: