From cb51d7833f7cd41dc98a4b1fdc7eada59b267d8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=CA=88=E1=B5=83=E1=B5=A2?= Date: Mon, 20 Apr 2020 15:06:33 -0700 Subject: [PATCH] [Build] moves prettier check to separate script (#9591) * [Build] moves prettier check to separate script * rename step: eslint -> lint --- .github/workflows/superset-frontend.yml | 3 ++- superset-frontend/package.json | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml index e14d75e9a..f8ab8321f 100644 --- a/.github/workflows/superset-frontend.yml +++ b/.github/workflows/superset-frontend.yml @@ -13,10 +13,11 @@ jobs: uses: apache-superset/cached-dependencies@adc6f73 with: run: npm-install - - name: eslint + - name: lint working-directory: ./superset-frontend run: | npm run lint + npm run prettier-check - name: unit tests working-directory: ./superset-frontend run: | diff --git a/superset-frontend/package.json b/superset-frontend/package.json index 351e014d8..5e31a175a 100644 --- a/superset-frontend/package.json +++ b/superset-frontend/package.json @@ -17,7 +17,8 @@ "build-dev": "cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=development webpack --mode=development --colors --progress", "build-instrumented": "cross-env NODE_ENV=development BABEL_ENV=instrumented webpack --mode=development --colors --progress", "build": "cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=production webpack --mode=production --colors --progress", - "lint": "prettier --check '{src,stylesheets}/**/*.{css,less,sass,scss}' && eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .", + "lint": "eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,.tsx .", + "prettier-check": "prettier --check '{src,stylesheets}/**/*.{css,less,sass,scss}'", "lint-fix": "eslint --fix --ignore-path=.eslintignore --ext .js,.jsx,.ts,tsx . && npm run clean-css", "clean-css": "prettier --write '{src,stylesheets}/**/*.{css,less,sass,scss}'" },