iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: attempt to fix the flaky SQL Lab test (#8212) 

* fix: attempt to fix the flaky SQL Lab test

https://docs.cypress.io/api/commands/clear.html#Syntax

doubling our chances to selectall and clear the text box

* Add {force: true}

* fix typo

* more clears
This commit is contained in:
Maxime Beauchemin 2019-09-10 22:16:26 -07:00 committed by GitHub
parent 50cd558d40
commit cb6abe343b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset/assets/cypress/integration/dashboard/controls.js vendored
View File

@ -60,7 +60,7 @@ export default () => describe('top-level controls', () => {
.find('.refresh-tooltip').trigger('click', { force: true });
// not allow dashboard level force refresh when any chart is loading
cy.get('#save-dash-split-button').trigger('click', { forece: true });
cy.get('#save-dash-split-button').trigger('click', { force: true });
cy.contains('Force refresh dashboard').parent().should('have.class', 'disabled');
// not allow chart level force refresh when it is loading
cy.get(`#slice_${mapId}-controls`).next()

9
superset/assets/cypress/integration/sqllab/query.js
View File

@ -34,7 +34,9 @@ export default () => {
// are fetched below (because React _Virtualized_ does not render all rows)
const rowLimit = 3;
cy.get('#brace-editor textarea').type(
cy.get('#brace-editor textarea')
.clear({ force: true })
.type(
`{selectall}{backspace}SELECT ds, gender, name, num FROM main.birth_names LIMIT ${rowLimit}`,
{ force: true },
);
@ -68,6 +70,7 @@ export default () => {
let savedQueryResultsTable = null;
cy.get('#brace-editor textarea')
.clear({ force: true })
.type(`{selectall}{backspace}${query}`, { force: true })
.focus() // focus => blur is required for updating the query that is to be saved
.blur();
@ -87,7 +90,9 @@ export default () => {
.click();
// Enter name + save into modal
cy.get('.modal-sm input').type(`{selectall}{backspace}${savedQueryTitle}`, {
cy.get('.modal-sm input')
.clear({ force: true })
.type(`{selectall}{backspace}${savedQueryTitle}`, {
force: true,
});