iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: schedules test refactor (#10492)

This commit is contained in:
Jesse Yang 2020-07-31 12:05:39 -07:00 committed by GitHub
parent 704f89c1db
commit ce10e13ec3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
tests/schedules_test.py
View File

@ -61,9 +61,13 @@ class TestSchedules(SupersetTestCase):
delivery_type=EmailDeliveryType.inline, delivery_type=EmailDeliveryType.inline,
) )
# Pick up a random slice and dashboard # Pick up a sample slice and dashboard
slce = db.session.query(Slice).filter_by(slice_name="Participants").all()[0] slce = db.session.query(Slice).filter_by(slice_name="Participants").one()
dashboard = db.session.query(Dashboard).all()[0] dashboard = (
db.session.query(Dashboard)
.filter_by(dashboard_title="USA Births Names")
.one()
)
dashboard_schedule = DashboardEmailSchedule(**cls.common_data) dashboard_schedule = DashboardEmailSchedule(**cls.common_data)
dashboard_schedule.dashboard_id = dashboard.id dashboard_schedule.dashboard_id = dashboard.id
@ -190,7 +194,7 @@ class TestSchedules(SupersetTestCase):
schedule = ( schedule = (
db.session.query(DashboardEmailSchedule) db.session.query(DashboardEmailSchedule)
.filter_by(id=self.dashboard_schedule) .filter_by(id=self.dashboard_schedule)
.all()[0] .one()
) )
deliver_dashboard( deliver_dashboard(
@ -226,7 +230,7 @@ class TestSchedules(SupersetTestCase):
schedule = ( schedule = (
db.session.query(DashboardEmailSchedule) db.session.query(DashboardEmailSchedule)
.filter_by(id=self.dashboard_schedule) .filter_by(id=self.dashboard_schedule)
.all()[0] .one()
) )
schedule.delivery_type = EmailDeliveryType.attachment schedule.delivery_type = EmailDeliveryType.attachment
@ -270,7 +274,7 @@ class TestSchedules(SupersetTestCase):
schedule = ( schedule = (
db.session.query(DashboardEmailSchedule) db.session.query(DashboardEmailSchedule)
.filter_by(id=self.dashboard_schedule) .filter_by(id=self.dashboard_schedule)
.all()[0] .one()
) )
deliver_dashboard( deliver_dashboard(
@ -309,7 +313,7 @@ class TestSchedules(SupersetTestCase):
schedule = ( schedule = (
db.session.query(DashboardEmailSchedule) db.session.query(DashboardEmailSchedule)
.filter_by(id=self.dashboard_schedule) .filter_by(id=self.dashboard_schedule)
.all()[0] .one()
) )
# Send individual mails to the group # Send individual mails to the group
@ -351,9 +355,7 @@ class TestSchedules(SupersetTestCase):
element.screenshot_as_png = read_fixture("sample.png") element.screenshot_as_png = read_fixture("sample.png")
schedule = ( schedule = (
db.session.query(SliceEmailSchedule) db.session.query(SliceEmailSchedule).filter_by(id=self.slice_schedule).one()
.filter_by(id=self.slice_schedule)
.all()[0]
) )
schedule.email_format = SliceEmailReportFormat.visualization schedule.email_format = SliceEmailReportFormat.visualization
@ -405,9 +407,7 @@ class TestSchedules(SupersetTestCase):
element.screenshot_as_png = read_fixture("sample.png") element.screenshot_as_png = read_fixture("sample.png")
schedule = ( schedule = (
db.session.query(SliceEmailSchedule) db.session.query(SliceEmailSchedule).filter_by(id=self.slice_schedule).one()
.filter_by(id=self.slice_schedule)
.all()[0]
) )
schedule.email_format = SliceEmailReportFormat.visualization schedule.email_format = SliceEmailReportFormat.visualization
@ -455,9 +455,7 @@ class TestSchedules(SupersetTestCase):
response.read.return_value = self.CSV response.read.return_value = self.CSV
schedule = ( schedule = (
db.session.query(SliceEmailSchedule) db.session.query(SliceEmailSchedule).filter_by(id=self.slice_schedule).one()
.filter_by(id=self.slice_schedule)
.all()[0]
) )
schedule.email_format = SliceEmailReportFormat.data schedule.email_format = SliceEmailReportFormat.data
@ -501,9 +499,7 @@ class TestSchedules(SupersetTestCase):
mock_urlopen.return_value.getcode.return_value = 200 mock_urlopen.return_value.getcode.return_value = 200
response.read.return_value = self.CSV response.read.return_value = self.CSV
schedule = ( schedule = (
db.session.query(SliceEmailSchedule) db.session.query(SliceEmailSchedule).filter_by(id=self.slice_schedule).one()
.filter_by(id=self.slice_schedule)
.all()[0]
) )
schedule.email_format = SliceEmailReportFormat.data schedule.email_format = SliceEmailReportFormat.data