diff --git a/superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopover_spec.jsx b/superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopover_spec.jsx index 8b446a2ab..689dcbf63 100644 --- a/superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopover_spec.jsx +++ b/superset-frontend/spec/javascripts/explore/components/AdhocFilterEditPopover_spec.jsx @@ -127,9 +127,9 @@ describe('AdhocFilterEditPopover', () => { wrapper.instance().onDragDown = sinon.spy(); wrapper.instance().forceUpdate(); - expect(wrapper.find('i.glyphicon-resize-full')).toHaveLength(1); + expect(wrapper.find('i.fa-expand')).toHaveLength(1); expect(wrapper.instance().onDragDown.calledOnce).toBe(false); - wrapper.find('i.glyphicon-resize-full').simulate('mouseDown', {}); + wrapper.find('i.fa-expand').simulate('mouseDown', {}); expect(wrapper.instance().onDragDown.calledOnce).toBe(true); }); }); diff --git a/superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopover_spec.jsx b/superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopover_spec.jsx index 892874f83..fdb262371 100644 --- a/superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopover_spec.jsx +++ b/superset-frontend/spec/javascripts/explore/components/AdhocMetricEditPopover_spec.jsx @@ -127,9 +127,9 @@ describe('AdhocMetricEditPopover', () => { wrapper.instance().onDragDown = sinon.spy(); wrapper.instance().forceUpdate(); - expect(wrapper.find('i.glyphicon-resize-full')).toHaveLength(1); + expect(wrapper.find('i.fa-expand')).toHaveLength(1); expect(wrapper.instance().onDragDown.calledOnce).toBe(false); - wrapper.find('i.glyphicon-resize-full').simulate('mouseDown'); + wrapper.find('i.fa-expand').simulate('mouseDown'); expect(wrapper.instance().onDragDown.calledOnce).toBe(true); }); }); diff --git a/superset-frontend/src/explore/components/AdhocFilterEditPopover.jsx b/superset-frontend/src/explore/components/AdhocFilterEditPopover.jsx index 4aa19a2b8..c80834652 100644 --- a/superset-frontend/src/explore/components/AdhocFilterEditPopover.jsx +++ b/superset-frontend/src/explore/components/AdhocFilterEditPopover.jsx @@ -184,7 +184,7 @@ export default class AdhocFilterEditPopover extends React.Component { diff --git a/superset-frontend/src/explore/components/AdhocFilterOption.jsx b/superset-frontend/src/explore/components/AdhocFilterOption.jsx index 5517148a0..d44dfee93 100644 --- a/superset-frontend/src/explore/components/AdhocFilterOption.jsx +++ b/superset-frontend/src/explore/components/AdhocFilterOption.jsx @@ -112,7 +112,9 @@ export default class AdhocFilterOption extends React.PureComponent { diff --git a/superset-frontend/src/explore/components/AdhocMetricEditPopover.jsx b/superset-frontend/src/explore/components/AdhocMetricEditPopover.jsx index 6b6bc0ec3..3193f0408 100644 --- a/superset-frontend/src/explore/components/AdhocMetricEditPopover.jsx +++ b/superset-frontend/src/explore/components/AdhocMetricEditPopover.jsx @@ -318,7 +318,7 @@ export default class AdhocMetricEditPopover extends React.Component { diff --git a/superset-frontend/src/explore/components/AdhocMetricOption.jsx b/superset-frontend/src/explore/components/AdhocMetricOption.jsx index 1f23ae694..9bdca1f3a 100644 --- a/superset-frontend/src/explore/components/AdhocMetricOption.jsx +++ b/superset-frontend/src/explore/components/AdhocMetricOption.jsx @@ -53,7 +53,7 @@ export default class AdhocMetricOption extends React.PureComponent { // once the overlay has been opened, the metric/filter will never be // considered new again. this.props.adhocMetric.isNew = false; - this.setState({ overlayShown: false }); + this.setState({ overlayShown: true }); } onOverlayExited() { @@ -99,7 +99,9 @@ export default class AdhocMetricOption extends React.PureComponent { diff --git a/superset-frontend/src/explore/components/controls/DateFilterControl.jsx b/superset-frontend/src/explore/components/controls/DateFilterControl.jsx index 669fdb617..e2d1519ad 100644 --- a/superset-frontend/src/explore/components/controls/DateFilterControl.jsx +++ b/superset-frontend/src/explore/components/controls/DateFilterControl.jsx @@ -340,7 +340,7 @@ export default class DateFilterControl extends React.Component { renderInput(props, key) { return ( - + this.toggleCalendar(key)}> @@ -454,7 +454,7 @@ export default class DateFilterControl extends React.Component {