diff --git a/.codecov.yml b/.codecov.yml index b093cfdf6..03a93cd47 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -1,13 +1,18 @@ +codecov: + notify: + after_n_builds: 4 ignore: - "superset/migrations/versions/*.py" coverage: status: project: + informational: true default: # Commits pushed to master should not make the overall # project coverage decrease: target: auto threshold: 0% patch: + informational: true default: threshold: 0% diff --git a/.github/workflows/bashlib.sh b/.github/workflows/bashlib.sh index b1d0edbbc..cfa8262ef 100644 --- a/.github/workflows/bashlib.sh +++ b/.github/workflows/bashlib.sh @@ -191,11 +191,6 @@ cypress-run-all() { cypress-run "*/**/*" - # Upload code coverage separately so each page can have separate flags - # -c will clean existing coverage reports, -F means add flags - # || true to prevent CI failure on codecov upload - codecov -cF "cypress" || true - # After job is done, print out Flask log for debugging say "::group::Flask log for default run" cat "$flasklog" @@ -211,8 +206,10 @@ cypress-run-all() { cypress-run "sqllab/*" "Backend persist" + # Upload code coverage separately so each page can have separate flags + # -c will clean existing coverage reports, -F means add flags # || true to prevent CI failure on codecov upload - codecov -cF "cypress" || true + codecov -c -F "cypress" || true say "::group::Flask log for backend persist" cat "$flasklog" diff --git a/.github/workflows/superset-frontend.yml b/.github/workflows/superset-frontend.yml index 2fe7113cc..a5d259b9a 100644 --- a/.github/workflows/superset-frontend.yml +++ b/.github/workflows/superset-frontend.yml @@ -45,4 +45,4 @@ jobs: if: steps.check.outcome == 'failure' working-directory: ./superset-frontend run: | - bash <(curl -s https://codecov.io/bash) -cF javascript + bash <(curl -s https://codecov.io/bash) -c -F javascript diff --git a/.github/workflows/superset-python-presto-hive.yml b/.github/workflows/superset-python-presto-hive.yml index bfc6c5c4d..4eefa9059 100644 --- a/.github/workflows/superset-python-presto-hive.yml +++ b/.github/workflows/superset-python-presto-hive.yml @@ -82,7 +82,7 @@ jobs: - name: Upload code coverage if: steps.check.outcome == 'failure' run: | - bash <(curl -s https://codecov.io/bash) -cF python + bash <(curl -s https://codecov.io/bash) -c -F python -F presto test-postgres-hive: if: github.event.pull_request.draft == false @@ -158,4 +158,4 @@ jobs: - name: Upload code coverage if: steps.check.outcome == 'failure' run: | - bash <(curl -s https://codecov.io/bash) -cF python + bash <(curl -s https://codecov.io/bash) -c -F python -F hive diff --git a/.github/workflows/superset-python-unittest.yml b/.github/workflows/superset-python-unittest.yml index 91406c545..1f093509b 100644 --- a/.github/workflows/superset-python-unittest.yml +++ b/.github/workflows/superset-python-unittest.yml @@ -70,7 +70,7 @@ jobs: - name: Upload code coverage if: steps.check.outcome == 'failure' run: | - bash <(curl -s https://codecov.io/bash) -cF python + bash <(curl -s https://codecov.io/bash) -c -F python -F mysql test-postgres: if: github.event.pull_request.draft == false @@ -134,7 +134,7 @@ jobs: - name: Upload code coverage if: steps.check.outcome == 'failure' run: | - bash <(curl -s https://codecov.io/bash) -cF python + bash <(curl -s https://codecov.io/bash) -c -F python -F postgres test-sqlite: if: github.event.pull_request.draft == false @@ -190,4 +190,4 @@ jobs: - name: Upload code coverage if: steps.check.outcome == 'failure' run: | - bash <(curl -s https://codecov.io/bash) -cF python + bash <(curl -s https://codecov.io/bash) -c -F python -F sqlite diff --git a/scripts/ci_check_no_file_changes.sh b/scripts/ci_check_no_file_changes.sh index 09e6bd1cf..80a89cc51 100755 --- a/scripts/ci_check_no_file_changes.sh +++ b/scripts/ci_check_no_file_changes.sh @@ -34,10 +34,10 @@ REGEXES=() for CHECK in "$@" do if [[ ${CHECK} == "python" ]]; then - REGEX="(^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt)" + REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt)" echo "Searching for changes in python files" elif [[ ${CHECK} == "frontend" ]]; then - REGEX="(^superset-frontend\/)" + REGEX="(^\.github\/workflows\/.*(frontend|e2e)|^superset-frontend\/)" echo "Searching for changes in frontend files" else echo "Invalid check: \"${CHECK}\". Falling back to exiting with FAILURE code"