From d4291edffada6219fc1c80ba70b9c600901c59f2 Mon Sep 17 00:00:00 2001 From: Jesse Yang Date: Wed, 16 Sep 2020 09:26:14 -0700 Subject: [PATCH] build: optimize eslint import resolver configs (#10901) Use `node` resolver and `node` env for `webpack.config.js`, use `webpack` resolver only for `src`. --- superset-frontend/.eslintrc.js | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js index 906a976ae..8aafe0bad 100644 --- a/superset-frontend/.eslintrc.js +++ b/superset-frontend/.eslintrc.js @@ -27,6 +27,12 @@ module.exports = { env: { browser: true, }, + settings: { + 'import/resolver': 'webpack', + react: { + version: 'detect', + }, + }, plugins: ['prettier', 'react'], overrides: [ { @@ -38,8 +44,13 @@ module.exports = { }, { files: ['webpack*.js'], - rules: { - 'import/no-extraneous-dependencies': 0, + env: { + node: true, + }, + settings: { + 'import/resolver': { + node: {}, + }, }, }, { @@ -241,10 +252,4 @@ module.exports = { 'react/static-property-placement': 0, // disabled temporarily 'prettier/prettier': 'error', }, - settings: { - 'import/resolver': 'webpack', - react: { - version: 'detect', - }, - }, };