From d4672dbfb7e6f39a59eedb7236b1f5676e6fe531 Mon Sep 17 00:00:00 2001 From: "Hugh A. Miles II" Date: Thu, 21 Jun 2018 22:00:50 -0700 Subject: [PATCH] make sure there is a val to be set for existing filters (#5257) --- superset/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/utils.py b/superset/utils.py index 61d5cb63d..ed9968ce8 100644 --- a/superset/utils.py +++ b/superset/utils.py @@ -737,7 +737,7 @@ def merge_extra_filters(form_data): return f['col'] + '__' + f['op'] existing_filters = {} for existing in form_data['filters']: - if existing['col'] is not None: + if existing['col'] is not None and existing['val'] is not None: existing_filters[get_filter_key(existing)] = existing['val'] for filtr in form_data['extra_filters']: # Pull out time filters/options and merge into form data