From d533ce09676921ec2f72e1032bbca0d2a37f65b6 Mon Sep 17 00:00:00 2001
From: John Bodley <4567245+john-bodley@users.noreply.github.com>
Date: Sat, 28 Apr 2018 20:08:09 -0700
Subject: [PATCH] [pylint] prepping for enabling pylint for non-errors (#4884)

---
 .pylintrc                                 | 2 +-
 superset/__init__.py                      | 1 +
 superset/cache_util.py                    | 1 +
 superset/cli.py                           | 1 +
 superset/config.py                        | 1 +
 superset/connectors/base/models.py        | 1 +
 superset/connectors/base/views.py         | 1 +
 superset/connectors/connector_registry.py | 1 +
 superset/connectors/druid/models.py       | 1 +
 superset/connectors/druid/views.py        | 1 +
 superset/connectors/sqla/models.py        | 1 +
 superset/connectors/sqla/views.py         | 1 +
 superset/data/__init__.py                 | 1 +
 superset/dataframe.py                     | 1 +
 superset/db_engine_specs.py               | 1 +
 superset/db_engines/hive.py               | 1 +
 superset/dict_import_export_util.py       | 1 +
 superset/exceptions.py                    | 2 +-
 superset/extract_table_names.py           | 1 +
 superset/forms.py                         | 1 +
 superset/import_util.py                   | 1 +
 superset/jinja_context.py                 | 1 +
 superset/legacy.py                        | 1 +
 superset/migrations/env.py                | 1 +
 superset/models/annotations.py            | 1 +
 superset/models/core.py                   | 1 +
 superset/models/helpers.py                | 1 +
 superset/models/sql_lab.py                | 1 +
 superset/security.py                      | 1 +
 superset/sql_lab.py                       | 1 +
 superset/sql_parse.py                     | 1 +
 superset/stats_logger.py                  | 1 +
 superset/translations/utils.py            | 1 +
 superset/utils.py                         | 1 +
 superset/views/annotations.py             | 1 +
 superset/views/base.py                    | 1 +
 superset/views/core.py                    | 1 +
 superset/views/sql_lab.py                 | 1 +
 superset/views/utils.py                   | 1 +
 superset/viz.py                           | 1 +
 tox.ini                                   | 2 +-
 41 files changed, 41 insertions(+), 3 deletions(-)

diff --git a/.pylintrc b/.pylintrc
index be82d9d54..6e213c483 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -65,7 +65,7 @@ confidence=
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use"--disable=all --enable=classes
 # --disable=W"
-disable=standarderror-builtin,long-builtin,dict-view-method,intern-builtin,suppressed-message,no-absolute-import,unpacking-in-except,apply-builtin,delslice-method,indexing-exception,old-raise-syntax,print-statement,cmp-builtin,reduce-builtin,useless-suppression,coerce-method,input-builtin,cmp-method,raw_input-builtin,nonzero-method,backtick,basestring-builtin,setslice-method,reload-builtin,oct-method,map-builtin-not-iterating,execfile-builtin,old-octal-literal,zip-builtin-not-iterating,buffer-builtin,getslice-method,metaclass-assignment,xrange-builtin,long-suffix,round-builtin,range-builtin-not-iterating,next-method-called,dict-iter-method,parameter-unpacking,unicode-builtin,unichr-builtin,import-star-module-level,raising-string,filter-builtin-not-iterating,old-ne-operator,using-cmp-argument,coerce-builtin,file-builtin,old-division,hex-method,invalid-unary-operand-type
+disable=standarderror-builtin,long-builtin,dict-view-method,intern-builtin,suppressed-message,no-absolute-import,unpacking-in-except,apply-builtin,delslice-method,indexing-exception,old-raise-syntax,print-statement,cmp-builtin,reduce-builtin,useless-suppression,coerce-method,input-builtin,cmp-method,raw_input-builtin,nonzero-method,backtick,basestring-builtin,setslice-method,reload-builtin,oct-method,map-builtin-not-iterating,execfile-builtin,old-octal-literal,zip-builtin-not-iterating,buffer-builtin,getslice-method,metaclass-assignment,xrange-builtin,long-suffix,round-builtin,range-builtin-not-iterating,next-method-called,dict-iter-method,parameter-unpacking,unicode-builtin,unichr-builtin,import-star-module-level,raising-string,filter-builtin-not-iterating,old-ne-operator,using-cmp-argument,coerce-builtin,file-builtin,old-division,hex-method,invalid-unary-operand-type,missing-docstring,too-many-lines,duplicate-code
 
 
 [REPORTS]
diff --git a/superset/__init__.py b/superset/__init__.py
index 929fcfe62..2c3957b7d 100644
--- a/superset/__init__.py
+++ b/superset/__init__.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """Package's main module!"""
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/cache_util.py b/superset/cache_util.py
index be6b6d5d7..d456f6601 100644
--- a/superset/cache_util.py
+++ b/superset/cache_util.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/cli.py b/superset/cli.py
index 6321b5f18..d31e0033f 100755
--- a/superset/cli.py
+++ b/superset/cli.py
@@ -1,5 +1,6 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/config.py b/superset/config.py
index 8a1b10637..530b12689 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """The main config file for Superset
 
 All configuration in this file can be overridden by providing a superset_config
diff --git a/superset/connectors/base/models.py b/superset/connectors/base/models.py
index 9f9522daa..b306299cc 100644
--- a/superset/connectors/base/models.py
+++ b/superset/connectors/base/models.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/connectors/base/views.py b/superset/connectors/base/views.py
index 7d54dcf22..ffec80638 100644
--- a/superset/connectors/base/views.py
+++ b/superset/connectors/base/views.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/connectors/connector_registry.py b/superset/connectors/connector_registry.py
index 79f876acf..efafcb441 100644
--- a/superset/connectors/connector_registry.py
+++ b/superset/connectors/connector_registry.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/connectors/druid/models.py b/superset/connectors/druid/models.py
index 26e3c721a..4ff5e5fa0 100644
--- a/superset/connectors/druid/models.py
+++ b/superset/connectors/druid/models.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 # pylint: disable=invalid-unary-operand-type
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/connectors/druid/views.py b/superset/connectors/druid/views.py
index d5401caf9..82cd46215 100644
--- a/superset/connectors/druid/views.py
+++ b/superset/connectors/druid/views.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
index 56a175124..9d6f57b45 100644
--- a/superset/connectors/sqla/models.py
+++ b/superset/connectors/sqla/models.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py
index 2b8da0e45..2f1ef8d72 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """Views used by the SqlAlchemy connector"""
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/data/__init__.py b/superset/data/__init__.py
index 8ad6c1168..30b588f02 100644
--- a/superset/data/__init__.py
+++ b/superset/data/__init__.py
@@ -1,4 +1,5 @@
 """Loads datasets, dashboards and slices in a new superset instance"""
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/dataframe.py b/superset/dataframe.py
index 38c4fb535..79a2c3d56 100644
--- a/superset/dataframe.py
+++ b/superset/dataframe.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """ Superset wrapper around pandas.DataFrame.
 
 TODO(bkyryliuk): add support for the conventions like: *_dim or dim_*
diff --git a/superset/db_engine_specs.py b/superset/db_engine_specs.py
index 49dd39cd6..e95b4d392 100644
--- a/superset/db_engine_specs.py
+++ b/superset/db_engine_specs.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """Compatibility layer for different database engines
 
 This modules stores logic specific to different database engines. Things
diff --git a/superset/db_engines/hive.py b/superset/db_engines/hive.py
index 4f677faef..9a144e8dd 100644
--- a/superset/db_engines/hive.py
+++ b/superset/db_engines/hive.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/dict_import_export_util.py b/superset/dict_import_export_util.py
index 4f7660ec8..3bdfcd933 100644
--- a/superset/dict_import_export_util.py
+++ b/superset/dict_import_export_util.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/exceptions.py b/superset/exceptions.py
index 569a74b0e..0a27b514a 100644
--- a/superset/exceptions.py
+++ b/superset/exceptions.py
@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/extract_table_names.py b/superset/extract_table_names.py
index 8cac1e1ee..becfdcd80 100644
--- a/superset/extract_table_names.py
+++ b/superset/extract_table_names.py
@@ -1,5 +1,6 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 #
 # Copyright (C) 2016 Andi Albrecht, albrecht.andi@gmail.com
 #
diff --git a/superset/forms.py b/superset/forms.py
index e846d57ca..0537ded3e 100644
--- a/superset/forms.py
+++ b/superset/forms.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """Contains the logic to create cohesive forms on the explore view"""
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/import_util.py b/superset/import_util.py
index 877cb9002..869340490 100644
--- a/superset/import_util.py
+++ b/superset/import_util.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/jinja_context.py b/superset/jinja_context.py
index ce8795acf..b70051528 100644
--- a/superset/jinja_context.py
+++ b/superset/jinja_context.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """Defines the templating context for SQL Lab"""
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/legacy.py b/superset/legacy.py
index 88d757099..7af89b21a 100644
--- a/superset/legacy.py
+++ b/superset/legacy.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """Code related with dealing with legacy / change management"""
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/migrations/env.py b/superset/migrations/env.py
index 07340485f..b9325dc16 100755
--- a/superset/migrations/env.py
+++ b/superset/migrations/env.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import with_statement
 
 import logging
diff --git a/superset/models/annotations.py b/superset/models/annotations.py
index 057aae2be..82619fdd4 100644
--- a/superset/models/annotations.py
+++ b/superset/models/annotations.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """a collection of Annotation-related models"""
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/models/core.py b/superset/models/core.py
index 576f561a2..2ad20faca 100644
--- a/superset/models/core.py
+++ b/superset/models/core.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """A collection of ORM sqlalchemy models for Superset"""
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/models/helpers.py b/superset/models/helpers.py
index 718550bca..1431023be 100644
--- a/superset/models/helpers.py
+++ b/superset/models/helpers.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """a collection of model-related helper classes and functions"""
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/models/sql_lab.py b/superset/models/sql_lab.py
index 5dfd8a663..7e0ccb515 100644
--- a/superset/models/sql_lab.py
+++ b/superset/models/sql_lab.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """A collection of ORM sqlalchemy models for SQL Lab"""
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/security.py b/superset/security.py
index e342b034d..dbc3477bd 100644
--- a/superset/security.py
+++ b/superset/security.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """A set of constants and methods to manage permissions and security"""
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/sql_lab.py b/superset/sql_lab.py
index b470cbf08..b52e9a95f 100644
--- a/superset/sql_lab.py
+++ b/superset/sql_lab.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/sql_parse.py b/superset/sql_parse.py
index 83eac2715..790371ae3 100644
--- a/superset/sql_parse.py
+++ b/superset/sql_parse.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/stats_logger.py b/superset/stats_logger.py
index 3caa38ada..aaab8a11f 100644
--- a/superset/stats_logger.py
+++ b/superset/stats_logger.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/translations/utils.py b/superset/translations/utils.py
index fb4f8404e..e221c4904 100644
--- a/superset/translations/utils.py
+++ b/superset/translations/utils.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/utils.py b/superset/utils.py
index 2d06c48f2..25c4b581d 100644
--- a/superset/utils.py
+++ b/superset/utils.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """Utility functions used across Superset"""
 from __future__ import absolute_import
 from __future__ import division
diff --git a/superset/views/annotations.py b/superset/views/annotations.py
index dea84561d..e2aaf888d 100644
--- a/superset/views/annotations.py
+++ b/superset/views/annotations.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/views/base.py b/superset/views/base.py
index 328789f0d..dc2e48f43 100644
--- a/superset/views/base.py
+++ b/superset/views/base.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/views/core.py b/superset/views/core.py
index b60d91c48..2e01e99b3 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/views/sql_lab.py b/superset/views/sql_lab.py
index aac1d6d2c..faa2f16e4 100644
--- a/superset/views/sql_lab.py
+++ b/superset/views/sql_lab.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/views/utils.py b/superset/views/utils.py
index b1f3fa2db..b02abea27 100644
--- a/superset/views/utils.py
+++ b/superset/views/utils.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 from __future__ import absolute_import
 from __future__ import division
 from __future__ import print_function
diff --git a/superset/viz.py b/superset/viz.py
index 5e6042dc4..64064b383 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=C,R,W
 """This module contains the 'Viz' objects
 
 These objects represent the backend of all the visualizations that
diff --git a/tox.ini b/tox.ini
index d942be1fb..2b2678eae 100644
--- a/tox.ini
+++ b/tox.ini
@@ -67,7 +67,7 @@ deps =
 
 [testenv:pylint]
 commands =
-    pylint superset --errors-only
+    pylint superset
 deps =
     -rrequirements.txt
     -rrequirements-dev.txt