iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: reenable lint for test files (#17979) 

* chore: reenable lint for test files

* fix comments
This commit is contained in:
Yongjie Zhao 2022-01-11 14:22:56 +08:00 committed by GitHub
parent e91b9a678f
commit d8d47ce054
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
superset-frontend/.eslintrc.js
View File

@ -159,6 +159,7 @@ module.exports = {
'*.stories.jsx', '*.stories.jsx',
'fixtures.*', 'fixtures.*',
], ],
excludedFiles: 'cypress-base/cypress/**/*',
plugins: ['jest', 'jest-dom', 'no-only-tests', 'testing-library'], plugins: ['jest', 'jest-dom', 'no-only-tests', 'testing-library'],
env: { env: {
'jest/globals': true, 'jest/globals': true,
@ -180,17 +181,6 @@ module.exports = {
], ],
'no-only-tests/no-only-tests': 'error', 'no-only-tests/no-only-tests': 'error',
'max-classes-per-file': 0, 'max-classes-per-file': 0,
'@typescript-eslint/no-non-null-assertion': 0,
// TODO: disabled temporarily, re-enable after monorepo
'jest/consistent-test-it': 'error',
'jest/expect-expect': 0,
'jest/no-test-prefixes': 0,
'jest/valid-expect-in-promise': 0,
'jest/valid-expect': 0,
'jest/valid-title': 0,
'jest-dom/prefer-to-have-attribute': 0,
'jest-dom/prefer-to-have-text-content': 0,
'jest-dom/prefer-to-have-style': 0,
}, },
}, },
], ],

9
superset-frontend/packages/superset-ui-core/test/dimension/svg/updateTextNode.test.ts
View File

@ -17,6 +17,11 @@
* under the License. * under the License.
*/ */
// do not use react-testing-library in plugins
/* eslint-disable jest-dom/prefer-to-have-attribute */
/* eslint-disable jest-dom/prefer-to-have-text-content */
/* eslint-disable jest-dom/prefer-to-have-style */
import updateTextNode from '../../../src/dimension/svg/updateTextNode'; import updateTextNode from '../../../src/dimension/svg/updateTextNode';
import createTextNode from '../../../src/dimension/svg/createTextNode'; import createTextNode from '../../../src/dimension/svg/createTextNode';
@ -91,3 +96,7 @@ describe('updateTextNode(node, options)', () => {
expect(node.textContent).toEqual(''); expect(node.textContent).toEqual('');
}); });
}); });
/* eslint-enable jest-dom/prefer-to-have-attribute */
/* eslint-enable jest-dom/prefer-to-have-text-content */
/* eslint-enable jest-dom/prefer-to-have-style */