From d93b1afe79ea61bea592e5d4a3b06c5949c4dfcd Mon Sep 17 00:00:00 2001 From: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com> Date: Fri, 9 Oct 2020 18:00:41 +0200 Subject: [PATCH] test: test_cache_logging is not depending on other dashboard (#11213) * Changed test_cache_logging to be idempotent and not depending on other data than tested one * Changed cache uid to be depending on table, not datashource --- tests/core_tests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/core_tests.py b/tests/core_tests.py index 44889d72b..3d9981898 100644 --- a/tests/core_tests.py +++ b/tests/core_tests.py @@ -588,10 +588,10 @@ class TestCore(SupersetTestCase): ) == [{"slice_id": slc.id, "viz_error": None, "viz_status": "success"}] def test_cache_logging(self): - slc = self.get_slice("Girls", db.session) - self.get_json_resp("/superset/warm_up_cache?slice_id={}".format(slc.id)) + girls_slice = self.get_slice("Girls", db.session) + self.get_json_resp("/superset/warm_up_cache?slice_id={}".format(girls_slice.id)) ck = db.session.query(CacheKey).order_by(CacheKey.id.desc()).first() - assert ck.datasource_uid == "3__table" + assert ck.datasource_uid == f"{girls_slice.table.id}__table" def test_shortner(self): self.login(username="admin")