iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: number format should editable when AA in time comparison (#19351)

This commit is contained in:
Yongjie Zhao 2022-03-25 07:58:53 +08:00 committed by GitHub
parent cb0357005e
commit e15573d445
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx
View File

@ -44,6 +44,7 @@ import {
legacyValidateInteger,
validateNonEmpty,
JsonArray,
ComparisionType,
} from '@superset-ui/core';
import {
@ -455,16 +456,12 @@ const y_axis_format: SharedControlConfig<'SelectControl', SelectDefaultOption> =
filterOption: ({ data: option }, search) =>
option.label.includes(search) || option.value.includes(search),
mapStateToProps: state => {
const showWarning =
state.controls?.comparison_type?.value === 'percentage';
const isPercentage =
state.controls?.comparison_type?.value === ComparisionType.Percentage;
return {
warning: showWarning
? t(
'When `Calculation type` is set to "Percentage change", the Y ' +
'Axis Format is forced to `.1%`',
)
: null,
disabled: showWarning,
choices: isPercentage
? D3_FORMAT_OPTIONS.filter(option => option[0].includes('%'))
: D3_FORMAT_OPTIONS,
};
},
};