iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: remove and deprecate old CSS templates endpoints (#28387)

This commit is contained in:
Daniel Vaz Gaspar 2024-05-09 09:38:32 +01:00 committed by GitHub
parent ce668d46cc
commit e1a440fa36
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
superset/views/css_templates.py
View File

@ -15,14 +15,18 @@
# specific language governing permissions and limitations # specific language governing permissions and limitations
# under the License. # under the License.
from flask_appbuilder.api import expose from flask_appbuilder.api import expose
from flask_appbuilder.baseviews import expose_api
from flask_appbuilder.models.sqla.interface import SQLAInterface from flask_appbuilder.models.sqla.interface import SQLAInterface
from flask_appbuilder.security.decorators import has_access from flask_appbuilder.security.decorators import (
from flask_babel import lazy_gettext as _ has_access,
has_access_api,
permission_name,
)
from superset.constants import MODEL_VIEW_RW_METHOD_PERMISSION_MAP, RouteMethod from superset.constants import MODEL_VIEW_RW_METHOD_PERMISSION_MAP, RouteMethod
from superset.models import core as models from superset.models import core as models
from superset.superset_typing import FlaskResponse from superset.superset_typing import FlaskResponse
from superset.views.base import DeleteMixin, SupersetModelView from superset.views.base import DeleteMixin, deprecated, SupersetModelView
class CssTemplateModelView( # pylint: disable=too-many-ancestors class CssTemplateModelView( # pylint: disable=too-many-ancestors
@ -30,21 +34,11 @@ class CssTemplateModelView( # pylint: disable=too-many-ancestors
DeleteMixin, DeleteMixin,
): ):
datamodel = SQLAInterface(models.CssTemplate) datamodel = SQLAInterface(models.CssTemplate)
include_route_methods = RouteMethod.CRUD_SET include_route_methods = RouteMethod.LIST
class_permission_name = "CssTemplate" class_permission_name = "CssTemplate"
method_permission_name = MODEL_VIEW_RW_METHOD_PERMISSION_MAP method_permission_name = MODEL_VIEW_RW_METHOD_PERMISSION_MAP
list_title = _("CSS Templates")
show_title = _("Show CSS Template")
add_title = _("Add CSS Template")
edit_title = _("Edit CSS Template")
list_columns = ["template_name"]
edit_columns = ["template_name", "css"]
add_columns = edit_columns
label_columns = {"template_name": _("Template Name")}
@expose("/list/") @expose("/list/")
@has_access @has_access
def list(self) -> FlaskResponse: def list(self) -> FlaskResponse:
@ -54,8 +48,15 @@ class CssTemplateModelView( # pylint: disable=too-many-ancestors
class CssTemplateAsyncModelView( # pylint: disable=too-many-ancestors class CssTemplateAsyncModelView( # pylint: disable=too-many-ancestors
CssTemplateModelView CssTemplateModelView
): ):
include_route_methods = {RouteMethod.API_READ} include_route_methods = RouteMethod.API_READ
class_permission_name = "CssTemplate" class_permission_name = "CssTemplate"
method_permission_name = MODEL_VIEW_RW_METHOD_PERMISSION_MAP method_permission_name = MODEL_VIEW_RW_METHOD_PERMISSION_MAP
list_columns = ["template_name", "css"] list_columns = ["template_name", "css"]
@expose_api(name="read", url="/api/read", methods=["GET"])
@has_access_api
@permission_name("list")
@deprecated(eol_version="5.0.0")
def api_read(self) -> FlaskResponse:
return self.api_read()