iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-enable rule line-between-class-members (#10862)

This commit is contained in:
Kamil Gabryjelski 2020-09-15 00:41:32 +02:00 committed by GitHub
parent 91b8c8afc9
commit e28f3d6220
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
53 changed files with 277 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/.eslintrc.js
View File

@ -84,7 +84,6 @@ module.exports = {
'jsx-a11y/anchor-is-valid': 0, // disabled temporarily
'jsx-a11y/click-events-have-key-events': 0, // re-enable up for discussion
'jsx-a11y/mouse-events-have-key-events': 0, // re-enable up for discussion
'lines-between-class-members': 0, // disabled temporarily
'new-cap': 0,
'no-bitwise': 0,
'no-continue': 0,
@ -197,7 +196,6 @@ module.exports = {
'jsx-a11y/anchor-is-valid': 0, // disabled temporarily
'jsx-a11y/click-events-have-key-events': 0, // re-enable up for discussion
'jsx-a11y/mouse-events-have-key-events': 0, // re-enable up for discussion
'lines-between-class-members': 0, // disabled temporarily
'new-cap': 0,
'no-bitwise': 0,
'no-continue': 0,

16
superset-frontend/src/CRUD/CollectionTable.tsx
View File

@ -78,6 +78,7 @@ export default class CRUDCollection extends React.PureComponent<
this.renderTableBody = this.renderTableBody.bind(this);
this.changeCollection = this.changeCollection.bind(this);
}
UNSAFE_componentWillReceiveProps(nextProps: CRUDCollectionProps) {
if (nextProps.collection !== this.props.collection) {
this.setState({
@ -85,6 +86,7 @@ export default class CRUDCollection extends React.PureComponent<
});
}
}
onCellChange(id: number, col: string, val: boolean) {
this.changeCollection({
...this.state.collection,
@ -94,6 +96,7 @@ export default class CRUDCollection extends React.PureComponent<
},
});
}
onAddItem() {
if (this.props.itemGenerator) {
let newItem = this.props.itemGenerator();
@ -106,12 +109,14 @@ export default class CRUDCollection extends React.PureComponent<
});
}
}
onFieldsetChange(item: any) {
this.changeCollection({
...this.state.collection,
[item.id]: item,
});
}
getLabel(col: any) {
const { columnLabels } = this.props;
let label = columnLabels && columnLabels[col] ? columnLabels[col] : col;
@ -121,17 +126,20 @@ export default class CRUDCollection extends React.PureComponent<
}
return label;
}
changeCollection(collection: any) {
this.setState({ collection });
if (this.props.onChange) {
this.props.onChange(Object.keys(collection).map(k => collection[k]));
}
}
deleteItem(id: number) {
const newColl = { ...this.state.collection };
delete newColl[id];
this.changeCollection(newColl);
}
effectiveTableColumns() {
const { tableColumns, allowDeletes, expandFieldset } = this.props;
const cols = allowDeletes
@ -139,6 +147,7 @@ export default class CRUDCollection extends React.PureComponent<
: tableColumns;
return expandFieldset ? ['__expand'].concat(cols) : cols;
}
toggleExpand(id: any) {
this.onCellChange(id, '__expanded', false);
this.setState({
@ -148,6 +157,7 @@ export default class CRUDCollection extends React.PureComponent<
},
});
}
renderHeaderRow() {
const cols = this.effectiveTableColumns();
const {
@ -178,6 +188,7 @@ export default class CRUDCollection extends React.PureComponent<
</thead>
);
}
renderExpandableSection(item: any) {
const propsGenerator = () => ({ item, onChange: this.onFieldsetChange });
return recurseReactClone(
@ -186,12 +197,14 @@ export default class CRUDCollection extends React.PureComponent<
propsGenerator,
);
}
renderCell(record: any, col: any) {
const renderer = this.props.itemRenderers && this.props.itemRenderers[col];
const val = record[col];
const onChange = this.onCellChange.bind(this, record.id, col);
return renderer ? renderer(val, onChange, this.getLabel(col), record) : val;
}
renderItem(record: any) {
const {
allowAddItem,
@ -258,6 +271,7 @@ export default class CRUDCollection extends React.PureComponent<
}
return trs;
}
renderEmptyCell() {
return (
<tr>
@ -265,6 +279,7 @@ export default class CRUDCollection extends React.PureComponent<
</tr>
);
}
renderTableBody() {
const data = Object.keys(this.state.collection).map(
k => this.state.collection[k],
@ -274,6 +289,7 @@ export default class CRUDCollection extends React.PureComponent<
: this.renderEmptyCell();
return <tbody>{content}</tbody>;
}
render() {
return (
<div className="CRUD">

2
superset-frontend/src/CRUD/Field.jsx
View File

@ -50,9 +50,11 @@ export default class Field extends React.PureComponent {
super(props);
this.onChange = this.onChange.bind(this);
}
onChange(newValue) {
this.props.onChange(this.props.fieldKey, newValue);
}
render() {
const {
compact,

2
superset-frontend/src/CRUD/Fieldset.jsx
View File

@ -40,12 +40,14 @@ export default class Fieldset extends React.PureComponent {
super(props);
this.onChange = this.onChange.bind(this);
}
onChange(fieldKey, val) {
return this.props.onChange({
...this.props.item,
[fieldKey]: val,
});
}
render() {
const { title } = this.props;
const propExtender = field => ({

10
superset-frontend/src/SqlLab/components/AceEditorWrapper.tsx
View File

@ -83,11 +83,13 @@ class AceEditorWrapper extends React.PureComponent<Props, State> {
};
this.onChange = this.onChange.bind(this);
}
componentDidMount() {
// Making sure no text is selected from previous mount
this.props.actions.queryEditorSetSelectedText(this.props.queryEditor, null);
this.setAutoCompleter(this.props);
}
UNSAFE_componentWillReceiveProps(nextProps: Props) {
if (
!areArraysShallowEqual(this.props.tables, nextProps.tables) ||
@ -103,12 +105,15 @@ class AceEditorWrapper extends React.PureComponent<Props, State> {
this.setState({ sql: nextProps.sql });
}
}
onBlur() {
this.props.onBlur(this.state.sql);
}
onAltEnter() {
this.props.onBlur(this.state.sql);
}
onEditorLoad(editor: any) {
editor.commands.addCommand({
name: 'runQuery',
@ -140,10 +145,12 @@ class AceEditorWrapper extends React.PureComponent<Props, State> {
}
});
}
onChange(text: string) {
this.setState({ sql: text });
this.props.onChange(text);
}
getCompletions(
aceEditor: any,
session: any,
@ -180,6 +187,7 @@ class AceEditorWrapper extends React.PureComponent<Props, State> {
});
callback(null, words);
}
setAutoCompleter(props: Props) {
// Loading schema, table and column names as auto-completable words
const schemas = props.schemas || [];
@ -236,6 +244,7 @@ class AceEditorWrapper extends React.PureComponent<Props, State> {
}
});
}
getAceAnnotations() {
const { validationResult } = this.props.queryEditor;
const resultIsReady = validationResult && validationResult.completed;
@ -250,6 +259,7 @@ class AceEditorWrapper extends React.PureComponent<Props, State> {
}
return [];
}
render() {
return (
<AceEditor

8
superset-frontend/src/SqlLab/components/App.jsx
View File

@ -48,12 +48,14 @@ class App extends React.PureComponent {
{ trailing: false },
);
}
componentDidMount() {
/* eslint-disable react/no-did-mount-set-state */
this.setState({ contentHeight: this.getHeight() });
window.addEventListener('hashchange', this.onHashChanged.bind(this));
window.addEventListener('resize', this.handleResize.bind(this));
}
componentDidUpdate() {
if (
this.props.localStorageUsageInKilobytes >=
@ -64,13 +66,16 @@ class App extends React.PureComponent {
);
}
}
componentWillUnmount() {
window.removeEventListener('hashchange', this.onHashChanged.bind(this));
window.removeEventListener('resize', this.handleResize.bind(this));
}
onHashChanged() {
this.setState({ hash: window.location.hash });
}
getHeight() {
const warningEl = $('#navbar-warning');
const tabsEl = $('.nav-tabs');
@ -96,6 +101,7 @@ class App extends React.PureComponent {
alertHeight
}px`;
}
showLocalStorageUsageWarning(currentUsage) {
this.props.actions.addDangerToast(
t(
@ -109,9 +115,11 @@ class App extends React.PureComponent {
),
);
}
handleResize() {
this.setState({ contentHeight: this.getHeight() });
}
render() {
let content;
if (this.state.hash) {

3
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton.jsx
View File

@ -47,6 +47,7 @@ class ExploreCtasResultsButton extends React.PureComponent {
this.visualize = this.visualize.bind(this);
this.onClick = this.onClick.bind(this);
}
onClick() {
this.visualize();
}
@ -59,6 +60,7 @@ class ExploreCtasResultsButton extends React.PureComponent {
templateParams: this.props.templateParams,
};
}
visualize() {
this.props.actions
.createCtasDatasource(this.buildVizOptions())
@ -85,6 +87,7 @@ class ExploreCtasResultsButton extends React.PureComponent {
);
});
}
render() {
return (
<>

10
superset-frontend/src/SqlLab/components/ExploreResultsButton.jsx
View File

@ -52,6 +52,7 @@ class ExploreResultsButton extends React.PureComponent {
this,
);
}
onClick() {
const { timeout } = this.props;
const msg = this.renderInvalidColumnMessage();
@ -85,6 +86,7 @@ class ExploreResultsButton extends React.PureComponent {
this.visualize();
}
}
getColumns() {
const { props } = this;
if (
@ -96,11 +98,13 @@ class ExploreResultsButton extends React.PureComponent {
}
return [];
}
getQueryDuration() {
return moment
.duration(this.props.query.endDttm - this.props.query.startDttm)
.asSeconds();
}
getInvalidColumns() {
const re1 = /__\d+$/; // duplicate column name pattern
const re2 = /^__timestamp/i; // reserved temporal column alias
@ -109,6 +113,7 @@ class ExploreResultsButton extends React.PureComponent {
.map(col => col.name)
.filter(col => re1.test(col) || re2.test(col));
}
datasourceName() {
const { query } = this.props;
const uniqueId = shortid.generate();
@ -119,6 +124,7 @@ class ExploreResultsButton extends React.PureComponent {
}
return datasourceName;
}
buildVizOptions() {
const { schema, sql, dbId, templateParams } = this.props.query;
return {
@ -130,6 +136,7 @@ class ExploreResultsButton extends React.PureComponent {
columns: this.getColumns(),
};
}
visualize() {
this.props.actions
.createDatasource(this.buildVizOptions())
@ -158,6 +165,7 @@ class ExploreResultsButton extends React.PureComponent {
);
});
}
renderTimeoutWarning() {
return (
<Alert bsStyle="warning">
@ -181,6 +189,7 @@ class ExploreResultsButton extends React.PureComponent {
</Alert>
);
}
renderInvalidColumnMessage() {
const invalidColumns = this.getInvalidColumns();
if (invalidColumns.length === 0) {
@ -200,6 +209,7 @@ class ExploreResultsButton extends React.PureComponent {
</div>
);
}
render() {
const allowsSubquery =
this.props.database && this.props.database.allows_subquery;

4
superset-frontend/src/SqlLab/components/HighlightedSql.jsx
View File

@ -50,6 +50,7 @@ class HighlightedSql extends React.Component {
modalBody: null,
};
}
shrinkSql() {
const ssql = this.props.sql || '';
let lines = ssql.split('\n');
@ -66,6 +67,7 @@ class HighlightedSql extends React.Component {
})
.join('\n');
}
triggerNode() {
const shownSql = this.props.shrink
? this.shrinkSql(this.props.sql)
@ -76,6 +78,7 @@ class HighlightedSql extends React.Component {
</SyntaxHighlighter>
);
}
generateModal() {
let rawSql;
if (this.props.rawSql && this.props.rawSql !== this.props.sql) {
@ -100,6 +103,7 @@ class HighlightedSql extends React.Component {
),
});
}
render() {
return (
<ModalTrigger

8
superset-frontend/src/SqlLab/components/QueryAutoRefresh.jsx
View File

@ -36,17 +36,21 @@ class QueryAutoRefresh extends React.PureComponent {
offline: props.offline,
};
}
UNSAFE_componentWillMount() {
this.startTimer();
}
componentDidUpdate(prevProps) {
if (prevProps.offline !== this.state.offline) {
this.props.actions.setUserOffline(this.state.offline);
}
}
componentWillUnmount() {
this.stopTimer();
}
shouldCheckForQueries() {
// if there are started or running queries, this method should return true
const { queries } = this.props;
@ -58,15 +62,18 @@ class QueryAutoRefresh extends React.PureComponent {
q => isQueryRunning(q) && now - q.startDttm < MAX_QUERY_AGE_TO_POLL,
);
}
startTimer() {
if (!this.timer) {
this.timer = setInterval(this.stopwatch.bind(this), QUERY_UPDATE_FREQ);
}
}
stopTimer() {
clearInterval(this.timer);
this.timer = null;
}
stopwatch() {
// only poll /superset/queries/ if there are started or running queries
if (this.shouldCheckForQueries()) {
@ -89,6 +96,7 @@ class QueryAutoRefresh extends React.PureComponent {
this.setState({ offline: false });
}
}
render() {
return null;
}

4
superset-frontend/src/SqlLab/components/QueryTable.jsx
View File

@ -60,15 +60,19 @@ class QueryTable extends React.PureComponent {
openQueryInNewTab(query) {
this.props.actions.cloneQueryToNewTab(query, true);
}
openAsyncResults(query, displayLimit) {
this.props.actions.fetchQueryResults(query, displayLimit);
}
clearQueryResults(query) {
this.props.actions.clearQueryResults(query);
}
removeQuery(query) {
this.props.actions.removeQuery(query);
}
render() {
const data = this.props.queries
.map(query => {

11
superset-frontend/src/SqlLab/components/ResultSet.tsx
View File

@ -86,10 +86,12 @@ export default class ResultSet extends React.PureComponent<
this,
);
}
componentDidMount() {
// only do this the first time the component is rendered/mounted
this.reRunQueryIfSessionTimeoutErrorOnMount();
}
UNSAFE_componentWillReceiveProps(nextProps: ResultSetProps) {
// when new results comes in, save them locally and clear in store
if (
@ -110,9 +112,11 @@ export default class ResultSet extends React.PureComponent<
this.fetchResults(nextProps.query);
}
}
clearQueryResults(query: Query) {
this.props.actions.clearQueryResults(query);
}
popSelectStar(tempSchema: string | null, tempTable: string) {
const qe = {
id: shortid.generate(),
@ -123,20 +127,25 @@ export default class ResultSet extends React.PureComponent<
};
this.props.actions.addQueryEditor(qe);
}
toggleExploreResultsButton() {
this.setState({
showExploreResultsButton: !this.state.showExploreResultsButton,
});
}
changeSearch(event: React.ChangeEvent<HTMLInputElement>) {
this.setState({ searchText: event.target.value });
}
fetchResults(query: Query) {
this.props.actions.fetchQueryResults(query, this.props.displayLimit);
}
reFetchQueryResults(query: Query) {
this.props.actions.reFetchQueryResults(query);
}
reRunQueryIfSessionTimeoutErrorOnMount() {
const { query } = this.props;
if (
@ -146,6 +155,7 @@ export default class ResultSet extends React.PureComponent<
this.props.actions.runQuery(query, true);
}
}
renderControls() {
if (this.props.search || this.props.visualize || this.props.csv) {
let { data } = this.props.query.results;
@ -198,6 +208,7 @@ export default class ResultSet extends React.PureComponent<
}
return <div className="noControls" />;
}
render() {
const { query } = this.props;
const height = Math.max(

10
superset-frontend/src/SqlLab/components/SaveQuery.jsx
View File

@ -55,23 +55,29 @@ class SaveQuery extends React.PureComponent {
this.onLabelChange = this.onLabelChange.bind(this);
this.onDescriptionChange = this.onDescriptionChange.bind(this);
}
onSave() {
this.props.onSave(this.queryPayload());
this.close();
}
onUpdate() {
this.props.onUpdate(this.queryPayload());
this.close();
}
onCancel() {
this.close();
}
onLabelChange(e) {
this.setState({ label: e.target.value });
}
onDescriptionChange(e) {
this.setState({ description: e.target.value });
}
queryPayload() {
return {
...this.props.query,
@ -79,12 +85,15 @@ class SaveQuery extends React.PureComponent {
description: this.state.description,
};
}
close() {
if (this.saveModal) this.saveModal.close();
}
toggleSave() {
this.setState({ showSave: !this.state.showSave });
}
renderModalBody() {
const isSaved = !!this.props.query.remoteId;
return (
@ -157,6 +166,7 @@ class SaveQuery extends React.PureComponent {
</FormGroup>
);
}
render() {
return (
<span className="SaveQuery">

7
superset-frontend/src/SqlLab/components/ScheduleQueryButton.jsx
View File

@ -106,6 +106,7 @@ class ScheduleQueryButton extends React.PureComponent {
this.onLabelChange = this.onLabelChange.bind(this);
this.onDescriptionChange = this.onDescriptionChange.bind(this);
}
onSchedule({ formData }) {
const query = {
label: this.state.label,
@ -118,18 +119,23 @@ class ScheduleQueryButton extends React.PureComponent {
this.props.onSchedule(query);
this.saveModal.close();
}
onCancel() {
this.saveModal.close();
}
onLabelChange(e) {
this.setState({ label: e.target.value });
}
onDescriptionChange(e) {
this.setState({ description: e.target.value });
}
toggleSchedule() {
this.setState({ showSchedule: !this.state.showSchedule });
}
renderModalBody() {
return (
<FormGroup>
@ -181,6 +187,7 @@ class ScheduleQueryButton extends React.PureComponent {
</FormGroup>
);
}
render() {
return (
<span className="ScheduleQueryButton">

4
superset-frontend/src/SqlLab/components/SouthPane.jsx
View File

@ -68,19 +68,23 @@ export class SouthPane extends React.PureComponent {
this.getSouthPaneHeight = this.getSouthPaneHeight.bind(this);
this.switchTab = this.switchTab.bind(this);
}
UNSAFE_componentWillReceiveProps() {
// south pane expands the entire height of the tab content on mount
this.setState({ height: this.getSouthPaneHeight() });
}
// One layer of abstraction for easy spying in unit tests
getSouthPaneHeight() {
return this.southPaneRef.current
? this.southPaneRef.current.clientHeight
: 0;
}
switchTab(id) {
this.props.actions.setActiveSouthPaneTab(id);
}
render() {
if (this.props.offline) {
return (

26
superset-frontend/src/SqlLab/components/SqlEditor.jsx
View File

@ -128,6 +128,7 @@ class SqlEditor extends React.PureComponent {
WINDOW_RESIZE_THROTTLE_MS,
);
}
UNSAFE_componentWillMount() {
if (this.state.autorun) {
this.setState({ autorun: false });
@ -135,6 +136,7 @@ class SqlEditor extends React.PureComponent {
this.startQuery();
}
}
componentDidMount() {
// We need to measure the height of the sql editor post render to figure the height of
// the south pane so it gets rendered properly
@ -143,14 +145,17 @@ class SqlEditor extends React.PureComponent {
window.addEventListener('resize', this.handleWindowResize);
}
componentWillUnmount() {
window.removeEventListener('resize', this.handleWindowResize);
}
onResizeStart() {
// Set the heights on the ace editor and the ace content area after drag starts
// to smooth out the visual transition to the new heights when drag ends
document.getElementsByClassName('ace_content')[0].style.height = '100%';
}
onResizeEnd([northPercent, southPercent]) {
this.setState({ northPercent, southPercent });
@ -162,6 +167,7 @@ class SqlEditor extends React.PureComponent {
);
}
}
onSqlChanged(sql) {
this.setState({ sql });
this.setQueryEditorSqlWithDebounce(sql);
@ -171,12 +177,14 @@ class SqlEditor extends React.PureComponent {
this.requestValidation();
}
}
// One layer of abstraction for easy spying in unit tests
getSqlEditorHeight() {
return this.sqlEditorRef.current
? this.sqlEditorRef.current.clientHeight - SQL_EDITOR_PADDING * 2
: 0;
}
// Return the heights for the ace editor and the south pane as an object
// given the height of the sql editor, north pane percent and south pane percent.
getAceEditorAndSouthPaneHeights(height, northPercent, southPercent) {
@ -190,6 +198,7 @@ class SqlEditor extends React.PureComponent {
(SQL_EDITOR_GUTTER_HEIGHT / 2 + SQL_EDITOR_GUTTER_MARGIN),
};
}
getHotkeyConfig() {
return [
{
@ -224,15 +233,18 @@ class SqlEditor extends React.PureComponent {
},
];
}
setQueryEditorSql(sql) {
this.props.actions.queryEditorSetSql(this.props.queryEditor, sql);
}
setQueryLimit(queryLimit) {
this.props.actions.queryEditorSetQueryLimit(
this.props.queryEditor,
queryLimit,
);
}
getQueryCostEstimate() {
if (this.props.database) {
const qe = this.props.queryEditor;
@ -246,12 +258,15 @@ class SqlEditor extends React.PureComponent {
this.props.actions.estimateQueryCost(query);
}
}
handleToggleAutocompleteEnabled = () => {
this.setState({ autocompleteEnabled: !this.state.autocompleteEnabled });
};
handleWindowResize() {
this.setState({ height: this.getSqlEditorHeight() });
}
elementStyle(dimension, elementSize, gutterSize) {
return {
[dimension]: `calc(${elementSize}% - ${
@ -259,6 +274,7 @@ class SqlEditor extends React.PureComponent {
}px)`,
};
}
requestValidation() {
if (this.props.database) {
const qe = this.props.queryEditor;
@ -272,6 +288,7 @@ class SqlEditor extends React.PureComponent {
this.props.actions.validateQuery(query);
}
}
canValidateQuery() {
// Check whether or not we can validate the current query based on whether
// or not the backend has a validator configured for it.
@ -281,11 +298,13 @@ class SqlEditor extends React.PureComponent {
}
return false;
}
runQuery() {
if (this.props.database) {
this.startQuery();
}
}
startQuery(ctas = false, ctas_method = CtasEnum.TABLE) {
const qe = this.props.queryEditor;
const query = {
@ -307,6 +326,7 @@ class SqlEditor extends React.PureComponent {
this.props.actions.runQuery(query);
this.props.actions.setActiveSouthPaneTab('Results');
}
stopQuery() {
if (
this.props.latestQuery &&
@ -315,15 +335,19 @@ class SqlEditor extends React.PureComponent {
this.props.actions.postStopQuery(this.props.latestQuery);
}
}
createTableAs() {
this.startQuery(true, CtasEnum.TABLE);
}
createViewAs() {
this.startQuery(true, CtasEnum.VIEW);
}
ctasChanged(event) {
this.setState({ ctas: event.target.value });
}
queryPane() {
const hotkeys = this.getHotkeyConfig();
const {
@ -376,6 +400,7 @@ class SqlEditor extends React.PureComponent {
</Split>
);
}
renderEditorBottomBar(hotkeys) {
let ctasControls;
if (
@ -560,6 +585,7 @@ class SqlEditor extends React.PureComponent {
</div>
);
}
render() {
return (
<div ref={this.sqlEditorRef} className="SqlEditor">

8
superset-frontend/src/SqlLab/components/SqlEditorLeftBar.jsx
View File

@ -50,27 +50,33 @@ export default class SqlEditorLeftBar extends React.PureComponent {
this.getDbList = this.getDbList.bind(this);
this.onTableChange = this.onTableChange.bind(this);
}
onSchemaChange(schema) {
this.props.actions.queryEditorSetSchema(this.props.queryEditor, schema);
}
onSchemasLoad(schemas) {
this.props.actions.queryEditorSetSchemaOptions(
this.props.queryEditor,
schemas,
);
}
onTablesLoad(tables) {
this.props.actions.queryEditorSetTableOptions(
this.props.queryEditor,
tables,
);
}
onDbChange(db) {
this.props.actions.queryEditorSetDb(this.props.queryEditor, db.id);
}
onTableChange(tableName, schemaName) {
this.props.actions.addTable(this.props.queryEditor, tableName, schemaName);
}
getDbList(dbs) {
this.props.actions.setDatabases(dbs);
}
@ -92,6 +98,7 @@ export default class SqlEditorLeftBar extends React.PureComponent {
resetState() {
this.props.actions.resetState();
}
changeTable(tableOpt) {
if (!tableOpt) {
return;
@ -105,6 +112,7 @@ export default class SqlEditorLeftBar extends React.PureComponent {
closePopover(ref) {
this.refs[ref].hide();
}
render() {
const shouldShowReset = window.location.search === '?reset=1';
const tableMetaDataHeight = this.props.height - 130; // 130 is the height of the selects above

12
superset-frontend/src/SqlLab/components/TabbedSqlEditors.jsx
View File

@ -75,6 +75,7 @@ class TabbedSqlEditors extends React.PureComponent {
);
this.duplicateQueryEditor = this.duplicateQueryEditor.bind(this);
}
componentDidMount() {
// migrate query editor and associated tables state to server
if (isFeatureEnabled(FeatureFlag.SQLLAB_BACKEND_PERSISTENCE)) {
@ -168,6 +169,7 @@ class TabbedSqlEditors extends React.PureComponent {
}
}
}
UNSAFE_componentWillReceiveProps(nextProps) {
const nextActiveQeId =
nextProps.tabHistory[nextProps.tabHistory.length - 1];
@ -201,11 +203,13 @@ class TabbedSqlEditors extends React.PureComponent {
this.setState({ dataPreviewQueries });
}
}
popNewTab() {
queryCount += 1;
// Clean the url in browser history
window.history.replaceState({}, document.title, this.state.sqlLabUrl);
}
renameTab(qe) {
/* eslint no-alert: 0 */
const newTitle = prompt(t('Enter a new title for the tab'));
@ -213,6 +217,7 @@ class TabbedSqlEditors extends React.PureComponent {
this.props.actions.queryEditorSetTitle(qe, newTitle);
}
}
activeQueryEditor() {
if (this.props.tabHistory.length === 0) {
return this.props.queryEditors[0];
@ -220,6 +225,7 @@ class TabbedSqlEditors extends React.PureComponent {
const qeid = this.props.tabHistory[this.props.tabHistory.length - 1];
return this.props.queryEditors.find(qe => qe.id === qeid) || null;
}
newQueryEditor() {
queryCount += 1;
const activeQueryEditor = this.activeQueryEditor();
@ -244,6 +250,7 @@ class TabbedSqlEditors extends React.PureComponent {
};
this.props.actions.addQueryEditor(qe);
}
handleSelect(key) {
if (key === 'add_tab') {
this.newQueryEditor();
@ -258,20 +265,25 @@ class TabbedSqlEditors extends React.PureComponent {
}
}
}
removeQueryEditor(qe) {
this.props.actions.removeQueryEditor(qe);
}
removeAllOtherQueryEditors(cqe) {
this.props.queryEditors.forEach(
qe => qe !== cqe && this.removeQueryEditor(qe),
);
}
duplicateQueryEditor(qe) {
this.props.actions.cloneQueryToNewTab(qe, false);
}
toggleLeftBar() {
this.setState({ hideLeftBar: !this.state.hideLeftBar });
}
render() {
const editors = this.props.queryEditors.map((qe, i) => {
const isSelected =

4
superset-frontend/src/SqlLab/components/TableElement.jsx
View File

@ -83,6 +83,7 @@ class TableElement extends React.PureComponent {
this.setState({ expanded: false });
this.props.actions.removeDataPreview(this.props.table);
}
toggleSortColumns() {
this.setState({ sortColumns: !this.state.sortColumns });
}
@ -127,6 +128,7 @@ class TableElement extends React.PureComponent {
}
return header;
}
renderControls() {
let keyLink;
const { table } = this.props;
@ -190,6 +192,7 @@ class TableElement extends React.PureComponent {
</ButtonGroup>
);
}
renderHeader() {
const { table } = this.props;
return (
@ -228,6 +231,7 @@ class TableElement extends React.PureComponent {
</div>
);
}
renderBody() {
const { table } = this.props;
let cols;

5
superset-frontend/src/SqlLab/components/TemplateParamsEditor.jsx
View File

@ -56,9 +56,11 @@ export default class TemplateParamsEditor extends React.Component {
};
this.onChange = this.onChange.bind(this);
}
componentDidMount() {
this.onChange(this.state.codeText);
}
onChange(value) {
const codeText = value;
let isValid;
@ -75,6 +77,7 @@ export default class TemplateParamsEditor extends React.Component {
this.props.onChange(newValue);
}
}
renderDoc() {
return (
<p>
@ -96,6 +99,7 @@ export default class TemplateParamsEditor extends React.Component {
</p>
);
}
renderModalBody() {
return (
<div>
@ -115,6 +119,7 @@ export default class TemplateParamsEditor extends React.Component {
</div>
);
}
render() {
const paramCount = this.state.parsedJSON
? Object.keys(this.state.parsedJSON).length

5
superset-frontend/src/components/FilterableTable/FilterableTable.tsx
View File

@ -124,10 +124,15 @@ export default class FilterableTable extends PureComponent<
};
list: List<Datum>;
complexColumns: Record<string, boolean>;
widthsForColumnsByKey: Record<string, number>;
totalTableWidth: number;
totalTableHeight: number;
container: React.RefObject<HTMLDivElement>;
constructor(props: FilterableTableProps) {

1
superset-frontend/src/components/FlashProvider.tsx
View File

@ -48,6 +48,7 @@ class FlashProvider extends React.PureComponent<Props> {
}
});
}
render() {
return this.props.children;
}

2
superset-frontend/src/components/Hotkeys.jsx
View File

@ -45,6 +45,7 @@ export default class Hotkeys extends React.PureComponent {
}
});
}
renderPopover() {
const { header, hotkeys } = this.props;
return (
@ -70,6 +71,7 @@ export default class Hotkeys extends React.PureComponent {
</Popover>
);
}
render() {
return (
<OverlayTrigger

1
superset-frontend/src/components/ModalTrigger.jsx
View File

@ -69,6 +69,7 @@ export default class ModalTrigger extends React.Component {
this.props.beforeOpen();
this.setState(() => ({ showModal: true }));
}
renderModal() {
return (
<Modal

4
superset-frontend/src/components/Pagination.tsx
View File

@ -124,9 +124,13 @@ const PaginationList = styled.ul`
export default class Pagination extends PureComponent<PaginationProps> {
static Next = Next;
static Prev = Prev;
static Item = Item;
static Ellipsis = Ellipsis;
render() {
return <PaginationList> {this.props.children}</PaginationList>;
}

1
superset-frontend/src/dashboard/components/BuilderComponentPane.jsx
View File

@ -64,6 +64,7 @@ class BuilderComponentPane extends React.PureComponent {
</Tabs>
);
}
render() {
const { topOffset } = this.props;
return (

1
superset-frontend/src/dashboard/components/ColorSchemeControlWrapper.jsx
View File

@ -41,6 +41,7 @@ class ColorSchemeControlWrapper extends React.PureComponent {
this.choices = this.categoricalSchemeRegistry.keys().map(s => [s, s]);
this.schemes = this.categoricalSchemeRegistry.getMap();
}
setHover(hovered) {
this.setState({ hovered });
}

1
superset-frontend/src/dashboard/components/PropertiesModal.jsx
View File

@ -80,6 +80,7 @@ class PropertiesModal extends React.PureComponent {
componentDidMount() {
this.fetchDashboardDetails();
}
onColorSchemeChange(value) {
this.updateFormState('colorScheme', value);
}

1
superset-frontend/src/datasource/DatasourceEditor.jsx
View File

@ -280,6 +280,7 @@ export class DatasourceEditor extends React.PureComponent {
};
this.props.onChange(datasource, this.state.errors);
}
onDatasourceChange(datasource) {
this.setState({ datasource }, this.validateAndChange);
}

3
superset-frontend/src/explore/components/Control.jsx
View File

@ -68,12 +68,15 @@ export default class Control extends React.PureComponent {
this.onMouseEnter = this.setHover.bind(this, true);
this.onMouseLeave = this.setHover.bind(this, false);
}
onChange(value, errors) {
this.props.actions.setControlValue(this.props.name, value, errors);
}
setHover(hovered) {
this.setState({ hovered });
}
render() {
const { type, hidden } = this.props;
if (!type) return null;

1
superset-frontend/src/explore/components/ControlHeader.jsx
View File

@ -75,6 +75,7 @@ export default class ControlHeader extends React.Component {
}
return null;
}
render() {
if (!this.props.label) {
return null;

2
superset-frontend/src/explore/components/ControlPanelSection.jsx
View File

@ -42,9 +42,11 @@ export default class ControlPanelSection extends React.Component {
this.state = { expanded: this.props.startExpanded };
this.toggleExpand = this.toggleExpand.bind(this);
}
toggleExpand() {
this.setState({ expanded: !this.state.expanded });
}
renderHeader() {
const { label, description, hasErrors } = this.props;
return (

10
superset-frontend/src/explore/components/DisplayQueryButton.jsx
View File

@ -90,6 +90,7 @@ export class DisplayQueryButton extends React.PureComponent {
this.openPropertiesModal = this.openPropertiesModal.bind(this);
this.closePropertiesModal = this.closePropertiesModal.bind(this);
}
beforeOpen(resultType) {
this.setState({ isLoading: true });
@ -118,18 +119,23 @@ export class DisplayQueryButton extends React.PureComponent {
});
});
}
changeFilterText(event) {
this.setState({ filterText: event.target.value });
}
redirectSQLLab() {
this.props.onOpenInEditor(this.props.latestQueryFormData);
}
openPropertiesModal() {
this.setState({ isPropertiesModalOpen: true });
}
closePropertiesModal() {
this.setState({ isPropertiesModalOpen: false });
}
renderQueryModalBody() {
if (this.state.isLoading) {
return <Loading />;
@ -157,6 +163,7 @@ export class DisplayQueryButton extends React.PureComponent {
}
return null;
}
renderResultsModalBody() {
if (this.state.isLoading) {
return <Loading />;
@ -172,6 +179,7 @@ export class DisplayQueryButton extends React.PureComponent {
}
return null;
}
renderDataTable(data) {
return (
<div style={{ overflow: 'auto' }}>
@ -213,6 +221,7 @@ export class DisplayQueryButton extends React.PureComponent {
</div>
);
}
renderSamplesModalBody() {
if (this.state.isLoading) {
return <Loading />;
@ -225,6 +234,7 @@ export class DisplayQueryButton extends React.PureComponent {
}
return null;
}
render() {
const { animation, chartHeight, slice } = this.props;
return (

1
superset-frontend/src/explore/components/EmbedCodeButton.jsx
View File

@ -144,6 +144,7 @@ export default class EmbedCodeButton extends React.Component {
</Popover>
);
}
render() {
return (
<OverlayTrigger

3
superset-frontend/src/explore/components/ExploreViewContainer.jsx
View File

@ -283,12 +283,14 @@ class ExploreViewContainer extends React.Component {
toggleModal() {
this.setState({ showModal: !this.state.showModal });
}
hasErrors() {
const ctrls = this.props.controls;
return Object.keys(ctrls).some(
k => ctrls[k].validationErrors && ctrls[k].validationErrors.length > 0,
);
}
renderErrorMessage() {
// Returns an error message as a node if any errors are in the store
const errors = [];
@ -311,6 +313,7 @@ class ExploreViewContainer extends React.Component {
}
return errorMessage;
}
renderChartContainer() {
return (
<ExploreChartPanel

7
superset-frontend/src/explore/components/SaveModal.jsx
View File

@ -55,6 +55,7 @@ class SaveModal extends React.Component {
this.onDashboardSelectChange = this.onDashboardSelectChange.bind(this);
this.onSliceNameChange = this.onSliceNameChange.bind(this);
}
componentDidMount() {
this.props.actions.fetchDashboards(this.props.userId).then(() => {
const dashboardIds = this.props.dashboards.map(
@ -72,18 +73,22 @@ class SaveModal extends React.Component {
}
});
}
onSliceNameChange(event) {
this.setState({ newSliceName: event.target.value });
}
onDashboardSelectChange(event) {
const newDashboardName = event ? event.label : null;
const saveToDashboardId =
event && typeof event.value === 'number' ? event.value : null;
this.setState({ saveToDashboardId, newDashboardName });
}
changeAction(action) {
this.setState({ action });
}
saveOrOverwrite(gotodash) {
this.setState({ alert: null });
this.props.actions.removeSaveModalAlert();
@ -117,12 +122,14 @@ class SaveModal extends React.Component {
});
this.props.onHide();
}
removeAlert() {
if (this.props.alert) {
this.props.actions.removeSaveModalAlert();
}
this.setState({ alert: null });
}
render() {
return (
<Modal show onHide={this.props.onHide}>

4
superset-frontend/src/explore/components/controls/BoundsControl.jsx
View File

@ -45,6 +45,7 @@ export default class BoundsControl extends React.Component {
this.onMinChange = this.onMinChange.bind(this);
this.onMaxChange = this.onMaxChange.bind(this);
}
onMinChange(event) {
this.setState(
{
@ -53,6 +54,7 @@ export default class BoundsControl extends React.Component {
this.onChange,
);
}
onMaxChange(event) {
this.setState(
{
@ -61,6 +63,7 @@ export default class BoundsControl extends React.Component {
this.onChange,
);
}
onChange() {
const mm = this.state.minMax;
const errors = [];
@ -76,6 +79,7 @@ export default class BoundsControl extends React.Component {
this.props.onChange([null, null], errors);
}
}
render() {
return (
<div>

2
superset-frontend/src/explore/components/controls/CheckboxControl.jsx
View File

@ -38,6 +38,7 @@ export default class CheckboxControl extends React.Component {
onChange() {
this.props.onChange(!this.props.value);
}
renderCheckbox() {
return (
<Checkbox
@ -47,6 +48,7 @@ export default class CheckboxControl extends React.Component {
/>
);
}
render() {
if (this.props.label) {
return (

6
superset-frontend/src/explore/components/controls/CollectionControl.jsx
View File

@ -68,19 +68,24 @@ export default class CollectionControl extends React.Component {
super(props);
this.onAdd = this.onAdd.bind(this);
}
onChange(i, value) {
Object.assign(this.props.value[i], value);
this.props.onChange(this.props.value);
}
onAdd() {
this.props.onChange(this.props.value.concat([this.props.itemGenerator()]));
}
onSortEnd({ oldIndex, newIndex }) {
this.props.onChange(arrayMove(this.props.value, oldIndex, newIndex));
}
removeItem(i) {
this.props.onChange(this.props.value.filter((o, ix) => i !== ix));
}
renderList() {
if (this.props.value.length === 0) {
return <div className="text-muted">{this.props.placeholder}</div>;
@ -126,6 +131,7 @@ export default class CollectionControl extends React.Component {
</SortableListGroup>
);
}
render() {
return (
<div className="CollectionControl">

3
superset-frontend/src/explore/components/controls/ColorPickerControl.jsx
View File

@ -69,9 +69,11 @@ export default class ColorPickerControl extends React.Component {
super(props);
this.onChange = this.onChange.bind(this);
}
onChange(col) {
this.props.onChange(col.rgb);
}
renderPopover() {
const presetColors = getCategoricalSchemeRegistry()
.get()
@ -86,6 +88,7 @@ export default class ColorPickerControl extends React.Component {
</Popover>
);
}
render() {
const c = this.props.value || { r: 0, g: 0, b: 0, a: 0 };
const colStyle = {

11
superset-frontend/src/explore/components/controls/DateFilterControl.jsx
View File

@ -238,11 +238,13 @@ class DateFilterControl extends React.Component {
componentWillUnmount() {
document.removeEventListener('click', this.handleClick);
}
onEnter(event) {
if (event.key === 'Enter') {
this.close();
}
}
setCustomRange(key, value) {
const updatedState = { ...this.state, [key]: value };
const combinedValue = [
@ -252,6 +254,7 @@ class DateFilterControl extends React.Component {
].join(' ');
this.setState(getStateFromCustomRange(combinedValue));
}
setCustomStartEnd(key, value) {
const closeCalendar =
(key === 'since' && this.state.sinceViewMode === 'days') ||
@ -265,9 +268,11 @@ class DateFilterControl extends React.Component {
untilViewMode: closeCalendar ? 'days' : this.state.untilViewMode,
});
}
setTypeCustomRange() {
this.setState({ type: TYPES.CUSTOM_RANGE });
}
setTypeCustomStartEnd() {
this.setState({ type: TYPES.CUSTOM_START_END });
}
@ -325,18 +330,21 @@ class DateFilterControl extends React.Component {
this.refs.trigger.hide();
this.setState({ showSinceCalendar: false, showUntilCalendar: false });
}
isValidSince(date) {
return (
!isValidMoment(this.state.until) ||
date <= moment(this.state.until, MOMENT_FORMAT)
);
}
isValidUntil(date) {
return (
!isValidMoment(this.state.since) ||
date >= moment(this.state.since, MOMENT_FORMAT)
);
}
toggleCalendar(key) {
const nextState = {};
if (key === 'showSinceCalendar') {
@ -352,6 +360,7 @@ class DateFilterControl extends React.Component {
}
this.setState(nextState);
}
renderInput(props, key) {
return (
<FormGroup>
@ -372,6 +381,7 @@ class DateFilterControl extends React.Component {
</FormGroup>
);
}
renderPopover() {
const grainOptions = TIME_GRAIN_OPTIONS.map(grain => (
<MenuItem
@ -575,6 +585,7 @@ class DateFilterControl extends React.Component {
</Popover>
);
}
render() {
const timeRange = this.props.value || defaultProps.value;
return (

7
superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx
View File

@ -95,9 +95,11 @@ export default class FilterBoxItemControl extends React.Component {
this.onChange = this.onChange.bind(this);
this.onControlChange = this.onControlChange.bind(this);
}
onChange() {
this.props.onChange(this.state);
}
onControlChange(attr, value) {
let typedValue = value;
const { column: selectedColumnName, multiple } = this.state;
@ -122,10 +124,13 @@ export default class FilterBoxItemControl extends React.Component {
}
this.setState({ [attr]: typedValue }, this.onChange);
}
setType() {}
textSummary() {
return this.state.column || 'N/A';
}
renderForm() {
return (
<div>
@ -257,6 +262,7 @@ export default class FilterBoxItemControl extends React.Component {
</div>
);
}
renderPopover() {
return (
<Popover id="ts-col-popo" title={t('Filter Configuration')}>
@ -264,6 +270,7 @@ export default class FilterBoxItemControl extends React.Component {
</Popover>
);
}
render() {
return (
<span>

4
superset-frontend/src/explore/components/controls/FixedOrMetricControl.jsx
View File

@ -66,6 +66,7 @@ export default class FixedOrMetricControl extends React.Component {
metricValue: type === controlTypes.metric ? value : null,
};
}
onChange() {
this.props.onChange({
type: this.state.type,
@ -75,12 +76,15 @@ export default class FixedOrMetricControl extends React.Component {
: this.state.metricValue,
});
}
setType(type) {
this.setState({ type }, this.onChange);
}
setFixedValue(fixedValue) {
this.setState({ fixedValue }, this.onChange);
}
setMetric(metricValue) {
this.setState({ metricValue }, this.onChange);
}

10
superset-frontend/src/explore/components/controls/SpatialControl.jsx
View File

@ -70,9 +70,11 @@ export default class SpatialControl extends React.Component {
this.onChange = this.onChange.bind(this);
this.renderReverseCheckbox = this.renderReverseCheckbox.bind(this);
}
componentDidMount() {
this.onChange();
}
onChange() {
const { type } = this.state;
const value = { type };
@ -101,18 +103,22 @@ export default class SpatialControl extends React.Component {
this.setState({ value, errors });
this.props.onChange(value, errors);
}
setType(type) {
this.setState({ type }, this.onChange);
}
close() {
this.refs.trigger.hide();
}
toggleCheckbox() {
this.setState(
{ reverseCheckbox: !this.state.reverseCheckbox },
this.onChange,
);
}
renderLabelContent() {
if (this.state.errors.length > 0) {
return 'N/A';
@ -128,6 +134,7 @@ export default class SpatialControl extends React.Component {
}
return null;
}
renderSelect(name, type) {
return (
<SelectControl
@ -144,6 +151,7 @@ export default class SpatialControl extends React.Component {
/>
);
}
renderReverseCheckbox() {
return (
<span>
@ -155,6 +163,7 @@ export default class SpatialControl extends React.Component {
</span>
);
}
renderPopover() {
return (
<Popover id="filter-popover">
@ -219,6 +228,7 @@ export default class SpatialControl extends React.Component {
</Popover>
);
}
render() {
return (
<div>

4
superset-frontend/src/explore/components/controls/TextAreaControl.jsx
View File

@ -68,9 +68,11 @@ export default class TextAreaControl extends React.Component {
onControlChange(event) {
this.props.onChange(event.target.value);
}
onAceChange(value) {
this.props.onChange(value);
}
renderEditor(inModal = false) {
const value = this.props.value || '';
if (this.props.language) {
@ -103,6 +105,7 @@ export default class TextAreaControl extends React.Component {
</FormGroup>
);
}
renderModalBody() {
return (
<div>
@ -111,6 +114,7 @@ export default class TextAreaControl extends React.Component {
</div>
);
}
render() {
const controlHeader = <ControlHeader {...this.props} />;
return (

2
superset-frontend/src/explore/components/controls/TextControl.tsx
View File

@ -36,6 +36,7 @@ export default class TextControl extends React.Component<TextControlProps> {
super(props);
this.onChange = this.onChange.bind(this);
}
onChange(event: any) {
let { value } = event.target;
@ -59,6 +60,7 @@ export default class TextControl extends React.Component<TextControlProps> {
}
this.props.onChange(value, errors);
}
render() {
const { value: rawValue } = this.props;
const value =

12
superset-frontend/src/explore/components/controls/TimeSeriesColumnControl.jsx
View File

@ -102,29 +102,39 @@ export default class TimeSeriesColumnControl extends React.Component {
this.state = state;
this.onChange = this.onChange.bind(this);
}
onChange() {
this.props.onChange(this.state);
}
onSelectChange(attr, opt) {
this.setState({ [attr]: opt.value }, this.onChange);
}
onTextInputChange(attr, event) {
this.setState({ [attr]: event.target.value }, this.onChange);
}
onCheckboxChange(attr, value) {
this.setState({ [attr]: value }, this.onChange);
}
onBoundsChange(bounds) {
this.setState({ bounds }, this.onChange);
}
onYAxisBoundsChange(yAxisBounds) {
this.setState({ yAxisBounds }, this.onChange);
}
setType() {}
textSummary() {
return `${this.state.label}`;
}
edit() {}
formRow(label, tooltip, ttLabel, control) {
return (
<Row style={{ marginTop: '5px' }}>
@ -140,6 +150,7 @@ export default class TimeSeriesColumnControl extends React.Component {
</Row>
);
}
renderPopover() {
return (
<Popover id="ts-col-popo" title="Column Configuration">
@ -297,6 +308,7 @@ export default class TimeSeriesColumnControl extends React.Component {
</Popover>
);
}
render() {
return (
<span>

5
superset-frontend/src/explore/components/controls/ViewportControl.jsx
View File

@ -60,12 +60,14 @@ export default class ViewportControl extends React.Component {
super(props);
this.onChange = this.onChange.bind(this);
}
onChange(ctrl, value) {
this.props.onChange({
...this.props.value,
[ctrl]: value,
});
}
renderTextControl(ctrl) {
return (
<div key={ctrl}>
@ -78,6 +80,7 @@ export default class ViewportControl extends React.Component {
</div>
);
}
renderPopover() {
return (
<Popover id={`filter-popover-${this.props.name}`} title="Viewport">
@ -85,6 +88,7 @@ export default class ViewportControl extends React.Component {
</Popover>
);
}
renderLabel() {
if (this.props.value.longitude && this.props.value.latitude) {
return `${decimal2sexagesimal(
@ -93,6 +97,7 @@ export default class ViewportControl extends React.Component {
}
return 'N/A';
}
render() {
return (
<div>

2
superset-frontend/src/profile/components/CreatedContent.tsx
View File

@ -47,6 +47,7 @@ class CreatedContent extends React.PureComponent<CreatedContentProps> {
/>
);
}
renderDashboardTable() {
const mutator = (data: Dashboard[]) =>
data.map(dash => ({
@ -65,6 +66,7 @@ class CreatedContent extends React.PureComponent<CreatedContentProps> {
/>
);
}
render() {
return (
<div>

2
superset-frontend/src/profile/components/Favorites.tsx
View File

@ -48,6 +48,7 @@ export default class Favorites extends React.PureComponent<FavoritesProps> {
/>
);
}
renderDashboardTable() {
const mutator = (data: Dashboard[]) =>
data.map(dash => ({
@ -66,6 +67,7 @@ export default class Favorites extends React.PureComponent<FavoritesProps> {
/>
);
}
render() {
return (
<div>

2
superset-frontend/src/utils/DebouncedMessageQueue.js
View File

@ -31,10 +31,12 @@ class DebouncedMessageQueue {
this.trigger = debounce(this.trigger.bind(this), this.delayThrehold);
this.callback = callback;
}
append(eventData) {
this.queue.push(eventData);
this.trigger();
}
trigger() {
if (this.queue.length > 0) {
const events = this.queue.splice(0, this.sizeThreshold);

2
superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
View File

@ -230,7 +230,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
};
const onTextChange = (event: React.ChangeEvent<HTMLTextAreaElement>) => {
const target = event.target;
const { target } = event;
const data = {
database_name: db ? db.database_name : '',
sqlalchemy_uri: db ? db.sqlalchemy_uri : '',

2
superset-frontend/src/visualizations/FilterBox/FilterBox.jsx
View File

@ -163,6 +163,7 @@ class FilterBox extends React.Component {
this.props.onChange(selectedValues, false);
});
}
changeFilter(filter, options) {
const fltr = TIME_FILTER_MAP[filter] || filter;
let vals = null;
@ -320,6 +321,7 @@ class FilterBox extends React.Component {
}
return datasourceFilters;
}
renderSelect(filterConfig) {
const { filtersChoices } = this.props;
const { selectedValues } = this.state;