iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: table autocomplete should pass catalog (#28413)

This commit is contained in:
Beto Dealmeida 2024-05-09 15:57:31 -04:00 committed by GitHub
parent 307ebeaa19
commit e516bba8fc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.test.ts
View File

@ -61,6 +61,7 @@ const fakeFunctionNamesApiResult = {
};
const expectDbId = 1;
const expectCatalog = null;
const expectSchema = 'schema1';
beforeEach(() => {
@ -228,7 +229,12 @@ test('returns column keywords among selected tables', async () => {
),
);
storeWithSqlLab.dispatch(
addTable({ id: expectQueryEditorId }, expectTable, expectSchema),
addTable(
{ id: expectQueryEditorId },
expectTable,
expectCatalog,
expectSchema,
),
);
});
@ -267,7 +273,12 @@ test('returns column keywords among selected tables', async () => {
act(() => {
storeWithSqlLab.dispatch(
addTable({ id: expectQueryEditorId }, unexpectedTable, expectSchema),
addTable(
{ id: expectQueryEditorId },
unexpectedTable,
expectCatalog,
expectSchema,
),
);
});

4
superset-frontend/src/SqlLab/components/AceEditorWrapper/useKeywords.ts
View File

@ -146,7 +146,9 @@ export function useKeywords(
const insertMatch = useEffectEvent((editor: Editor, data: any) => {
if (data.meta === 'table') {
dispatch(addTable({ id: queryEditorId, dbId }, data.value, schema));
dispatch(
addTable({ id: queryEditorId, dbId }, data.value, catalog, schema),
);
}
let { caption } = data;