iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: fix extra insert for count on dataset creation (#24625)

This commit is contained in:
Hugh A. Miles II 2023-07-10 12:55:11 -04:00 committed by GitHub
parent fe2c14ff3a
commit e6e8276a20
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
superset/datasets/commands/create.py
View File

@ -22,7 +22,6 @@ from marshmallow import ValidationError
from sqlalchemy.exc import SQLAlchemyError
from superset.commands.base import BaseCommand, CreateMixin
from superset.connectors.sqla.models import SqlMetric
from superset.daos.dataset import DatasetDAO
from superset.daos.exceptions import DAOCreateFailedError
from superset.datasets.commands.exceptions import (
@ -47,9 +46,7 @@ class CreateDatasetCommand(CreateMixin, BaseCommand):
# Creates SqlaTable (Dataset)
dataset = DatasetDAO.create(self._properties, commit=False)
# Updates columns and metrics from the dataset
dataset.metrics = [SqlMetric(metric_name="COUNT(*)", expression="COUNT(*)")]
# Updates columns and metrics from the datase
dataset.fetch_metadata(commit=False)
db.session.commit()
except (SQLAlchemyError, DAOCreateFailedError) as ex:

2
superset/utils/pandas_postprocessing/prophet.py
View File

@ -52,7 +52,7 @@ def _prophet_fit_and_predict( # pylint: disable=too-many-arguments
Fit a prophet model and return a DataFrame with predicted results.
"""
try:
# pylint: disable=import-error,import-outside-toplevel
# pylint: disable=import-outside-toplevel
from prophet import Prophet
prophet_logger = logging.getLogger("prophet.plot")