diff --git a/superset/security.py b/superset/security.py index 11759852a..b1274f05f 100644 --- a/superset/security.py +++ b/superset/security.py @@ -104,16 +104,16 @@ def get_or_create_main_db(): def is_admin_only(pvm): # not readonly operations on read only model views allowed only for admins - if (pvm.view_menu.name in READ_ONLY_MODEL_VIEWS - and pvm.permission.name not in READ_ONLY_PERMISSION): + if (pvm.view_menu.name in READ_ONLY_MODEL_VIEWS and + pvm.permission.name not in READ_ONLY_PERMISSION): return True - return (pvm.view_menu.name in ADMIN_ONLY_VIEW_MENUS - or pvm.permission.name in ADMIN_ONLY_PERMISSIONS) + return (pvm.view_menu.name in ADMIN_ONLY_VIEW_MENUS or + pvm.permission.name in ADMIN_ONLY_PERMISSIONS) def is_alpha_only(pvm): - if (pvm.view_menu.name in GAMMA_READ_ONLY_MODEL_VIEWS - and pvm.permission.name not in READ_ONLY_PERMISSION): + if (pvm.view_menu.name in GAMMA_READ_ONLY_MODEL_VIEWS and + pvm.permission.name not in READ_ONLY_PERMISSION): return True return pvm.permission.name in ALPHA_ONLY_PERMISSIONS diff --git a/superset/sql_lab.py b/superset/sql_lab.py index 50bcc1b52..dffa85c81 100644 --- a/superset/sql_lab.py +++ b/superset/sql_lab.py @@ -153,8 +153,8 @@ def execute_sql( query.user_id, start_dttm.strftime('%Y_%m_%d_%H_%M_%S')) executed_sql = superset_query.as_create_table(query.tmp_table_name) query.select_as_cta_used = True - elif (query.limit and superset_query.is_select() - and db_engine_spec.limit_method == LimitMethod.WRAP_SQL): + elif (query.limit and superset_query.is_select() and + db_engine_spec.limit_method == LimitMethod.WRAP_SQL): executed_sql = database.wrap_sql_limit(executed_sql, query.limit) query.limit_used = True try: diff --git a/superset/utils.py b/superset/utils.py index 569147bad..0bdf30d0b 100644 --- a/superset/utils.py +++ b/superset/utils.py @@ -377,8 +377,8 @@ def generic_find_constraint_name(table, columns, referenced, db): t = sa.Table(table, db.metadata, autoload=True, autoload_with=db.engine) for fk in t.foreign_key_constraints: - if (fk.referred_table.name == referenced - and set(fk.column_keys) == columns): + if (fk.referred_table.name == referenced and + set(fk.column_keys) == columns): return fk.name diff --git a/tests/core_tests.py b/tests/core_tests.py index 41556d15e..062da5e72 100644 --- a/tests/core_tests.py +++ b/tests/core_tests.py @@ -695,8 +695,8 @@ class CoreTests(SupersetTestCase): def test_fetch_datasource_metadata(self): self.login(username='admin') url = ( - '/superset/fetch_datasource_metadata?' - + 'datasourceKey=1__table' + '/superset/fetch_datasource_metadata?' + + 'datasourceKey=1__table' ) resp = self.get_json_resp(url) keys = [ diff --git a/tests/security_tests.py b/tests/security_tests.py index ac7e0c80d..cb2ff634b 100644 --- a/tests/security_tests.py +++ b/tests/security_tests.py @@ -168,4 +168,3 @@ class RolePermissionTests(SupersetTestCase): self.assert_cannot_gamma(granter_set) self.assert_cannot_alpha(granter_set) - diff --git a/tox.ini b/tox.ini index 5e197a081..e94a5e772 100644 --- a/tox.ini +++ b/tox.ini @@ -47,11 +47,6 @@ ignore = F405 Q000 Q001 - W291 - W292 - W293 - W391 - W503 import-order-style = google max-line-length = 90