iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update contributing a bit re contributing code (#2903) 

* CONTRIBUTING: document starter_task label

* CONTRIBUTING: PR should work travis python versions

* CONTRIBUTING: move PR guidelines at the top

* CONTRIBUTING: no need to open a new pr after review
This commit is contained in:
Riccardo Magliocchetti 2017-06-05 03:00:33 +02:00 committed by Maxime Beauchemin
parent f7ce100180
commit ed8153ff8b
1 changed files with 19 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
CONTRIBUTING.md
View File

@ -26,7 +26,7 @@ open to whoever wants to implement it.
### Implement Features ### Implement Features
Look through the GitHub issues for features. Anything tagged with Look through the GitHub issues for features. Anything tagged with
"feature" is open to whoever wants to implement it. "feature" or "starter_task" is open to whoever wants to implement it.
### Documentation ### Documentation
@ -47,6 +47,24 @@ If you are proposing a feature:
- Remember that this is a volunteer-driven project, and that - Remember that this is a volunteer-driven project, and that
contributions are welcome :) contributions are welcome :)
## Pull Request Guidelines
Before you submit a pull request from your forked repo, check that it
meets these guidelines:
1. The pull request should include tests, either as doctests,
unit tests, or both.
2. If the pull request adds functionality, the docs should be updated
as part of the same PR. Doc string are often sufficient, make
sure to follow the sphinx compatible standards.
3. The pull request should work for Python 2.7, and ideally python 3.4+.
``from __future__ import`` will be required in every `.py` file soon.
4. Code will be reviewed by re running the unittests, flake8 and syntax
should be as rigorous as the core Python project.
5. Please rebase and resolve all conflicts before submitting.
6. If you are asked to update your pull request with some changes there's
no need to create a new one. Push your changes to the same branch.
## Documentation ## Documentation
The latest documentation and tutorial are available [here](http://airbnb.io/superset). The latest documentation and tutorial are available [here](http://airbnb.io/superset).
@ -292,23 +310,6 @@ The `variables.less` and `bootswatch.less` files that ship with Superset are der
[Bootswatch](https://bootswatch.com) and thus extend Bootstrap. Modify variables in these files directly, or [Bootswatch](https://bootswatch.com) and thus extend Bootstrap. Modify variables in these files directly, or
swap them out entirely with the equivalent files from other Bootswatch (themes)[https://github.com/thomaspark/bootswatch.git] swap them out entirely with the equivalent files from other Bootswatch (themes)[https://github.com/thomaspark/bootswatch.git]
## Pull Request Guidelines
Before you submit a pull request from your forked repo, check that it
meets these guidelines:
1. The pull request should include tests, either as doctests,
unit tests, or both.
2. If the pull request adds functionality, the docs should be updated
as part of the same PR. Doc string are often sufficient, make
sure to follow the sphinx compatible standards.
3. The pull request should work for Python 2.6, 2.7, and ideally python 3.3.
``from __future__ import`` will be required in every `.py` file soon.
4. Code will be reviewed by re running the unittests, flake8 and syntax
should be as rigorous as the core Python project.
5. Please rebase and resolve all conflicts before submitting.
## Translations ## Translations
We use [Babel](http://babel.pocoo.org/en/latest/) to translate Superset. The We use [Babel](http://babel.pocoo.org/en/latest/) to translate Superset. The