fix: KeyError 'sql' when opening a Trino virtual dataset (#30339)

This commit is contained in:
Michael S. Molina 2024-09-19 17:41:08 -03:00 committed by GitHub
parent 9b87ca9209
commit ef9e5e523d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 5 deletions

View File

@ -17,7 +17,6 @@
# pylint: disable=too-few-public-methods, too-many-arguments
from __future__ import annotations
import copy
import logging
from typing import Any, TYPE_CHECKING
@ -152,8 +151,6 @@ class ExecuteSqlCommand(BaseCommand):
self._validate_access(query)
self._execution_context.set_query(query)
rendered_query = self._sql_query_render.render(self._execution_context)
validate_rendered_query = copy.copy(query)
validate_rendered_query.sql = rendered_query
self._set_query_limit_if_required(rendered_query)
self._query_dao.update(
query, {"limit": self._execution_context.query.limit}

View File

@ -90,7 +90,6 @@ class SynchronousSqlJsonExecutor(SqlJsonExecutorBase):
rendered_query: str,
log_params: dict[str, Any] | None,
) -> SqlJsonExecutionStatus:
print(">>> execute <<<")
query_id = execution_context.query.id
try:
data = self._get_sql_results_with_timeout(
@ -102,7 +101,6 @@ class SynchronousSqlJsonExecutor(SqlJsonExecutorBase):
raise
except Exception as ex:
logger.exception("Query %i failed unexpectedly", query_id)
print(str(ex))
raise SupersetGenericDBErrorException(
utils.error_msg_from_exception(ex)
) from ex