iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(dashboard): missing null check in error extra (#27845)

This commit is contained in:
JUST.in DO IT 2024-04-02 09:20:43 -07:00 committed by GitHub
parent 8bdf457dfa
commit f25795c4e4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/src/components/ErrorMessage/DatabaseErrorMessage.test.tsx
View File

@ -56,7 +56,14 @@ const mockedProps = {
};
test('should render', () => {
const { container } = render(<DatabaseErrorMessage {...mockedProps} />);
const nullExtraProps = {
...mockedProps,
error: {
...mockedProps.error,
extra: null,
},
};
const { container } = render(<DatabaseErrorMessage {...nullExtraProps} />);
expect(container).toBeInTheDocument();
});

4
superset-frontend/src/components/ErrorMessage/DatabaseErrorMessage.tsx
View File

@ -36,7 +36,7 @@ function DatabaseErrorMessage({
error,
source = 'dashboard',
subtitle,
}: ErrorMessageComponentProps<DatabaseErrorExtra>) {
}: ErrorMessageComponentProps<DatabaseErrorExtra | null>) {
const { extra, level, message } = error;
const isVisualization = ['dashboard', 'explore'].includes(source);
@ -47,7 +47,7 @@ function DatabaseErrorMessage({
{t('This may be triggered by:')}
<br />
{extra.issue_codes
.map<React.ReactNode>(issueCode => (
?.map<React.ReactNode>(issueCode => (
<IssueCode {...issueCode} key={issueCode.code} />
))
.reduce((prev, curr) => [prev, <br />, curr])}