fix: flaky test when sync metadata (#21306)

This commit is contained in:
Yongjie Zhao 2022-09-02 17:22:49 +08:00 committed by GitHub
parent 2d70ef670e
commit f71ee2e7bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions

View File

@ -453,7 +453,8 @@ class TestDatabaseModel(SupersetTestCase):
# make sure the columns have been mapped properly
assert len(table.columns) == 4
table.fetch_metadata(commit=False)
with db.session.no_autoflush:
table.fetch_metadata(commit=False)
# assert that the removed column has been dropped and
# the physical and calculated columns are present
@ -465,15 +466,13 @@ class TestDatabaseModel(SupersetTestCase):
}
cols: Dict[str, TableColumn] = {col.column_name: col for col in table.columns}
# assert that the type for intcol has been updated (asserting CI types)
backend = get_example_database().backend
backend = table.database.backend
assert VIRTUAL_TABLE_INT_TYPES[backend].match(cols["intcol"].type)
# assert that the expression has been replaced with the new physical column
assert cols["mycase"].expression == ""
assert VIRTUAL_TABLE_STRING_TYPES[backend].match(cols["mycase"].type)
assert cols["expr"].expression == "case when 1 then 1 else 0 end"
db.session.delete(table)
@patch("superset.models.core.Database.db_engine_spec", BigQueryEngineSpec)
def test_labels_expected_on_mutated_query(self):
query_obj = {