From f87163413bff72935fc6c95fa9d34468de99b86e Mon Sep 17 00:00:00 2001 From: michellethomas Date: Thu, 12 Oct 2017 17:51:26 -0700 Subject: [PATCH] Making the sort order for metrics pull from fd for time table viz (#3661) --- superset/assets/visualizations/time_table.jsx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/superset/assets/visualizations/time_table.jsx b/superset/assets/visualizations/time_table.jsx index 38f193b94..4a6e179ca 100644 --- a/superset/assets/visualizations/time_table.jsx +++ b/superset/assets/visualizations/time_table.jsx @@ -44,8 +44,14 @@ function viz(slice, payload) { metricMap[m.metric_name] = m; }); - const metrics = payload.data.columns; - const defaultSort = { column: fd.column_collection[0].key, direction: 'desc' }; + let metrics; + let defaultSort = null; + if (payload.data.is_group_by) { + metrics = payload.data.columns; + defaultSort = { column: fd.column_collection[0].key, direction: 'desc' }; + } else { + metrics = fd.metrics; + } const tableData = metrics.map((metric) => { let leftCell; const context = Object.assign({}, fd, { metric });